Bug 1781095 - Hide partial engine-cleanup option
Summary: Hide partial engine-cleanup option
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: ovirt-engine
Classification: oVirt
Component: Setup.Core
Version: 4.3.6.7
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ovirt-4.4.0
: ---
Assignee: Yedidyah Bar David
QA Contact: Guilherme Santos
URL:
Whiteboard:
Depends On:
Blocks: 1792874
TreeView+ depends on / blocked
 
Reported: 2019-12-09 10:29 UTC by Yedidyah Bar David
Modified: 2020-07-29 22:52 UTC (History)
6 users (show)

Fixed In Version:
Clone Of:
: 1792874 (view as bug list)
Environment:
Last Closed: 2020-05-20 20:04:08 UTC
oVirt Team: Integration
Embargoed:
pm-rhel: ovirt-4.4+
sbonazzo: devel_ack+


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
oVirt gerrit 105239 0 None MERGED packaging: setup: Warn about unsupported partial cleanup 2020-08-03 20:19:41 UTC
oVirt gerrit 105847 0 master MERGED packaging: cleanup: Hide partial cleanup option 2020-08-03 20:19:41 UTC

Description Yedidyah Bar David 2019-12-09 10:29:25 UTC
Description of problem:

When running engine-cleanup, it asks:

    Do you want to remove all components? (Yes, No) [Yes]: 

If you reply No, it asks you what components to remove, but nevertheless removes also other stuff, leaving the system partially broken. We had in the past bug 1060529 for doing this, but it was eventually closed due to lack of interest.

We should somehow make it clear that 'No' is not supported. Perhaps add a warning, confirm, or require setting some env key to enable this.

Comment 1 Yedidyah Bar David 2019-12-23 11:38:59 UTC
Sandro, I think we want this fixed also in 4.3. What do you think?

Comment 2 Yedidyah Bar David 2019-12-23 11:39:40 UTC
See also bug 1773704.

Comment 3 Sandro Bonazzola 2020-01-07 12:10:02 UTC
I would prefer not changing too much UX especially so late in 4.3 life. Martin?

Comment 4 Martin Tessun 2020-01-17 08:07:48 UTC
(In reply to Sandro Bonazzola from comment #3)
> I would prefer not changing too much UX especially so late in 4.3 life.
> Martin?

Well ... 4.3 will be around for quite some time. We should at least document that partial cleanup is not supported and may break your installation in the docs.

Comment 6 RHV bug bot 2020-01-24 19:50:30 UTC
INFO: Bug status wasn't changed from MODIFIED to ON_QA due to the following reason:

[Tag 'ovirt-engine-4.4.0' doesn't contain patch 'https://gerrit.ovirt.org/105239']
gitweb: https://gerrit.ovirt.org/gitweb?p=ovirt-engine.git;a=shortlog;h=refs/tags/ovirt-engine-4.4.0

For more info please contact: infra

Comment 7 Guilherme Santos 2020-03-23 21:07:29 UTC
Verified on:
ovirt-engine-4.4.0-0.25.master.el8ev.noarch

Steps:
1. # engine-cleanup

Results:
Cleanup done successfully without asking if should remove all components

Comment 8 Sandro Bonazzola 2020-05-20 20:04:08 UTC
This bugzilla is included in oVirt 4.4.0 release, published on May 20th 2020.

Since the problem described in this bug report should be
resolved in oVirt 4.4.0 release, it has been closed with a resolution of CURRENT RELEASE.

If the solution does not work for you, please open a new bug report.


Note You need to log in before you can comment on or make changes to this bug.