Bug 1777797 - glibc: z15 (s390x) strstr implementation can return incorrect result if search string cross page boundary [rhel-8.1.0.z]
Summary: glibc: z15 (s390x) strstr implementation can return incorrect result if searc...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux 8
Classification: Red Hat
Component: glibc
Version: 8.1
Hardware: s390x
OS: Linux
high
urgent
Target Milestone: rc
: ---
Assignee: Florian Weimer
QA Contact: qe-baseos-tools-bugs
URL:
Whiteboard:
Depends On: 1777241
Blocks: 1765059
TreeView+ depends on / blocked
 
Reported: 2019-11-28 10:42 UTC by Oneata Mircea Teodor
Modified: 2023-07-18 14:30 UTC (History)
10 users (show)

Fixed In Version: glibc-2.28-72.el8_1.1
Doc Type: Bug Fix
Doc Text:
Cause: On certain s390x platforms (z15, previously known as arch13), the strstr function did not correctly update a CPU register when handling search patterns which cross a page boundary. Consequence: strstr could return false matches. Fix: The page boundary case in the strstr function variant for z15 was changed to update the correct CPU register. Result: strstr no longer returns false matches for a truncated pattern.
Clone Of: 1777241
Environment:
Last Closed: 2020-02-04 13:11:33 UTC
Type: ---
Target Upstream Version:
Embargoed:

Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
IBM Linux Technology Center 182625 0 None None None 2019-11-28 14:39:16 UTC
Red Hat Product Errata RHBA-2020:0336 0 None None None 2020-02-04 13:11:36 UTC
Sourceware 25226 0 P2 RESOLVED strstr: Invalid result if needle crosses page on s390-z15 ifunc variant. 2020-12-15 13:57:14 UTC

Comment 1 Florian Weimer 2019-11-28 11:24:07 UTC 
Upstream commit:

commit bfdb731438206b0f70fe7afa890681155c30b419
Author: Stefan Liebler <stli.com>
Date:   Wed Nov 27 12:35:40 2019 +0100

    S390: Fix handling of needles crossing a page in strstr z15 ifunc-variant. [BZ #25226]
    
    If the specified needle crosses a page-boundary, the s390-z15 ifunc variant of
    strstr truncates the needle which results in invalid results.
    
    This is fixed by loading the needle beyond the page boundary to v18 instead of v16.
    The bug is sometimes observable in test-strstr.c in check1 and check2 as the
    haystack and needle is stored on stack. Thus the needle can be on a page boundary.
    
    check2 is now extended to test haystack / needles located on stack, at end of page
    and on two pages.
    
    This bug was introduced with commit 6f47401bd5fc71209219779a0426170a9a7395b0
    ("S390: Add arch13 strstr ifunc variant.") and is already released in glibc 2.30.
Comment 3 Hanns-Joachim Uhl 2019-11-28 14:42:31 UTC 
fyi ... IBM will do fix verification ... setting OtherQA ...
Comment 5 Sergey Kolosov 2020-01-08 12:09:57 UTC 
IBM, could you verify the bug please?
Comment 6 Hanns-Joachim Uhl 2020-01-08 12:38:42 UTC 
(In reply to Sergey Kolosov from comment #5)
> IBM, could you verify the bug please?
.
Hello Red Hat / Florian,
can you please provide us the updated "glibc-2.28-72.el8_1.1" rpm _for s390x_ for our verification ..?
Please advise ...
Thanks for your support.
Comment 7 Florian Weimer 2020-01-08 20:48:57 UTC 
(In reply to Hanns-Joachim Uhl from comment #6)
> (In reply to Sergey Kolosov from comment #5)
> > IBM, could you verify the bug please?
> .
> Hello Red Hat / Florian,
> can you please provide us the updated "glibc-2.28-72.el8_1.1" rpm _for
> s390x_ for our verification ..?
> Please advise ...
> Thanks for your support.

I've provided download instructions by email.
Comment 8 IBM Bug Proxy 2020-01-09 11:30:23 UTC 
------- Comment From STLI.com 2020-01-09 06:25 EDT-------
I've installed RHEL 8.1 with the provided glibc 2.28-72.el8_1.1 package and verified that the patch is applied.
Thanks
Comment 9 Sergey Kolosov 2020-01-10 17:31:47 UTC 
Based on https://bugzilla.redhat.com/show_bug.cgi?id=1777797#c8 and after sanity check set as verified.
Comment 11 errata-xmlrpc 2020-02-04 13:11:33 UTC 
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:0336
Note You need to log in before you can comment on or make changes to this bug.