New commit detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/6b1fde82958a73f617c009ff76048dbf9d2db899 commit 6b1fde82958a73f617c009ff76048dbf9d2db899 Author: Milan Zázrivec <mzazrivec> AuthorDate: Fri Dec 13 04:57:56 2019 -0500 Commit: Milan Zázrivec <mzazrivec> CommitDate: Fri Dec 13 04:57:56 2019 -0500 Merge pull request #6533 from h-kataria/generic_object_playbook_custom_button_add_fix Fixed code to pass in `service_template` in ae_attributes hash (cherry picked from commit 7b8d0c6aef15e0161ace997f595b9acf29a17153) Fixes https://bugzilla.redhat.com/show_bug.cgi?id=1784190 app/assets/javascripts/components/generic_object/main-custom-button-form.js | 1 + spec/javascripts/components/generic_object_definition/main-custom-button-form_spec.js | 1 + 2 files changed, 2 insertions(+)
Hey John, per https://github.com/ManageIQ/manageiq-content/pull/113#issue-119924618, since we stated that the service template name is necessary for this to run, please retest with that as a param just like Madhu's image on the PR shows and update this ticket with the results. Thanks!
Note that when you edit a custom button, the parameters/attributes that you added will no longer show up after editing the button. This is potentially a blocker for the verification of this BZ. bug 1793556
On the appliance that's reproducing this, I'm still seeing resource actions created at https://github.com/ManageIQ/manageiq-api/blob/master/app/controllers/api/custom_buttons_controller.rb#L42 when I would expect existing ones to be found. Moreover when it does create new ones it doesn't seem to create them with the information from the UI that I entered.
Possibly because of https://github.com/ManageIQ/manageiq-ui-classic/blob/7b8d0c6aef15e0161ace997f595b9acf29a17153/app/assets/javascripts/components/generic_object/main-custom-button-form.js#L211 ?
Hey @Tina or @Billy, what's the correct setup for the field that has the service_template_name as a required param for ordering an ansible playbook? we say it's required in the comment, could we also say what the format needs to be in order for it to be passed, please?
Zita's fix makes my needinfos moot.
Bug #1793556 is now VERIFIED, so moving this to ON_QA for retest.
Verified in 5.11.5.2. An important note is that when the button is created through "Automation > Automate > Generic Objects" I had to add the attribute/value pair ("service_template_name"/"VMware Catalog Item") manually in order for this to work. When the button is created through "Automation > Customization > Buttons" no such step is necessary.
Any chance anyone else thinks we should probably have some coverage in docs somewhere around comment 21?
@drew yeah I definitely think we should have some documentation about that. It should maybe even be done for you? From my perspective, though the user is creating the button from different places, both methods should result in the same button. What do you think?
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2020