Created attachment 1654280 [details] Video of the BZ Description of problem: There is no indication that edited attributes of an existing generic object buttons persist in the UI. Version-Release number of selected component (if applicable): 5.11.2.0 How reproducible: 100% Steps to Reproduce: 1. Create a generic object button 2. Edit the generic object button to add some attributes 3. Edit the generic object button again Actual results: The new attributes don't show up in the UI Expected results: The new attributes should show up and be correct Additional info: This is related to bug 1753237, but for the attributes of the generic object button. See the attached video for a demonstration of the BZ
I think this is related to comments 7 and 8 on https://bugzilla.redhat.com/show_bug.cgi?id=1784190
https://github.com/ManageIQ/manageiq-api/pull/728
https://github.com/ManageIQ/manageiq-ui-classic/pull/6695 https://github.com/ManageIQ/manageiq-ui-classic/pull/6690
New commit detected on ManageIQ/manageiq-api/ivanchuk: https://github.com/ManageIQ/manageiq-api/commit/c527e8373c11ab174a2a15df71295f7ea511f71c commit c527e8373c11ab174a2a15df71295f7ea511f71c Author: Libor Pichler <lpichler> AuthorDate: Mon Feb 24 15:04:12 2020 +0000 Commit: Libor Pichler <lpichler> CommitDate: Mon Feb 24 15:04:12 2020 +0000 Merge pull request #728 from ZitaNemeckova/fix_custom_button_update Fix update of CustomButton to save ae_attributes (cherry picked from commit ea2365cb085aa8618da596e28402e9ec6e39ce6b) https://bugzilla.redhat.com/show_bug.cgi?id=1793556 app/controllers/api/custom_buttons_controller.rb | 47 +- spec/requests/custom_buttons_spec.rb | 8 +- 2 files changed, 35 insertions(+), 20 deletions(-)
New commits detected on ManageIQ/manageiq-ui-classic/ivanchuk: https://github.com/ManageIQ/manageiq-ui-classic/commit/889b8325f76bd8f89d8cfcd9c78d2cccd4e3a139 commit 889b8325f76bd8f89d8cfcd9c78d2cccd4e3a139 Author: Milan Zázrivec <mzazrivec> AuthorDate: Thu Feb 20 11:21:44 2020 +0000 Commit: Milan Zázrivec <mzazrivec> CommitDate: Thu Feb 20 11:21:44 2020 +0000 Merge pull request #6690 from ZitaNemeckova/send_resource_id Send resource_id via API when editing CustomButton (cherry picked from commit 0fb13ab51d9cfe3d314e47eb505af6d14cf7e52b) https://bugzilla.redhat.com/show_bug.cgi?id=1793556 app/assets/javascripts/components/generic_object/main-custom-button-form.js | 2 + 1 file changed, 2 insertions(+) https://github.com/ManageIQ/manageiq-ui-classic/commit/8a0846d105eb1becbcd6683cda6cde1c6ac9cc14 commit 8a0846d105eb1becbcd6683cda6cde1c6ac9cc14 Author: Harpreet Kataria <hkataria> AuthorDate: Tue Feb 25 19:42:48 2020 +0000 Commit: Harpreet Kataria <hkataria> CommitDate: Tue Feb 25 19:42:48 2020 +0000 Merge pull request #6695 from ZitaNemeckova/use_uri_instead_of_ae Use uri_attributes in CustomButton instead of ae_attributes (cherry picked from commit 3710c3ce74a596401e279cc14579673119bc0c7a) https://bugzilla.redhat.com/show_bug.cgi?id=1793556 app/assets/javascripts/components/generic_object/main-custom-button-form.js | 30 +- spec/javascripts/components/generic_object_definition/main-custom-button-form_spec.js | 2 +- 2 files changed, 10 insertions(+), 22 deletions(-)
Verified on 5.11.5.1.
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory, and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2020