Bug 1785495 - Review Request: python-pwntools - A CTF framework and exploit development library
Summary: Review Request: python-pwntools - A CTF framework and exploit development lib...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
: 1697445 (view as bug list)
Depends On:
Blocks:
TreeView+ depends on / blocked
 
Reported: 2019-12-20 02:58 UTC by W. Michael Petullo
Modified: 2020-03-16 20:38 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-03-16 20:38:07 UTC
Type: ---
Embargoed:
zebob.m: fedora-review+


Attachments (Terms of Use)

Description W. Michael Petullo 2019-12-20 02:58:39 UTC
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1beta.fc31.src.rpm
Description:

I would like to (re)take ownership of the pwntools package that was recently retired:

https://bugzilla.redhat.com/show_bug.cgi?id=1701958

Fedora retired the package because pwntools had for some time not supported Python 3. Some of the Python 2 packages on which it depended had themselves been deprecated and orphanded.

The new beta version of pwntools now supports Python 3:

https://github.com/Gallopsled/pwntools/blob/4.0.0beta0/CHANGELOG.md

Pwntools is a CTF framework and exploit development library. Written in Python, it is designed for rapid prototyping and development, and intended to make exploit writing as simple as possible.

Fedora Account System Username: mikep

Comment 1 Miro Hrončok 2019-12-20 10:26:48 UTC
Spec sanity:

> Release:        0.1beta%{?dist}

This doesn't correspond with https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/#_more_complex_versioning

What about: 0.1.b0? Or even 4.0.0~b0 in version?



> https://files.pythonhosted.org/packages/source/p/%{srcname}/%{srcname}-%{version}beta0.tar.gz

Upstream calls this b0. The URL with beta0 seems not to work. Maybe us the %{pypi_source} macro?




> BuildRequires:  python3-devel

Add BR for python3-setuptools as that's what the upstream is using to build the package, but you only get it transitively. See the note in python3.spec if you want to know more (starts with '# This is not "API"').




> # Waiting on pwntools to support sphinx 1.7.

We no longer have 1.7, but 2.2. This comment is outdated.




> # %package doc
> # ...

Macros in comment.




> %{python3_sitelib}/%{srcname}-%{version}b0-py?.?.egg-info

This will break with Python 3.10. Use %{python3_version} instead of ?.?.




> %{python3_sitelib}/%{srcname}-%{version}b0-py?.?.egg-info
> %{python3_sitelib}/pwn
> %{python3_sitelib}/pwnlib


Add trailing slashes to directories to ensure there are always directories. egg-info has a bad habbit of changing from a directory to a file and breaking the package.

Comment 2 W. Michael Petullo 2019-12-23 14:01:27 UTC
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm

Description:

- Adjust package name to use beta0 rather than b0
- BuildRequires python3-setuptools
- Update sphinx comment
- Escape macros in comments
- Use %{python3_version}
- Add trailing slashes to directory paths

Comment 3 W. Michael Petullo 2019-12-30 13:29:41 UTC
*** Bug 1697445 has been marked as a duplicate of this bug. ***

Comment 4 Fabian Affolter 2019-12-30 22:56:56 UTC
Just some comments:

- URL:            https://pypi.python.org/pypi/%{srcname}

  I suggest to use the location of the upstream (https://github.com/Gallopsled/pwntools) instead of PyPI.

- Isn't the dependency generator picking-up the Requires:?

- According the pwntools documentation is binutils (https://docs.pwntools.com/en/stable/install/binutils.html) also a requirement.

Comment 5 W. Michael Petullo 2019-12-31 00:06:00 UTC
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm

Description:

- Use upstream URL
- Allow dependency generator to pick Python dependencies
- Require binutils

Comment 6 Fabian Affolter 2020-01-02 09:11:34 UTC
The spec file and the SRPM were not updated at the upload location.

Comment 7 W. Michael Petullo 2020-01-02 13:55:31 UTC
The spec file and the SRPM have indeed changed at the upload location. I did not increment the release tag, since there has not yet been an approved release of this version. Should I have?

Comment 8 Fabian Affolter 2020-01-02 21:24:22 UTC
It's hard to keep track if the release is not bumped. I saw the same release tag and that the URL still points to PyPI but the description says otherwise.

Comment 9 W. Michael Petullo 2020-01-02 22:14:23 UTC
Updated URL. I had updated the Source0 before.

Comment 10 Robert-André Mauchin 🐧 2020-01-07 22:35:33 UTC
 - Typo in URL and Source0: use % not $ for RPM variables:

URL:            https://github.com/Gallopsled/%{srcname}/
Source0:        https://github.com/Gallopsled/%{srcname}/archive/%{version}beta0.tar.gz

 - Package is not installable:

DEBUG util.py:582:  Error: 
DEBUG util.py:582:   Problem: conflicting requests
DEBUG util.py:582:    - nothing provides python3.8dist(intervaltree) >= 3 needed by python3-pwntools-4.0.0-0.1.b0.fc32.noarch

Seems you're the maintainer of intervaltree, update it to 3?

 - there's a weird list of files with a Py2 shebang

python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/__init__.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/asm.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/checksec.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/constgrep.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/cyclic.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/debug.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/disablenx.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/disasm.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/elfdiff.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/elfpatch.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/hex.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/phd.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/shellcraft.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/template.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/unhex.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/update.py 644 /usr/bin/env python
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/context/__init__.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/term/readline.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/timeout.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/tubes/buffer.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/util/sh_string.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/elf/datatypes.py 644 /usr/bin/env python
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/encoders/i386/xor.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/encoders/mips/xor.py 644 /usr/bin/env python2

   See with upstream if the python2 is what is intended.




Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
- Package does not use a name that already exists.
  Note: A package with this name already exists. Please check
  https://src.fedoraproject.org/rpms/python-pwntools
  See: https://docs.fedoraproject.org/en-US/packaging-
  guidelines/Naming/#_conflicting_package_names


===== MUST items =====

Generic:
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "Expat License", "*No copyright* BSD
     3-clause "New" or "Revised" License", "BSD 3-clause "New" or "Revised"
     License", "GNU General Public License". 1090 files have unknown
     license. Detailed output of licensecheck in
     /home/bob/packaging/review/python-pwntools/review-python-
     pwntools/licensecheck.txt
[x]: If the package is under multiple licenses, the licensing breakdown
     must be documented in the spec.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Package contains desktop file if it is a GUI application.
[-]: Development files must be in a -devel package
[x]: Package uses nothing in %doc for runtime.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 51200 bytes in 5 files.
[x]: Package complies to the Packaging Guidelines
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

Python:
[x]: Python eggs must not download any dependencies during the build
     process.
[x]: A package which is used by another package via an egg interface should
     provide egg info.
[x]: Package meets the Packaging Guidelines::Python
[x]: Package contains BR: python2-devel or python3-devel
[x]: Packages MUST NOT have dependencies (either build-time or runtime) on
     packages named with the unversioned python- prefix unless no properly
     versioned package exists. Dependencies on Python packages instead MUST
     use names beginning with python2- or python3- as appropriate.
[x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files
[x]: Binary eggs must be removed in %prep

===== SHOULD items =====

Generic:
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[?]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Reviewer should test that the package builds in mock.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Spec file according to URL is the same as in SRPM.



Rpmlint
-------
Checking: python3-pwntools-4.0.0-0.1.b0.fc32.noarch.rpm
          python-pwntools-4.0.0-0.1.b0.fc32.src.rpm
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/__init__.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/asm.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/checksec.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/constgrep.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/cyclic.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/debug.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/disablenx.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/disasm.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/elfdiff.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/elfpatch.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/hex.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/phd.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/shellcraft.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/template.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/unhex.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/commandline/update.py 644 /usr/bin/env python
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/context/__init__.py 644 /usr/bin/env python2
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/aarch64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/alpha.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/amd64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/arm.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/i386.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/ia64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/mips.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/powerpc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/powerpc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/s390.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/s390x.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/sparc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/sparc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/android/thumb.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/aarch64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/alpha.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/amd64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/arm.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/i386.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/ia64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/mips.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/powerpc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/powerpc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/s390.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/s390x.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/sparc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/sparc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/cgc/thumb.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/aarch64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/alpha.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/amd64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/arm.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/i386.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/ia64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/mips.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/powerpc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/powerpc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/s390.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/s390x.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/sparc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/sparc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/freebsd/thumb.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/aarch64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/alpha.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/amd64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/arm.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/i386.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/ia64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/mips.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/powerpc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/powerpc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/s390.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/s390x.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/sparc.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/sparc64.h
python3-pwntools.noarch: W: devel-file-in-non-devel-package /usr/lib/python3.8/site-packages/pwnlib/data/includes/linux/thumb.h
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/elf/datatypes.py 644 /usr/bin/env python
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/encoders/arm/alphanumeric/alphanumeric.py
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/encoders/i386/xor.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/encoders/mips/xor.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/aarch64/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/aarch64/android/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/aarch64/android/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/aarch64/freebsd/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/aarch64/linux/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/aarch64/linux/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/amd64/android/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/amd64/linux/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/arm/android/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/arm/linux/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/common/freebsd/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/common/linux/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/common/linux/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/i386/android/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/i386/cgc/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/i386/linux/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/mips/android/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/mips/linux/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/powerpc/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/powerpc/android/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/powerpc/android/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/powerpc/linux/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/powerpc/linux/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/thumb/android/syscalls/__doc__
python3-pwntools.noarch: E: zero-length /usr/lib/python3.8/site-packages/pwnlib/shellcraft/templates/thumb/linux/syscalls/__doc__
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/term/readline.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/timeout.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/tubes/buffer.py 644 /usr/bin/env python2
python3-pwntools.noarch: E: non-executable-script /usr/lib/python3.8/site-packages/pwnlib/util/sh_string.py 644 /usr/bin/env python2
python3-pwntools.noarch: W: no-manual-page-for-binary asm
python3-pwntools.noarch: W: no-manual-page-for-binary checksec
python3-pwntools.noarch: W: no-manual-page-for-binary common
python3-pwntools.noarch: W: no-manual-page-for-binary constgrep
python3-pwntools.noarch: W: no-manual-page-for-binary cyclic
python3-pwntools.noarch: W: no-manual-page-for-binary debug
python3-pwntools.noarch: W: no-manual-page-for-binary disablenx
python3-pwntools.noarch: W: no-manual-page-for-binary disasm
python3-pwntools.noarch: W: no-manual-page-for-binary elfdiff
python3-pwntools.noarch: W: no-manual-page-for-binary elfpatch
python3-pwntools.noarch: W: no-manual-page-for-binary errno
python3-pwntools.noarch: W: no-manual-page-for-binary hex
python3-pwntools.noarch: W: no-manual-page-for-binary main
python3-pwntools.noarch: W: no-manual-page-for-binary phd
python3-pwntools.noarch: W: no-manual-page-for-binary pwn
python3-pwntools.noarch: W: no-manual-page-for-binary pwnstrip
python3-pwntools.noarch: W: no-manual-page-for-binary scramble
python3-pwntools.noarch: W: no-manual-page-for-binary shellcraft
python3-pwntools.noarch: W: no-manual-page-for-binary template
python3-pwntools.noarch: W: no-manual-page-for-binary unhex
python3-pwntools.noarch: W: no-manual-page-for-binary update
2 packages and 0 specfiles checked; 50 errors, 78 warnings.

Comment 11 W. Michael Petullo 2020-01-07 23:19:14 UTC
Spec URL: https://www.flyn.org/SRPMS/python-pwntools.spec
SRPM URL: https://www.flyn.org/SRPMS/python-pwntools-4.0.0-0.1.b0.fc31.src.rpm

Description:

- Fix typos in URL and Source0

I separately updated the python-intervaltree in Rawhide. See https://koji.fedoraproject.org/koji/taskinfo?taskID=40254996.

I will bring up the Python 2 shebang issues with the upstream developers.

The package has a name that exists because I am revitalizing an orphaned package.

I will bring up the issues highlighted by rpmlint with the upstream developers.

Comment 12 W. Michael Petullo 2020-02-03 21:14:26 UTC
Upstream bug: https://github.com/Gallopsled/pwntools/issues/1404

Comment 13 Robert-André Mauchin 🐧 2020-03-08 20:34:52 UTC
Package approved.

Comment 14 Fedora Update System 2020-03-10 22:45:29 UTC
FEDORA-2020-70231bc5e4 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-70231bc5e4

Comment 15 Fedora Update System 2020-03-12 18:49:09 UTC
python-pwntools-4.0.0-0.1.b0.fc32 has been pushed to the Fedora 32 testing repository. If problems still persist, please make note of it in this bug report.
See https://fedoraproject.org/wiki/QA:Updates_Testing for
instructions on how to install test updates.
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-70231bc5e4

Comment 16 Fedora Update System 2020-03-16 20:38:07 UTC
python-pwntools-4.0.0-0.1.b0.fc32 has been pushed to the Fedora 32 stable repository. If problems still persist, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.