Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/helpdev/rnd1/python-helpdev.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/helpdev/rnd1/python-helpdev-0.6.10-1.fc31.src.rpm Description: Helping users and developers to get information about the environment to report bugs or even test your system without spending a day on it. It can get information about hardware, OS, paths, Python distribution and packages, including Qt-things. Fedora Account System Username: nonamedotc koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39893171
The package name is repeated in summary unnecessarily in summary. %description is repeated. I'd suggest the standard trick with %expand: %global _description %{expand: Helping users and developers to get information about the environment to report bugs or even test your system without spending a day on it. It can get information about hardware, OS, paths, Python distribution and packages, including Qt-things.} %description %_description %description -n python3-%{pypi_name} %_description > # install license file > mkdir -p %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name}/ > cp -pr %{SOURCE1} %{buildroot}/%{_datadir}/licenses/python3-%{pypi_name} It should suffice to do > %prep > cp ${SOURCE1} . But looking at the upstream repo, it already includes a license. Why not use that file? If it is not included in the pypi tarball, then provide a full URL to it: Source1: https://gitlab.com/dpizetta/helpdev/raw/master/LICENSE.rst Anyway, package looks good. + name is OK + license is acceptable (MIT) + license is specified correctly (upstream talks about CC-BY-4.0 for images, but there are no images in the binary package, so this doesn't apply). + builds OK + P/BR look OK Unfortunately the package does not install: - nothing provides python3dist(importlib-metadata) needed by python3-helpdev-0.6.10-1.fc32.noarch - nothing provides python3.8dist(importlib-metadata) needed by python3-helpdev-0.6.10-1.fc32.noarch
Ah, the package is retired with https://src.fedoraproject.org/rpms/python-importlib-metadata/blob/master/f/dead.package: Use the standard library importlib.metadata module instead. https://gitlab.com/dpizetta/helpdev/merge_requests/1
I have made the changes pointed out. I have implemented the patch from the upstream PR using sed. Modified SPEC: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/helpdev/rnd2/python-helpdev.spec Modified SRPM: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/helpdev/rnd2/python-helpdev-0.6.10-2.fc31.src.rpm
Remove: Requires: python3dist(importlib-metadata) and add in %prep sed -i "s|'importlib_metadata', ||" setup.py (or maybe make it conditional for F<=31 if you want to build for older releases too...) More formal review in comment #1. Package is APPROVED.
Thanks for the review. I will make the changes in c#4 when I import.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-helpdev
Built on rawhide.