Spec URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aiozmq/rnd1/python-aiozmq.spec SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aiozmq/rnd1/python-aiozmq-0.8.0-2.20191223git56065a26.fc31.src.rpm Description: asyncio (PEP 3156) support for ZeroMQ, a messaging library. Features: * Implements create_zmq_connection() coroutine for making 0MQ connections. * Provides ZmqTransport and ZmqProtocol * Provides RPC Request-Reply, Push-Pull and Publish-Subscribe patterns for remote calls. Fedora Account System Username: nonamedotc koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=39899386
Turns out the master branch of aiozmq has lots of fixes for building on recent versions of python. The spec/srpm above uses the master branch for the package. v0.8.0 was released in Dec 2016 and upstream has not released newer versions although there has been activity in the git repo.
http://aiozmq.readthedocs.org → https:// In general it is nicer to download the tarball directly from github (easier upgrades): %global commit 4e6703c7c56e07c58898228f5d4cf5cb56065a26 %{?commit:%global shortcommit %(c=%{commit}; echo ${c:0:7})} Source0: https://github.com/aio-libs/aiozmq/archive/%{commit}/%{name}-%{shortcommit}.tar.gz ... %prep %autosetup %{?commit:-n %{name}-%{commit}} %{python3_sitelib}/%{pypi_name}, %{python3_sitelib}/%{pypi_name}-%{version}-py?.?.egg-info → add trailing slash Looks good, but FTI: - nothing provides python3.8dist(pyzmq) < 17.1.2 needed by python3-aiozmq-0.8.0-2.20191223git56065a26.fc32.noarch The requirements specified in the sources are inconsistent, so maybe it does work with newer versions after all: aiozmq-0.8.0/requirements.txt: pyzmq>=14.2.0 aiozmq-0.8.0/setup.py: install_requires = ['pyzmq>=13.1,<17.1.2'] It would be useful to run the tests. If the test line is uncommented, it just says that the command is deprecated and does not run any tests. Using pytest seems to work fine, except that one test fails with "SocketOperation on a closed socket" or something like that. I'll attach a diff that makes the tests and installation pass for me.
Created attachment 1647742 [details] spec patch
Modified SPEC URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aiozmq/rnd2/python-aiozmq.spec Modified SRPM URL: https://nonamedotc.fedorapeople.org/pkgreview/python-packages/2019-2020/aiozmq/rnd2/python-aiozmq-0.8.0-3.20191223git56065a26.fc31.src.rpm Koji scratch build: https://koji.fedoraproject.org/koji/taskinfo?taskID=40041174 So, the shortcommit uses first seven chars from the commit and gitrev variable uses the last eight. I am not sure which one should be used. My understanding is last eight but I could be wrong.
> shortcommit uses first seven chars from the commit and gitrev variable uses the last eight The first seven (or eight) is appropriate. That snippet is supposed to uniquely identify the commit. So what matters is what git accepts. And git accepts any prefix of the sha1 hash, as long as it is unique. Something like 7 or 8 characters is usually unique, and 7 was the default abbreviation in git for a long time iirc. + package name is OK + latest version (recent git snapshot) + license is acceptable for Fedora (BSD) + license is specified correctly + builds and installs OK + BR/R/P look OK rpmlint has only bogus hints. Package is APPROVED.
Thanks for the review and clarification! I will change gitrev to match the shortcommit when I import.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-aiozmq