Spec URL: https://raw.githubusercontent.com/andreasgerstmayr/specs/master/reviews/golang-github-dchest-uniuri/golang-github-dchest-uniuri.spec SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/golang-github-dchest-uniuri/golang-github-dchest-uniuri-0-0.1.20200207git8902c56.fc31.src.rpm Description: Go package uniuri generates random strings good for use in URIs to identify unique objects Fedora Account System Username: agerstmayr
All good, except for one minor rpmlint error: summary line in spec is too long. Also, this BZ blocks BZ 1800675 (which blocks other BZs) so the order is important. golang-github-dchest-uniuri-devel.noarch: E: summary-too-long C Go package uniuri generates random strings good for use in URIs to identify unique objects The "public domain" license matches upstream and is approved in the packageing guidelines (https://fedoraproject.org/wiki/Licensing:Main?rd=Licensing#SoftwareLicenses) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [-]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-dchest-uniuri-devel-0-0.1.20200207git8902c56.fc31.noarch.rpm golang-github-dchest-uniuri-0-0.1.20200207git8902c56.fc31.src.rpm golang-github-dchest-uniuri-devel.noarch: E: summary-too-long C Go package uniuri generates random strings good for use in URIs to identify unique objects golang-github-dchest-uniuri-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/dchest/uniuri/.goipath golang-github-dchest-uniuri.src: E: summary-too-long C Go package uniuri generates random strings good for use in URIs to identify unique objects golang-github-dchest-uniuri.src: W: no-%build-section 2 packages and 0 specfiles checked; 2 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- Source checksums ---------------- https://github.com/dchest/uniuri/archive/8902c56451e9b58ff940bbe5fec35d5f9c04584a/uniuri-8902c56451e9b58ff940bbe5fec35d5f9c04584a.tar.gz : CHECKSUM(SHA256) this package : f0e76f66c27b485fb8fd76ed0da635bf34751714487a16931f07bf1b1986b30f CHECKSUM(SHA256) upstream package : f0e76f66c27b485fb8fd76ed0da635bf34751714487a16931f07bf1b1986b30f Requires -------- golang-github-dchest-uniuri-devel (rpmlib, GLIBC filtered): go-filesystem Provides -------- golang-github-dchest-uniuri-devel: golang(github.com/dchest/uniuri) golang(github.com/dchest/uniuri)(commit=8902c56451e9b58ff940bbe5fec35d5f9c04584a) golang-github-dchest-uniuri-devel golang-ipath(github.com/dchest/uniuri) golang-ipath(github.com/dchest/uniuri)(commit=8902c56451e9b58ff940bbe5fec35d5f9c04584a) Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1800666 -m fedora-31-x86_64 Buildroot used: fedora-31-x86_64 Active plugins: Shell-api, Generic Disabled plugins: fonts, SugarActivity, Java, Ocaml, Haskell, R, Python, C/C++, Perl, PHP Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Thanks for the review! I've shortened the summary and updated the spec and SRPM at the same location.
(In reply to Andreas Gerstmayr from comment #2) > Thanks for the review! > > I've shortened the summary and updated the spec and SRPM at the same > location. all looks good now, package approved! Please be sure to get this pushed in before crewjam-saml.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-dchest-uniuri