Spec URL: https://raw.githubusercontent.com/andreasgerstmayr/specs/master/reviews/golang-github-crewjam-saml/golang-github-crewjam-saml.spec SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/golang-github-crewjam-saml/golang-github-crewjam-saml-0.3.0-1.fc31.src.rpm Description: SAML library for go Fedora Account System Username: agerstmayr
rawhide test build failed with missing BR: golang(github.com/dchest/uniuri)
ah, golang(github.com/dchest/uniuri) is up for rv too: https://bugzilla.redhat.com/show_bug.cgi?id=1800666
waiting on : BZ#1800666 - Review Request: golang-github-dchest-uniuri BZ#1800672 - Review Request: golang-github-russellhaering-goxmldsig BZ#1800663 - Review Request: golang-github-beevik-etree fedora-review not working even with -L pointing to a directory with the above RPMS pre-built. So I guess just wait for them to appear in the rawhide and f32 buildroots before trying again.
All packages are now in Rawhide and, except golang-github-russellhaering-goxmldsig, also in F32.
golang-github-russellhaering-goxmldsig is now also in F32.
Andreas, the mock build on rawhide seems to be failing in the %check phase; in identity_provider_test.go:1027 I dont know what's causing this. I also ran a straight rpmbuild --rebuild on the SRPM, with the same result. Here's some (truncated) details from the log : Executing(%check): /bin/sh -e /var/tmp/rpm-tmp.rZGqRP + umask 022 + cd /home/mgoodwin/rpmbuild/BUILD + cd saml-0.3.0 + LDFLAGS='-X github.com/crewjam/saml/version=0.3.0 -X github.com/crewjam/saml/version.tag=v0.3.0' + GO_TEST_FLAGS='-buildmode pie -compiler gc' + GO_TEST_EXT_LD_FLAGS='-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld ' + go-rpm-integration check -i github.com/crewjam/saml -b /home/mgoodwin/rpmbuild/BUILD/saml-0.3.0/_build/bin -s /home/mgoodwin/rpmbuild/BUILD/saml-0.3.0/_build -V 0.3.0-1.fc33 -T v0.3.0 -p /home/mgoodwin/rpmbuild/BUILDROOT/golang-github-crewjam-saml-0.3.0-1.fc33.x86_64 -g /usr/share/gocode -r '.*example.*' Testing in: /home/mgoodwin/rpmbuild/BUILD/saml-0.3.0/_build/src PATH: /home/mgoodwin/rpmbuild/BUILD/saml-0.3.0/_build/bin:/home/mgoodwin/.local/bin:/home/mgoodwin/bin:/usr/lib64/ccache:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin GOPATH: /home/mgoodwin/rpmbuild/BUILD/saml-0.3.0/_build:/usr/share/gocode GO111MODULE: off command: go test -buildmode pie -compiler gc -ldflags "-X github.com/crewjam/saml/version=0.3.0 -X github.com/crewjam/saml/version.tag=v0.3.0 -extldflags '-Wl,-z,relro -Wl,--as-needed -Wl,-z,now -specs=/usr/lib/rpm/redhat/redhat-hardened-ld '" testing: github.com/crewjam/saml github.com/crewjam/saml 2020/02/18 15:31:41 failed to parse request: cannot decompress request: flate: corrupt input before offset 8 2020/02/18 15:31:41 failed to parse request: cannot decode request: illegal base64 data at input byte 0 2020/02/18 15:31:41 failed to parse request: illegal base64 data at input byte 0 2020/02/18 15:31:41 cannot find service provider: https://wrong.url/metadata --- FAIL: TestIDPCanHandleUnencryptedResponse (0.00s) identity_provider_test.go:1027: Error Trace: identity_provider_test.go:1027 Error: Not equal: expected: [... TLDR ... snipped ...]
Aaah. Just tested it again - works - then updated the etree dependency to 1.1.0 (I had etree 1.0.1 when submitting this review request) - then it breaks. I'll investigate.
fyi: updated saml to 0.4.0 and packaged a new dependency, golang-github-crewjam-httperr. Then the build works. But crewjam/httperr doesn't have a license, therefore I've opened https://github.com/crewjam/httperr/issues/1 So.. this dependency is blocked yet again :|
OK, BZ#1804467 reviewed, all good. Just need the new SPEC and SRPM URLs for saml version 0.4.0. (https://github.com/andreasgerstmayr/specs/tree/master/reviews/golang-github-crewjam-saml still has the 0.3.0 version) Thanks
Thanks for the review(s)! I've updated the spec and SRPM: Spec URL: https://raw.githubusercontent.com/andreasgerstmayr/specs/master/reviews/golang-github-crewjam-saml/golang-github-crewjam-saml.spec SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/golang-github-crewjam-saml/golang-github-crewjam-saml-0.4.0-1.fc31.src.rpm
Looks good, package approved Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: There is no build directory. Running licensecheck on vanilla upstream sources. Licenses found: "Unknown or generated". 1 files have unknown license. Detailed output of licensecheck in /home/mgoodwin/src/fedora/reviews/1800675-golang-github-crewjam- saml/licensecheck.txt [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [-]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 4 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: golang-github-crewjam-saml-devel-0.4.0-1.fc31.noarch.rpm golang-github-crewjam-saml-0.4.0-1.fc31.src.rpm golang-github-crewjam-saml-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/crewjam/saml/.goipath golang-github-crewjam-saml.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Rpmlint (installed packages) ---------------------------- golang-github-crewjam-saml-devel.noarch: W: invalid-url URL: https://github.com/crewjam/saml <urlopen error [Errno -2] Name or service not known> golang-github-crewjam-saml-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/crewjam/saml/.goipath 1 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/crewjam/saml/archive/v0.4.0/saml-0.4.0.tar.gz : CHECKSUM(SHA256) this package : 9e3dec0a5728eb5f3f4853d3094a36d32236007eb3080934842dac5e221cedf4 CHECKSUM(SHA256) upstream package : 9e3dec0a5728eb5f3f4853d3094a36d32236007eb3080934842dac5e221cedf4 Requires -------- golang-github-crewjam-saml-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/beevik/etree) golang(github.com/crewjam/httperr) golang(github.com/dgrijalva/jwt-go) golang(github.com/russellhaering/goxmldsig) golang(github.com/russellhaering/goxmldsig/etreeutils) golang(github.com/zenazn/goji/web) golang(golang.org/x/crypto/bcrypt) golang(golang.org/x/crypto/ripemd160) Provides -------- golang-github-crewjam-saml-devel: golang(github.com/crewjam/saml) golang(github.com/crewjam/saml)(tag=v0.4.0) golang(github.com/crewjam/saml/logger) golang(github.com/crewjam/saml/logger)(tag=v0.4.0) golang(github.com/crewjam/saml/samlidp) golang(github.com/crewjam/saml/samlidp)(tag=v0.4.0) golang(github.com/crewjam/saml/samlsp) golang(github.com/crewjam/saml/samlsp)(tag=v0.4.0) golang(github.com/crewjam/saml/testsaml) golang(github.com/crewjam/saml/testsaml)(tag=v0.4.0) golang(github.com/crewjam/saml/xmlenc) golang(github.com/crewjam/saml/xmlenc)(tag=v0.4.0) golang-github-crewjam-saml-devel golang-ipath(github.com/crewjam/saml) golang-ipath(github.com/crewjam/saml)(tag=v0.4.0) Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -L /home/mgoodwin/src/fedora/reviews/RPMS -b 1800675 -m fedora-31-x86_64 Buildroot used: fedora-31-x86_64 Active plugins: Generic, Shell-api Disabled plugins: R, Java, Haskell, Perl, C/C++, Ocaml, SugarActivity, Python, PHP, fonts Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Built with local dependencies: /home/mgoodwin/src/fedora/reviews/RPMS/golang-github-dchest-uniuri-devel-0-0.1.20200213git8902c56.fc33.noarch.rpm /home/mgoodwin/src/fedora/reviews/RPMS/golang-github-beevik-etree-devel-1.1.0-1.fc32.noarch.rpm /home/mgoodwin/src/fedora/reviews/RPMS/golang-github-russellhaering-goxmldsig-devel-0-0.1.20200207git7acd5e4.fc32.noarch.rpm /home/mgoodwin/src/fedora/reviews/RPMS/golang-github-crewjam-httperr-devel-0.2.0-1.fc33.noarch.rpm
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-crewjam-saml