Spec URL: https://raw.githubusercontent.com/andreasgerstmayr/specs/master/reviews/golang-github-russellhaering-goxmldsig/golang-github-russellhaering-goxmldsig.spec SRPM URL: https://github.com/andreasgerstmayr/specs/raw/master/reviews/golang-github-russellhaering-goxmldsig/golang-github-russellhaering-goxmldsig-0-0.1.20200207git7acd5e4.fc31.src.rpm Description: Pure Go implementation of XML Digital Signatures Fedora Account System Username: agerstmayr
Looks good, approved! (subject to blocking BZ 1800663 being resolved first) Note in the review below, this new package has a BR on the new package golang-github-beevik-etree-devel (BZ 1800663). So that BZ needs to be resolved before this one (Depends On in this BZ is correctly set). In addition, new packagegolang-github-crewjam-saml-devel (BZ 1800675) is blocked by this BZ due to a BR. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. [x]: Package does not own files or directories owned by other packages. [-]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Spec file according to URL is the same as in SRPM. Installation errors ------------------- INFO: mock.py version 1.4.21 starting (python version = 3.7.6)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled dnf cache Start: cleaning dnf metadata Finish: cleaning dnf metadata INFO: enabled HW Info plugin Mock Version: 1.4.21 INFO: Mock Version: 1.4.21 Finish: chroot init INFO: installing package(s): /home/mgoodwin/src/fedora/reviews/1800672-golang-github-russellhaering-goxmldsig/results/golang-github-russellhaering-goxmldsig-devel-0-0.1.20200207git7acd5e4.fc31.noarch.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-31-x86_64/root/ --releasever 31 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/mgoodwin/src/fedora/reviews/1800672-golang-github-russellhaering-goxmldsig/results/golang-github-russellhaering-goxmldsig-devel-0-0.1.20200207git7acd5e4.fc31.noarch.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: golang-github-russellhaering-goxmldsig-devel-0-0.1.20200207git7acd5e4.fc31.noarch.rpm golang-github-russellhaering-goxmldsig-0-0.1.20200207git7acd5e4.fc31.src.rpm golang-github-russellhaering-goxmldsig-devel.noarch: W: hidden-file-or-dir /usr/share/gocode/src/github.com/russellhaering/goxmldsig/.goipath golang-github-russellhaering-goxmldsig.src: W: no-%build-section 2 packages and 0 specfiles checked; 0 errors, 2 warnings. Source checksums ---------------- https://github.com/russellhaering/goxmldsig/archive/7acd5e4a6ef74fe1b082c20f119556adf70c3944/goxmldsig-7acd5e4a6ef74fe1b082c20f119556adf70c3944.tar.gz : CHECKSUM(SHA256) this package : 6979bcdf050903cffbf373849e1ed18f100e3f5df529ca57b2adb924df066948 CHECKSUM(SHA256) upstream package : 6979bcdf050903cffbf373849e1ed18f100e3f5df529ca57b2adb924df066948 Requires -------- golang-github-russellhaering-goxmldsig-devel (rpmlib, GLIBC filtered): go-filesystem golang(github.com/beevik/etree) golang(github.com/jonboulle/clockwork) Provides -------- golang-github-russellhaering-goxmldsig-devel: golang(github.com/russellhaering/goxmldsig) golang(github.com/russellhaering/goxmldsig)(commit=7acd5e4a6ef74fe1b082c20f119556adf70c3944) golang(github.com/russellhaering/goxmldsig/etreeutils) golang(github.com/russellhaering/goxmldsig/etreeutils)(commit=7acd5e4a6ef74fe1b082c20f119556adf70c3944) golang(github.com/russellhaering/goxmldsig/types) golang(github.com/russellhaering/goxmldsig/types)(commit=7acd5e4a6ef74fe1b082c20f119556adf70c3944) golang-github-russellhaering-goxmldsig-devel golang-ipath(github.com/russellhaering/goxmldsig) golang-ipath(github.com/russellhaering/goxmldsig)(commit=7acd5e4a6ef74fe1b082c20f119556adf70c3944) Generated by fedora-review 0.7.4 (54fa030) last change: 2019-12-07 Command line :/usr/bin/fedora-review -b 1800672 -m fedora-31-x86_64 Buildroot used: fedora-31-x86_64 Active plugins: Shell-api, Generic Disabled plugins: Java, Perl, fonts, SugarActivity, PHP, C/C++, R, Python, Haskell, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-russellhaering-goxmldsig