Bug 1803196 - Logging operator should publish sharing-config configmap into openshift-config-managed namespace
Summary: Logging operator should publish sharing-config configmap into openshift-confi...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Logging
Version: 4.4
Hardware: Unspecified
OS: Unspecified
unspecified
high
Target Milestone: ---
: 4.5.0
Assignee: Periklis Tsirakidis
QA Contact: Anping Li
URL:
Whiteboard:
Depends On:
Blocks: 1806651
TreeView+ depends on / blocked
 
Reported: 2020-02-14 16:18 UTC by Jakub Hadvig
Modified: 2023-09-14 05:52 UTC (History)
7 users (show)

Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Cause: Console-Operator needs to reconcile Logging Link on Application Menu by using the ConsoleLink resource Consequence: No need to reconcile arbitrary config map Fix: The Elasticseearch-Operator reconciles two ConsoleLinks CRs for the Kibana route, one for non-admin users and one for admin users. In addition on upgrade from 4.4 to 4.5 the old config map will be deleted Result: The Console Operator is able to reconcile Application Menu Links for Logging by reading the ConsoleLinks custom resources.
Clone Of:
Environment:
Last Closed: 2020-07-13 17:15:32 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-logging-operator pull 374 0 None closed Bug 1803196: Move shared config map to openshift-config-managed NS 2020-11-17 13:23:32 UTC
Github openshift elasticsearch-operator pull 257 0 None closed Bug 1803196: Replace shared config map with console link CRs 2020-11-17 13:23:33 UTC
Github openshift elasticsearch-operator pull 300 0 None closed Bug 1803196: Replace shared config map with console link CRs 2020-11-17 13:23:33 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:15:58 UTC

Description Jakub Hadvig 2020-02-14 16:18:13 UTC
Description of problem:
Logging operator should publish sharing-config configmap into openshift-config-managed namespace, so it's reachable for other components, like console, which needs to access to:
 - kibanaAppURL
 - kibanaInfraURL
Version-Release number of selected component (if applicable):
4.4.

How reproducible:
Always


Steps to Reproduce:
1. 
2.
3.

Actual results:
Logging operator is publishing sharing-config configmap into openshift-logging namespace. If any component needs to get hands on the configmap it needs to get additional RBAC permissions.


Expected results:
Logging operator should be publishing sharing-config configmap into openshift-config-managed namespace so no additional RBAC permissions needs to be added to component that needs the configmap.

Comment 1 Jakub Hadvig 2020-02-17 10:15:38 UTC
For the new configmap name I would be in favour either for "logging" as suggested or maybe "logging-shared-config"

Comment 2 bpeterse 2020-02-19 19:21:29 UTC
logging-shared-config would be consistent with the monitoring-shared-config that was recently merged:
https://bugzilla.redhat.com/show_bug.cgi?id=1803192

Consistency is good.

Comment 6 Ben Parees 2020-02-28 18:03:12 UTC
the fix for the original request is being reverted due to:
https://bugzilla.redhat.com/show_bug.cgi?id=1807739

moving back to NEW.

Comment 7 bpeterse 2020-03-02 17:13:53 UTC
Since the logging operator is OLM and not CVO, the publishing of the config into `openshift-config-managed` isn't the correct approach.  Instead, we have a `ConsoleLink` CRD that fits this use case.  See:

- CRD https://github.com/openshift/api/blob/master/console/v1/0000_10_consolelink.crd.yaml
- API https://github.com/openshift/api/blob/master/console/v1/types_console_link.go

Locations options for the link at this point are (https://github.com/openshift/api/blob/master/console/v1/types_console_link.go#L20):

- ApplicationMenu (with additional config options)
- HelpMenu 
- UserMenu 
- NamespaceDashboard (with additional config options)

We would suggest using ApplicationMenu.  There is an optional Section if desired.

Comment 10 Anping Li 2020-05-15 14:39:29 UTC
What is the difference between kibana-app-public-url and kibana-infra-public-url ?

#oc get ConsoleLink kibana-app-public-url -o json |jq '.spec'
{
  "applicationMenu": {
    "section": "Monitoring"
  },
  "href": "https://kibana-openshift-logging.apps.anli45515.qe.devcluster.openshift.com",
  "location": "ApplicationMenu",
  "text": "Logging"
}
#oc get ConsoleLink kibana-infra-public-url -o json |jq '.spec'
{
  "applicationMenu": {
    "section": "Monitoring"
  },
  "href": "https://kibana-openshift-logging.apps.anli45515.qe.devcluster.openshift.com",
  "location": "ApplicationMenu",
  "text": "Logging"
}

Comment 11 Anping Li 2020-05-18 10:18:04 UTC
@yapei Could you help me confirm if the Logging works on Console?  The user can be directed from pod->logs to kibana. Is there any other link can be directed to kibana? For example: Monioring->xxx.

Comment 12 Periklis Tsirakidis 2020-05-22 07:32:25 UTC
@anping & yapei

I will put this on needsinfo until yapei provides the info. AFAIK there should be a link for Logging on the Application Menu Monitoring -> Logging that opens Kibana.

Comment 13 Anping Li 2020-05-25 02:16:06 UTC
The Application Menu Monitoring -> Logging disappeared.  If I add the configmap/sharing-config manually, the menu appears.   Shall the console use consoleexternalloglinks.console.openshift.io?

Comment 14 Yadan Pei 2020-05-25 08:01:16 UTC
If cluster logging is deployed successfully and clusterlogging/instance is running(kibana route is created) then admin user can see Monitoring -> Logging menu

Comment 15 Periklis Tsirakidis 2020-05-26 11:46:42 UTC
@Anping Li & @Yadan Pei

You should not use the configmap any more to get the application menu link for "Logging". If this is the case then this is not a bug in elasticsearch-operator but probably a bug on the console-operator side. Can you please re-check this? Elasticsearch-operator is not responsible for the UI but simply for creating the ConsoleLink CRs for the application menu. ConsoleExternalLinks are used only for the pod detail view.

Comment 16 Anping Li 2020-05-27 02:43:43 UTC
Agree. Move to verify and Filed a console bug https://bugzilla.redhat.com/show_bug.cgi?id=1840478

Comment 18 errata-xmlrpc 2020-07-13 17:15:32 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409

Comment 19 Red Hat Bugzilla 2023-09-14 05:52:35 UTC
The needinfo request[s] on this closed bug have been removed as they have been unresolved for 1000 days


Note You need to log in before you can comment on or make changes to this bug.