Bug 1803309 - Review Request: golang-github-netflix-expect - An expect-like golang library to automate control of terminal or console based programs
Summary: Review Request: golang-github-netflix-expect - An expect-like golang library ...
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Jared Smith
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1803302
TreeView+ depends on / blocked
 
Reported: 2020-02-15 05:36 UTC by Joe Doss
Modified: 2020-11-06 14:17 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-06 14:17:25 UTC
Type: ---
Embargoed:
jsmith.fedora: fedora-review+


Attachments (Terms of Use)

Comment 1 Robert-André Mauchin 🐧 2020-02-16 22:34:42 UTC
 - Use a shorter Summary:

golang-github-netflix-expect-devel.noarch: E: summary-too-long C An expect-like golang library to automate control of terminal or console based programs

 - License ok
 - Latest version packaged
 - Builds in mock
 - Tests are ok
 - Conforms to Packaging Guidelines

Package approved. Please fix the aformentioned issue before import.

Comment 3 Jared Smith 2020-04-14 16:28:35 UTC
Are you going to actually build this package, now that it has been approved?  If not, I'd be willing to take over the process and help get this into Fedora.

Comment 4 Joe Doss 2020-04-14 18:51:07 UTC
Feel free to take it over Jared. Thanks!

Comment 6 Petr Pisar 2020-10-23 11:56:29 UTC
If there is a need for a rereview, then open a new review request and close this as wont-fix. Otherwise take the approved package, add into Fedora, and then perform a normal update to the new version.

Comment 7 Joe Doss 2020-10-27 15:38:26 UTC
Hey Petr,

$ fedpkg request-repo golang-github-netflix-expect 1803309                   
Could not execute request_repo: The Bugzilla bug's review was approved over 60 days ago


Should I open new request or can you re-approve it?

Comment 8 Petr Pisar 2020-10-29 07:36:33 UTC
I forgot there is a limit for the review age. Either open a new request, or reset this one the original state (NEW state, default assignee, unset fedora-review flag). Whatever suits you better.

I cannot understand Go, thus I'm not going to re-approve this review.

Comment 9 Jared Smith 2020-10-30 19:33:22 UTC
I'll re-review this.

Comment 10 Jared Smith 2020-10-30 19:33:49 UTC
Package is APPROVED.

Comment 11 Gwyn Ciesla 2020-11-03 15:45:40 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/golang-github-netflix-expect


Note You need to log in before you can comment on or make changes to this bug.