Hey Milind, what is this ticket tracking? this seems a dup of https://bugzilla.redhat.com/show_bug.cgi?id=1798596 which is verified?
I see this is for OSP, I prepend it in the title [OSP]. Thanks.
It seems to me that this bug doesn't apply to Cluster API Provider OpenStack. We already take into consideration all of machines states when deleting an instance: https://github.com/openshift/cluster-api-provider-openstack/blob/009ac60/pkg/cloud/openstack/machine/actuator.go#L308-L316
I might have been a bit to quick to close the BZ. It appears that we're listing the machine interfaces first when deleting a machine and that _might_ cause it to return an error if the machine is not in running status. We'll have to double check. Did you actually observe leaking instances on OpenStack, or was it created as a clone of the AWS bug assuming it worked the same?
@Martin Checked on openstack
lgtm verified
Since the problem described in this bug report should be resolved in a recent advisory, it has been closed with a resolution of ERRATA. For information on the advisory (OpenShift Container Platform 4.5 image release advisory), and where to find the updated files, follow the link below. If the solution does not work for you, open a new bug report. https://access.redhat.com/errata/RHBA-2020:2409