Bug 1813741 - [ovirt] allow template parameters customization (mem/cpu/disk) in the machine
Summary: [ovirt] allow template parameters customization (mem/cpu/disk) in the machine
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Cloud Compute
Version: 4.4
Hardware: Unspecified
OS: Unspecified
high
high
Target Milestone: ---
: 4.5.0
Assignee: Roy Golan
QA Contact: Jan Zmeskal
URL:
Whiteboard:
Depends On:
Blocks: 1820300 1830001 1835576
TreeView+ depends on / blocked
 
Reported: 2020-03-16 00:08 UTC by Roy Golan
Modified: 2020-11-05 06:57 UTC (History)
4 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
: 1830001 1835576 (view as bug list)
Environment:
Last Closed: 2020-07-13 17:20:18 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift cluster-api-provider-ovirt pull 41 0 None closed Bug 1813741: [ovirt] allow template parameters customization (mem/cpu/disk) in the machine 2020-11-05 06:56:48 UTC
Red Hat Product Errata RHBA-2020:2409 0 None None None 2020-07-13 17:20:41 UTC

Description Roy Golan 2020-03-16 00:08:37 UTC
Description of problem:

The masters/workers instance parametes should be customized using the machine pool. Today all of the parameters are set on the initial template creation, and can only be overriden by export TF_VAR_xyz, which is a bad way of exposing this capability. 

Expected results:

oVirt's machinepool object should have mem/cpu/disk size parameters, and they 
should be used to create the instances, if they are set.

Comment 1 Jan Zmeskal 2020-03-16 14:53:48 UTC
Roy, is that even desirable capability for IPI? I don't know how other platforms handle this, but as far as I understand, the point of IPI isn't really to be customizable.

Comment 2 Roy Golan 2020-03-18 13:17:34 UTC
Other platforms allow that degree of customization. It's a reasonable balance because not all clusters have the same needs, and 
not all ovirt/rhv clusters have the same capabilities.

Comment 5 Jan Zmeskal 2020-04-30 14:18:07 UTC
Hi Roy, could you please comment about how users can consume this functionality? I tried deploying OCP4.5 cluster (using the latest nightly) with this specified in install-config.yaml:

controlPlane:
  architecture: amd64
  hyperthreading: Enabled
  name: master
  platform:
    ovirt:
      memory_mb: 12
  replicas: 3

However, the created master VMs still had only 8GB of memory. Could you please attach some detailed info on the usage?

Comment 6 Roy Golan 2020-05-04 06:59:50 UTC
this is bug is only the cluster api provider component. To complete this should be in as well Bug 1820300

Comment 7 Jan Zmeskal 2020-05-12 07:00:55 UTC
I cannot really verify that until https://bugzilla.redhat.com/show_bug.cgi?id=1820300 is merged.

Comment 8 Jan Zmeskal 2020-05-14 09:21:21 UTC
Roy, I suppose this is pretty much verified by verifying https://bugzilla.redhat.com/show_bug.cgi?id=1820300, right?

Comment 9 Michal Skrivanek 2020-05-14 13:24:56 UTC
yes. once you verify it.

Comment 10 Jan Zmeskal 2020-05-14 13:28:49 UTC
Thank you for clarification, Michal :)

Chat response from Roy:
the answer is yes for the question
you can use it without the istaller
you can edit the machineset object
oc edit machineset <name of the worker pool set>

Comment 11 Roy Golan 2020-05-15 18:24:11 UTC
(In reply to Jan Zmeskal from comment #8)
> Roy, I suppose this is pretty much verified by verifying
> https://bugzilla.redhat.com/show_bug.cgi?id=1820300, right?

Actually we must verify this first, to unblock its cherry pick to 4.4 [1]
once [1] is merged I will be able to complete the 4.4 cherry-pick to the installer. The installer
is dependent on the cluster-api-provider-ovirt repository.

Comment 12 Jan Zmeskal 2020-05-19 07:26:08 UTC
Verified this alongside 1820300, see here: https://bugzilla.redhat.com/show_bug.cgi?id=1820300#c9

Comment 14 errata-xmlrpc 2020-07-13 17:20:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2409


Note You need to log in before you can comment on or make changes to this bug.