Bug 1815852 - python-pytest-httpbin: provide epel8 update
Summary: python-pytest-httpbin: provide epel8 update
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora EPEL
Classification: Fedora
Component: python-pytest-httpbin
Version: epel8
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Adam Williamson
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1815700
TreeView+ depends on / blocked
 
Reported: 2020-03-22 04:29 UTC by clime7
Modified: 2022-09-24 02:10 UTC (History)
2 users (show)

Fixed In Version: python-pytest-httpbin-1.0.2-1.el8
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2022-09-24 02:10:47 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)

Description clime7 2020-03-22 04:29:03 UTC
Description of problem:

Hello again, can you please provide epel-8 update?

I need it for https://bugzilla.redhat.com/show_bug.cgi?id=1815695

Thank you
clime

Comment 1 Carl George 🤠 2020-04-08 06:09:27 UTC
@Adam, if you add the python-sig group to this package I'd be happy to take care of this request.

Comment 2 Adam Williamson 2020-04-08 16:07:36 UTC
oh, sorry, I missed this one. I'll do it, but I will add python-sig as comaintainer also.

Comment 3 Adam Williamson 2020-04-08 16:26:42 UTC
I do not see a group called python-sig in dist-git? Trying to enter it in the box at https://src.fedoraproject.org/rpms/python-pytest-httpbin/adduser but it's just not there. I see java-sig and perl-sig but no python-sig.

Comment 4 Adam Williamson 2020-04-08 17:43:47 UTC
OK, so this isn't going to be easy, there's a whole dep forest here. pytest-httpbin is just a pytest wrapper for httpbin itself, which doesn't have an epel8 build. I own that package, so I could do that one, but...httpbin requires a ton of other stuff:

python3-blinker python3-brotli python3-flask python3-markupsafe python3-decorator python3-itsdangerous python3-raven python3-six python3-werkzeug

which isn't all in epel8 either. From a quick scratch build attempt:

https://koji.fedoraproject.org/koji/taskinfo?taskID=43132980

it seems like brotli and raven are missing. brotli may be a problem. In Fedora, python3-brotli is built out of the 'brotli' source package; it seems like RHEL 8 has its own brotli source package but only ships the 'brotli' binary package from it, it either doesn't build or doesn't ship the python libs.

werkzeug could also be an issue: RHEL has python3-werkzeug-0.12.2-4.el8. httpbin 0.7.0 actually requires 0.14.1 or higher, since:

https://github.com/postmanlabs/httpbin/commit/75c83178c10c18cd4cf5ebde1a0d0b8b06a79000

Comment 5 Carl George 🤠 2020-04-08 21:33:31 UTC
Yeah I got here (python-pytest-httpbin) through a dependency of a dependency, so I can relate.  I guess pop new bugs for the ones you find, block this one on them, and people (including myself) will get to them as they get to them.  There was a recent fedscm-admin fix that allows group commit to request branches, so any of those with the python-sig I can help with as time allows.

Comment 6 Adam Williamson 2020-04-08 22:04:06 UTC
out of interest, what's the dependency of the dependency? I packaged this more or less entirely so we could enable the test suite for python-requests during the package build, that was the only thing that used it that I'm aware of.

Comment 7 Carl George 🤠 2020-04-08 22:41:19 UTC
Sorry, I was confusing this with another epel8 request I was working on.  This one is just one level, I need it to build python-vcrpy.  I already have bug 1815857 marked as blocked by this one.

Comment 8 clime7 2020-04-11 18:09:57 UTC
(In reply to Adam Williamson from comment #4)
> OK, so this isn't going to be easy, there's a whole dep forest here.
> pytest-httpbin is just a pytest wrapper for httpbin itself, which doesn't
> have an epel8 build. I own that package, so I could do that one,
> but...httpbin requires a ton of other stuff:
> 
> python3-blinker python3-brotli python3-flask python3-markupsafe
> python3-decorator python3-itsdangerous python3-raven python3-six
> python3-werkzeug
> 
> which isn't all in epel8 either. From a quick scratch build attempt:
> 
> https://koji.fedoraproject.org/koji/taskinfo?taskID=43132980
> 
> it seems like brotli and raven are missing. brotli may be a problem. In
> Fedora, python3-brotli is built out of the 'brotli' source package; it seems
> like RHEL 8 has its own brotli source package but only ships the 'brotli'
> binary package from it, it either doesn't build or doesn't ship the python
> libs.
> 
> werkzeug could also be an issue: RHEL has python3-werkzeug-0.12.2-4.el8.
> httpbin 0.7.0 actually requires 0.14.1 or higher, since:
> 
> https://github.com/postmanlabs/httpbin/commit/
> 75c83178c10c18cd4cf5ebde1a0d0b8b06a79000

I have hit that problem when trying to build fedmsg: https://copr.fedorainfracloud.org/coprs/clime/python3-fedmsg-epel8/packages/

I think I simply patched python-httpbin to omit that requires. 
I looked into httpbin code, when the requires was added and I got an impression the >= 0.14.1 condition isn't a functional requirement
(or maybe that it would require a little work to make it work with older werkzeug to).

It was this commit https://github.com/postmanlabs/httpbin/commit/75c83178c10c18cd4cf5ebde1a0d0b8b06a79000

Comment 9 Adam Williamson 2020-04-11 18:54:29 UTC
Yeah, no, I know the change too. It's not functional, but it's a test suite change, and we do want the test suite to run and pass.

Comment 10 clime7 2020-04-16 01:28:32 UTC
I can try to do rebuild in my copr with tests enabled and see if they fail or not with the older werkzeug...

Comment 11 clime7 2020-04-16 02:14:43 UTC
So it builds with tests enabled as well: https://download.copr.fedorainfracloud.org/results/clime/python3-fedmsg-epel8/epel-8-x86_64/01339368-python-httpbin/builder-live.log.gz (i hope it is a correct package).

Comment 12 clime7 2020-05-10 18:45:30 UTC
Hello, could we get this possibly working in epel8? I think just changing the condition by patch to not require wekzeug >= 0.14.1 is enough. Possibly some communication with upstream about this would be good. Adam, can we move this forward? What do you think?

Comment 13 clime7 2020-05-17 12:29:43 UTC
@Adam Williamson should I try to communicate it with upstream to change the condition to 0.12? Thanks

Comment 14 Adam Williamson 2020-05-19 19:03:32 UTC
@clime there are several other things missing, not just the werkzeug problem, see my comment earlier. Just resolving the werkzeug issue would be useful but still wouldn't be enough, unless those other ones have been resolved.

Comment 15 clime7 2020-07-21 14:06:29 UTC
(In reply to Adam Williamson from comment #14)
> @clime there are several other things missing, not just the werkzeug
> problem, see my comment earlier. Just resolving the werkzeug issue would be
> useful but still wouldn't be enough, unless those other ones have been
> resolved.

Sry but what is missing? I.e. what's the blocker? I can take a look at it.

Comment 16 Adam Williamson 2020-07-22 17:22:08 UTC
the stuff from comment #4. if all that's been resolved we can try this again.

Comment 17 Ben Cotton 2020-08-11 13:14:50 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 33 development cycle.
Changing version to 33.

Comment 18 Ben Cotton 2021-11-04 17:40:20 UTC
This message is a reminder that Fedora 33 is nearing its end of life.
Fedora will stop maintaining and issuing updates for Fedora 33 on 2021-11-30.
It is Fedora's policy to close all bug reports from releases that are no longer
maintained. At that time this bug will be closed as EOL if it remains open with a
Fedora 'version' of '33'.

Package Maintainer: If you wish for this bug to remain open because you
plan to fix it in a currently maintained version, simply change the 'version' 
to a later Fedora version.

Thank you for reporting this issue and we are sorry that we were not 
able to fix it before Fedora 33 is end of life. If you would still like 
to see this bug fixed and are able to reproduce it against a later version 
of Fedora, you are encouraged  change the 'version' to a later Fedora 
version prior this bug is closed as described in the policy above.

Although we aim to fix as many bugs as possible during every release's 
lifetime, sometimes those efforts are overtaken by events. Often a 
more recent Fedora release includes newer upstream software that fixes 
bugs or makes them obsolete.

Comment 19 Adam Williamson 2021-11-05 23:50:25 UTC
moving to EPEL, since that's what this is about. I don't really have time to look at it rn, though.

Comment 20 Fedora Update System 2022-09-15 21:55:28 UTC
FEDORA-EPEL-2022-6d7af3cd46 has been submitted as an update to Fedora EPEL 8. https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-6d7af3cd46

Comment 21 Fedora Update System 2022-09-16 03:01:42 UTC
FEDORA-EPEL-2022-6d7af3cd46 has been pushed to the Fedora EPEL 8 testing repository.

You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-EPEL-2022-6d7af3cd46

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 22 Fedora Update System 2022-09-24 02:10:47 UTC
FEDORA-EPEL-2022-6d7af3cd46 has been pushed to the Fedora EPEL 8 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.