Bug 1820794 - [OSP16] Backport Datera v2.2 cinder driver
Summary: [OSP16] Backport Datera v2.2 cinder driver
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat OpenStack
Classification: Red Hat
Component: openstack-cinder
Version: 16.0 (Train)
Hardware: Unspecified
OS: Unspecified
high
medium
Target Milestone: z3
: 16.0 (Train on RHEL 8.1)
Assignee: Alan Bishop
QA Contact: Tzach Shefi
Chuck Copello
URL:
Whiteboard:
Depends On: 1822304
Blocks: 1823416
TreeView+ depends on / blocked
 
Reported: 2020-04-03 22:07 UTC by Alan Bishop
Modified: 2020-05-14 12:11 UTC (History)
5 users (show)

Fixed In Version: openstack-cinder-15.1.1-0.20200403213515.cfa2d1b.el8ost
Doc Type: No Doc Update
Doc Text:
Clone Of:
: 1822304 1823416 (view as bug list)
Environment:
Last Closed: 2020-05-14 12:11:11 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
OpenStack gerrit 704153 0 None MERGED Update in-tree Datera Cinder driver 2020-07-29 03:35:59 UTC
Red Hat Product Errata RHBA-2020:2161 0 None None None 2020-05-14 12:11:24 UTC

Description Alan Bishop 2020-04-03 22:07:13 UTC
Datera updated their cinder driver to v2.2 on Ussuri, and the updated driver is required on OSP releases based on Train and earlier. The nature of the patch makes it unsuitable for upstream backports to stable releases, and so the backport must be handled downstream.

The Ussuri patch is https://review.opendev.org/704153.

Comment 1 Virgil Mihailovici 2020-04-05 20:52:19 UTC
I backported the driver to Train here:
https://github.com/Datera/cinder/tree/datera_train_backport

In particular, this commit contains all the changes required:
https://github.com/Datera/cinder/commit/9d71729fb8571384cf7e69b06b5ce53812651d6f

The patch passes out automation, it passes tempest tests and tox tests, the same as the original patch in Ussuri:
https://review.opendev.org/#/c/704153/

I followed the steps outlined by Allen here:
1. Datera forks the entire cinder project on github to another repo in their own namespace (e.g. https://github.com/Datera/cinder)

2. Create a branch off stable/train, and cherry pick the driver patch from master

% git clone https://github.com/Datera/cinder
% git checkout -b train/datera-v2.2 origin/stable/train
% git cherry-pick -x 6aabf4669204cb28d0ededfd3a6efba1fdd06293

Resolve the conflicts, confirm all unit tests and pep8 pass, perform any additional tests deemed appropriate.

Commit the final working patch, with the commit message including the list of files in the "Conflicts:" section of the commit message.

3. Push the patch to https://github.com/Datera/cinder, and add a comment in the BZ so that Red Hat can find the patch.

From there, Red Hat will pull the patch into our downstream source repository. Once that is complete, the openstack-cinder RPM containing the new Datera driver will make its way into a subsequent OSP-16.0 zStream release. After the RPM is released, Datera will be able to rebuild their cinder-volume plugin, in order to supply the dfs_sdk python module (an external out-of-tree dependency).

Comment 2 Virgil Mihailovici 2020-04-05 20:54:06 UTC
Sorry, I misspelled Alan's name and I don't see a way to edit my comment.

Comment 3 Virgil Mihailovici 2020-04-06 15:35:51 UTC
Updated the commit with proper formatting.
The branch is the same: https://github.com/Datera/cinder/tree/datera_train_backport
The specific commit is: https://github.com/Datera/cinder/commit/5a7e93bbe580393c7eedfa1bb751cec4948f5bec

Comment 6 Alan Bishop 2020-04-08 20:30:47 UTC
I attached the signed RPMs to the customer portal case, https://access.redhat.com/support/cases/02583058

Comment 11 errata-xmlrpc 2020-05-14 12:11:11 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:2161


Note You need to log in before you can comment on or make changes to this bug.