Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1822304

Summary:	[OSP16.1] Backport Datera v2.2 cinder driver
Product:	Red Hat OpenStack	Reporter:	Alan Bishop <abishop>
Component:	openstack-cinder	Assignee:	Alan Bishop <abishop>
Status:	CLOSED ERRATA	QA Contact:	Tzach Shefi <tshefi>
Severity:	medium	Docs Contact:	Chuck Copello <ccopello>
Priority:	medium
Version:	16.0 (Train)	CC:	astillma, gcharot, jschluet, kzona, nms, tshefi, virgil.mihailovici
Target Milestone:	beta	Keywords:	OtherQA, Triaged
Target Release:	16.1 (Train on RHEL 8.2)
Hardware:	Unspecified
OS:	Unspecified
Whiteboard:
Fixed In Version:	openstack-cinder-15.1.1-0.20200514003429.ac6e0c4.el8ost	Doc Type:	No Doc Update
Doc Text:		Story Points:	---
Clone Of:	1820794	Environment:
Last Closed:	2020-07-29 07:51:29 UTC	Type:	---
Regression:	---	Mount Type:	---
Documentation:	---	CRM:
Verified Versions:		Category:	---
oVirt Team:	---	RHEL 7.3 requirements from Atomic Host:
Cloudforms Team:	---	Target Upstream Version:
Embargoed:
Bug Depends On:
Bug Blocks:	1820794, 1823416

Description Alan Bishop 2020-04-08 17:03:25 UTC

+++ This bug was initially created as a clone of Bug #1820794 +++

Datera updated their cinder driver to v2.2 on Ussuri, and the updated driver is required on OSP releases based on Train and earlier. The nature of the patch makes it unsuitable for upstream backports to stable releases, and so the backport must be handled downstream.

The Ussuri patch is https://review.opendev.org/704153.

--- Additional comment from Virgil Mihailovici on 2020-04-05 20:52:19 UTC ---

I backported the driver to Train here:
https://github.com/Datera/cinder/tree/datera_train_backport

In particular, this commit contains all the changes required:
https://github.com/Datera/cinder/commit/9d71729fb8571384cf7e69b06b5ce53812651d6f

The patch passes out automation, it passes tempest tests and tox tests, the same as the original patch in Ussuri:
https://review.opendev.org/#/c/704153/

I followed the steps outlined by Allen here:
1. Datera forks the entire cinder project on github to another repo in their own namespace (e.g. https://github.com/Datera/cinder)

2. Create a branch off stable/train, and cherry pick the driver patch from master

% git clone https://github.com/Datera/cinder
% git checkout -b train/datera-v2.2 origin/stable/train
% git cherry-pick -x 6aabf4669204cb28d0ededfd3a6efba1fdd06293

Resolve the conflicts, confirm all unit tests and pep8 pass, perform any additional tests deemed appropriate.

Commit the final working patch, with the commit message including the list of files in the "Conflicts:" section of the commit message.

3. Push the patch to https://github.com/Datera/cinder, and add a comment in the BZ so that Red Hat can find the patch.

From there, Red Hat will pull the patch into our downstream source repository. Once that is complete, the openstack-cinder RPM containing the new Datera driver will make its way into a subsequent OSP-16.0 zStream release. After the RPM is released, Datera will be able to rebuild their cinder-volume plugin, in order to supply the dfs_sdk python module (an external out-of-tree dependency).

--- Additional comment from Virgil Mihailovici on 2020-04-05 20:54:06 UTC ---

Sorry, I misspelled Alan's name and I don't see a way to edit my comment.

--- Additional comment from Virgil Mihailovici on 2020-04-06 15:35:51 UTC ---

Updated the commit with proper formatting.
The branch is the same: https://github.com/Datera/cinder/tree/datera_train_backport
The specific commit is: https://github.com/Datera/cinder/commit/5a7e93bbe580393c7eedfa1bb751cec4948f5bec

Comment 10 errata-xmlrpc 2020-07-29 07:51:29 UTC

Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory, and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2020:3148