Spec URL: https://jjames.fedorapeople.org/ocaml-ppxlib/ocaml-ppxlib.spec SRPM URL: https://jjames.fedorapeople.org/ocaml-ppxlib/ocaml-ppxlib-0.13.0-1.fc33.src.rpm Fedora Account System Username: jjames Description: The ppxlib project provides the basis for the ppx system, which is currently the officially supported method for meta-programming in Ocaml. It offers a principled way to generate code at compile time in OCaml projects. It features: - an OCaml AST / parser/ pretty-printer snapshot, to create a full frontend independent of the version of OCaml; - a library for ppx rewriters in general, and type-driven code generators in particular; - a full-featured driver for OCaml AST transformers; - a quotation mechanism for writing values representing OCaml AST in the OCaml syntax; - a generator of open recursion classes from type definitions.
Jerry, I believe this was doesn't have an assignee. Would you like to swap it for this review? It's probably quite a simple one: https://bugzilla.redhat.com/show_bug.cgi?id=1834964
Sure, I'll swap.
Manual inspection of the spec file shows that it looks sensible. Literally the only thing I could nitpick is that it would be nice to know if the two patches are upstream/going upstream/never upstream.
Sorry for the delay - it's taking over an hour to run fedora-review for some reason ...
Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. rjones: f-r says the package doesn't install, but I was able to install it just fine locally so I think we can ignore this. - If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. Note: No gcc, gcc-c++ or clang found in BuildRequires See: https://docs.fedoraproject.org/en-US/packaging-guidelines/C_and_C++/ rjones: There are no apparently C or C++ files in the sources, so I guess we can ignore this. ===== MUST items ===== C/C++: [ ]: Package does not contain kernel modules. [ ]: Package contains no static executables. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. rjones: This section is wrong because f-r decided for some reason that this is a C/C++ package. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. rjones: Yes, I built it by hand on x86-64. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. rjones: licensecheck is all over the place here, but most files lack any license information in the file. It seems as if upstream intend this to be some kind of MIT license. It would be good to encourage upstream to add a license to every file. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 143 files have unknown license. Detailed output of licensecheck in /var/tmp/rr/review-ocaml- ppxlib/licensecheck.txt rjones: licensecheck is wrong here. I manually checked the license and it is correct. [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. rjones: OCaml package, so yes. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. rjones: I was able to install it, and it seems to place everything in its own subdirectory. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. rjones: Requires are generated. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 3 files. [x]: Package complies to the Packaging Guidelines [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Ocaml: [x]: This should never happen rjones: ? ===== SHOULD items ===== Generic: [-]: Reviewer should test that the package builds in mock. rjones: I built it using rpmbuild. It doesn't build in _my_ mock but it seems to be because my local mock is broken in some way. [x]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [-]: Package functions as described. rjones: Did not test, but it's required for other ocaml-* packages so we should be fine. [x]: Latest version is packaged. rjones: Yes, latest is 0.13.0. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. rjones: I couldn't find signed sources. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [-]: Package should compile and build into binary rpms on all supported architectures. rjones: Did not test, but no reason to think it wouldn't. [-]: %check is present and all tests pass. rjones: %check is present, but the tests don't pass. However there is justification for this in the spec file. [?]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [ ]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint (See my comments below) [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: ocaml-ppxlib-0.13.0-1.fc32.x86_64.rpm ocaml-ppxlib-devel-0.13.0-1.fc32.x86_64.rpm ocaml-ppxlib-doc-0.13.0-1.fc32.noarch.rpm ocaml-ppxlib-debuginfo-0.13.0-1.fc32.x86_64.rpm ocaml-ppxlib-debugsource-0.13.0-1.fc32.x86_64.rpm ocaml-ppxlib-0.13.0-1.fc33.src.rpm ocaml-ppxlib.x86_64: W: spelling-error Summary(en_US) ppx -> pox, pp, pix ocaml-ppxlib.x86_64: W: spelling-error Summary(en_US) rewriters -> rewrites, rewrite's, re writers ocaml-ppxlib.x86_64: W: spelling-error %description -l en_US ppx -> pox, pp, pix ocaml-ppxlib.x86_64: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end ocaml-ppxlib.x86_64: W: spelling-error %description -l en_US rewriters -> rewrites, rewrite's, re writers rjones: These are fine. ocaml-ppxlib-devel.x86_64: W: no-documentation rjones: Separate -doc subpackage, so it's fine. ocaml-ppxlib.src: W: spelling-error Summary(en_US) ppx -> pox, pp, pix ocaml-ppxlib.src: W: spelling-error Summary(en_US) rewriters -> rewrites, rewrite's, re writers ocaml-ppxlib.src: W: spelling-error %description -l en_US ppx -> pox, pp, pix ocaml-ppxlib.src: W: spelling-error %description -l en_US frontend -> fronted, front end, front-end ocaml-ppxlib.src: W: spelling-error %description -l en_US rewriters -> rewrites, rewrite's, re writers 6 packages and 0 specfiles checked; 0 errors, 11 warnings. rjones: These are fine. Source checksums ---------------- https://github.com/ocaml-ppx/ppxlib/archive/0.13.0/ppxlib-0.13.0.tar.gz : CHECKSUM(SHA256) this package : 59fd9eaac23e6fd1c5b6183c37499ec3dbabee1f6c7ede4fb080e5f9b746f4e0 CHECKSUM(SHA256) upstream package : 59fd9eaac23e6fd1c5b6183c37499ec3dbabee1f6c7ede4fb080e5f9b746f4e0 Requires -------- ocaml-ppxlib (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) libm.so.6()(64bit) ocaml(Ast_mapper) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Buffer) ocaml(Base__Buffer_intf) ocaml(Base__Bytes) ocaml(Base__Bytes_set_primitives) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Either) ocaml(Base__Either_intf) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Fn) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Hash_set) ocaml(Base__Hash_set_intf) ocaml(Base__Hashable) ocaml(Base__Hashable_intf) ocaml(Base__Hasher) ocaml(Base__Hashtbl) ocaml(Base__Hashtbl_intf) ocaml(Base__Identifiable) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Map) ocaml(Base__Map_intf) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Ppx_sexp_conv_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Set) ocaml(Base__Set_intf) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sexplib) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__Validate) ocaml(Base__With_return) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalMenhirLib) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Cmi_format) ocaml(Compmisc) ocaml(Config) ocaml(Docstrings) ocaml(Env) ocaml(Ident) ocaml(Identifiable) ocaml(Lexer) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Migrate_parsetree) ocaml(Migrate_parsetree__) ocaml(Migrate_parsetree__Ast_402) ocaml(Migrate_parsetree__Ast_403) ocaml(Migrate_parsetree__Ast_404) ocaml(Migrate_parsetree__Ast_405) ocaml(Migrate_parsetree__Ast_406) ocaml(Migrate_parsetree__Ast_407) ocaml(Migrate_parsetree__Ast_408) ocaml(Migrate_parsetree__Ast_408_helper) ocaml(Migrate_parsetree__Ast_409) ocaml(Migrate_parsetree__Ast_409_helper) ocaml(Migrate_parsetree__Ast_410) ocaml(Migrate_parsetree__Ast_411) ocaml(Migrate_parsetree__Locations) ocaml(Migrate_parsetree__Migrate_parsetree_ast_io) ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions) ocaml(Migrate_parsetree__Migrate_parsetree_driver) ocaml(Migrate_parsetree__Migrate_parsetree_versions) ocaml(Migrate_parsetree__Option) ocaml(Migrate_parsetree__Stdlib0) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parse) ocaml(Parser) ocaml(Parsetree) ocaml(Path) ocaml(Ppx_derivers) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Caller_id) ocaml(Ppxlib__Code_matcher) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Compiler_specifics) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__File_path) ocaml(Ppxlib__Ignore_unused_warning) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Location_check) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Merlin_helpers) ocaml(Ppxlib__Name) ocaml(Ppxlib__Options) ocaml(Ppxlib__Reconcile) ocaml(Ppxlib__Spellcheck) ocaml(Ppxlib__Utils) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_ast__Misc_helper) ocaml(Ppxlib_ast__Pprintast) ocaml(Ppxlib_ast__Warn) ocaml(Ppxlib_metaquot_lifters) ocaml(Ppxlib_print_diff) ocaml(Ppxlib_runner) ocaml(Ppxlib_runner_as_ppx) ocaml(Ppxlib_traverse_builtins) ocaml(Primitive) ocaml(Profile) ocaml(Result) ocaml(Sexplib0) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Shadow_stdlib) ocaml(Stdio) ocaml(Stdio__) ocaml(Stdio__Import) ocaml(Stdio__In_channel) ocaml(Stdio__Out_channel) ocaml(Stdlib) ocaml(Stdlib__arg) ocaml(Stdlib__array) ocaml(Stdlib__buffer) ocaml(Stdlib__digest) ocaml(Stdlib__filename) ocaml(Stdlib__format) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__int64) ocaml(Stdlib__lazy) ocaml(Stdlib__lexing) ocaml(Stdlib__list) ocaml(Stdlib__listLabels) ocaml(Stdlib__map) ocaml(Stdlib__moreLabels) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__parsing) ocaml(Stdlib__pervasives) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__seq) ocaml(Stdlib__set) ocaml(Stdlib__stdLabels) ocaml(Stdlib__string) ocaml(Stdlib__stringLabels) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Subst) ocaml(Syntaxerr) ocaml(Type_immediacy) ocaml(Types) ocaml(Warnings) ocamlx(Ast_mapper) ocamlx(CamlinternalLazy) ocamlx(CamlinternalOO) ocamlx(Clflags) ocamlx(Compmisc) ocamlx(Lexer) ocamlx(Load_path) ocamlx(Location) ocamlx(Misc) ocamlx(Parse) ocamlx(Parser) ocamlx(Stdlib) ocamlx(Stdlib__arg) ocamlx(Stdlib__array) ocamlx(Stdlib__buffer) ocamlx(Stdlib__filename) ocamlx(Stdlib__format) ocamlx(Stdlib__hashtbl) ocamlx(Stdlib__lexing) ocamlx(Stdlib__list) ocamlx(Stdlib__listLabels) ocamlx(Stdlib__printexc) ocamlx(Stdlib__printf) ocamlx(Stdlib__string) ocamlx(Stdlib__stringLabels) ocamlx(Stdlib__sys) ocamlx(Syntaxerr) rtld(GNU_HASH) ocaml-ppxlib-devel (rpmlib, GLIBC filtered): ocaml(Ast_mapper) ocaml(Asttypes) ocaml(Base) ocaml(Base__) ocaml(Base__Applicative) ocaml(Base__Applicative_intf) ocaml(Base__Array) ocaml(Base__Backtrace) ocaml(Base__Binary_searchable) ocaml(Base__Binary_searchable_intf) ocaml(Base__Blit) ocaml(Base__Blit_intf) ocaml(Base__Bool) ocaml(Base__Buffer) ocaml(Base__Buffer_intf) ocaml(Base__Bytes) ocaml(Base__Bytes_set_primitives) ocaml(Base__Char) ocaml(Base__Comparable) ocaml(Base__Comparable_intf) ocaml(Base__Comparator) ocaml(Base__Comparisons) ocaml(Base__Container) ocaml(Base__Container_intf) ocaml(Base__Either) ocaml(Base__Either_intf) ocaml(Base__Equal) ocaml(Base__Error) ocaml(Base__Exn) ocaml(Base__Field) ocaml(Base__Float) ocaml(Base__Floatable) ocaml(Base__Fn) ocaml(Base__Formatter) ocaml(Base__Hash) ocaml(Base__Hash_intf) ocaml(Base__Hash_set) ocaml(Base__Hash_set_intf) ocaml(Base__Hashable) ocaml(Base__Hashable_intf) ocaml(Base__Hasher) ocaml(Base__Hashtbl) ocaml(Base__Hashtbl_intf) ocaml(Base__Identifiable) ocaml(Base__Import) ocaml(Base__Import0) ocaml(Base__Indexed_container) ocaml(Base__Indexed_container_intf) ocaml(Base__Info) ocaml(Base__Info_intf) ocaml(Base__Int) ocaml(Base__Int0) ocaml(Base__Int32) ocaml(Base__Int63) ocaml(Base__Int63_emul) ocaml(Base__Int64) ocaml(Base__Int_intf) ocaml(Base__Intable) ocaml(Base__Invariant) ocaml(Base__Invariant_intf) ocaml(Base__Lazy) ocaml(Base__List) ocaml(Base__Map) ocaml(Base__Map_intf) ocaml(Base__Maybe_bound) ocaml(Base__Monad) ocaml(Base__Monad_intf) ocaml(Base__Nativeint) ocaml(Base__Option) ocaml(Base__Or_error) ocaml(Base__Poly0) ocaml(Base__Ppx_compare_lib) ocaml(Base__Ppx_hash_lib) ocaml(Base__Ppx_sexp_conv_lib) ocaml(Base__Pretty_printer) ocaml(Base__Printf) ocaml(Base__Random) ocaml(Base__Ref) ocaml(Base__Result) ocaml(Base__Sequence) ocaml(Base__Set) ocaml(Base__Set_intf) ocaml(Base__Sexp) ocaml(Base__Sexp_with_comparable) ocaml(Base__Sexpable) ocaml(Base__Sexplib) ocaml(Base__Sign) ocaml(Base__Sign0) ocaml(Base__Sign_or_nan) ocaml(Base__Source_code_position0) ocaml(Base__Staged) ocaml(Base__String) ocaml(Base__String0) ocaml(Base__Stringable) ocaml(Base__Sys0) ocaml(Base__T) ocaml(Base__Unit) ocaml(Base__Validate) ocaml(Base__With_return) ocaml(Base_internalhash_types) ocaml(Build_path_prefix_map) ocaml(Caml) ocaml(CamlinternalFormatBasics) ocaml(CamlinternalLazy) ocaml(CamlinternalMenhirLib) ocaml(CamlinternalOO) ocaml(Clflags) ocaml(Cmi_format) ocaml(Compmisc) ocaml(Config) ocaml(Docstrings) ocaml(Env) ocaml(Ident) ocaml(Identifiable) ocaml(Lexer) ocaml(Load_path) ocaml(Location) ocaml(Longident) ocaml(Migrate_parsetree) ocaml(Migrate_parsetree__) ocaml(Migrate_parsetree__Ast_402) ocaml(Migrate_parsetree__Ast_403) ocaml(Migrate_parsetree__Ast_404) ocaml(Migrate_parsetree__Ast_405) ocaml(Migrate_parsetree__Ast_406) ocaml(Migrate_parsetree__Ast_407) ocaml(Migrate_parsetree__Ast_408) ocaml(Migrate_parsetree__Ast_408_helper) ocaml(Migrate_parsetree__Ast_409) ocaml(Migrate_parsetree__Ast_409_helper) ocaml(Migrate_parsetree__Ast_410) ocaml(Migrate_parsetree__Ast_411) ocaml(Migrate_parsetree__Locations) ocaml(Migrate_parsetree__Migrate_parsetree_ast_io) ocaml(Migrate_parsetree__Migrate_parsetree_compiler_functions) ocaml(Migrate_parsetree__Migrate_parsetree_driver) ocaml(Migrate_parsetree__Migrate_parsetree_versions) ocaml(Migrate_parsetree__Option) ocaml(Migrate_parsetree__Stdlib0) ocaml(Misc) ocaml(Ocaml_common) ocaml(Ocaml_shadow) ocaml(Outcometree) ocaml(Parse) ocaml(Parser) ocaml(Parsetree) ocaml(Path) ocaml(Ppx_derivers) ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Caller_id) ocaml(Ppxlib__Code_matcher) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Compiler_specifics) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__File_path) ocaml(Ppxlib__Ignore_unused_warning) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Location_check) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Merlin_helpers) ocaml(Ppxlib__Name) ocaml(Ppxlib__Options) ocaml(Ppxlib__Reconcile) ocaml(Ppxlib__Spellcheck) ocaml(Ppxlib__Utils) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_ast__Misc_helper) ocaml(Ppxlib_ast__Pprintast) ocaml(Ppxlib_ast__Warn) ocaml(Ppxlib_metaquot_lifters) ocaml(Ppxlib_print_diff) ocaml(Ppxlib_runner) ocaml(Ppxlib_runner_as_ppx) ocaml(Ppxlib_traverse_builtins) ocaml(Primitive) ocaml(Profile) ocaml(Result) ocaml(Sexplib0) ocaml(Sexplib0__Sexp) ocaml(Sexplib0__Sexp_conv) ocaml(Sexplib0__Sexp_conv_error) ocaml(Shadow_stdlib) ocaml(Stdio) ocaml(Stdio__) ocaml(Stdio__Import) ocaml(Stdio__In_channel) ocaml(Stdio__Out_channel) ocaml(Stdlib) ocaml(Stdlib__arg) ocaml(Stdlib__array) ocaml(Stdlib__buffer) ocaml(Stdlib__digest) ocaml(Stdlib__filename) ocaml(Stdlib__format) ocaml(Stdlib__hashtbl) ocaml(Stdlib__int32) ocaml(Stdlib__int64) ocaml(Stdlib__lazy) ocaml(Stdlib__lexing) ocaml(Stdlib__list) ocaml(Stdlib__listLabels) ocaml(Stdlib__map) ocaml(Stdlib__moreLabels) ocaml(Stdlib__nativeint) ocaml(Stdlib__obj) ocaml(Stdlib__parsing) ocaml(Stdlib__pervasives) ocaml(Stdlib__printexc) ocaml(Stdlib__printf) ocaml(Stdlib__seq) ocaml(Stdlib__set) ocaml(Stdlib__stdLabels) ocaml(Stdlib__string) ocaml(Stdlib__stringLabels) ocaml(Stdlib__sys) ocaml(Stdlib__uchar) ocaml(Subst) ocaml(Syntaxerr) ocaml(Type_immediacy) ocaml(Types) ocaml(Warnings) ocaml-base-devel(x86-64) ocaml-compiler-libs-janestreet-devel(x86-64) ocaml-migrate-parsetree-devel(x86-64) ocaml-ppx-derivers-devel(x86-64) ocaml-ppxlib(x86-64) ocaml-result-devel(x86-64) ocaml-stdio-devel(x86-64) ocamlx(Ast_mapper) ocamlx(CamlinternalLazy) ocamlx(CamlinternalOO) ocamlx(Clflags) ocamlx(Compmisc) ocamlx(Lexer) ocamlx(Load_path) ocamlx(Location) ocamlx(Misc) ocamlx(Parse) ocamlx(Parser) ocamlx(Stdlib) ocamlx(Stdlib__arg) ocamlx(Stdlib__array) ocamlx(Stdlib__buffer) ocamlx(Stdlib__filename) ocamlx(Stdlib__format) ocamlx(Stdlib__hashtbl) ocamlx(Stdlib__lexing) ocamlx(Stdlib__list) ocamlx(Stdlib__listLabels) ocamlx(Stdlib__printexc) ocamlx(Stdlib__printf) ocamlx(Stdlib__string) ocamlx(Stdlib__stringLabels) ocamlx(Stdlib__sys) ocamlx(Syntaxerr) ocaml-ppxlib-doc (rpmlib, GLIBC filtered): ocaml-ppxlib-debuginfo (rpmlib, GLIBC filtered): ocaml-ppxlib-debugsource (rpmlib, GLIBC filtered): Provides -------- ocaml-ppxlib: ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Caller_id) ocaml(Ppxlib__Code_matcher) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Compiler_specifics) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__File_path) ocaml(Ppxlib__Ignore_unused_warning) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Location_check) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Merlin_helpers) ocaml(Ppxlib__Name) ocaml(Ppxlib__Options) ocaml(Ppxlib__Quoter) ocaml(Ppxlib__Reconcile) ocaml(Ppxlib__Spellcheck) ocaml(Ppxlib__Utils) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_ast__Misc_helper) ocaml(Ppxlib_ast__Pprintast) ocaml(Ppxlib_ast__Warn) ocaml(Ppxlib_metaquot) ocaml(Ppxlib_metaquot_lifters) ocaml(Ppxlib_print_diff) ocaml(Ppxlib_runner) ocaml(Ppxlib_runner__Ppx_driver_runner) ocaml(Ppxlib_runner_as_ppx) ocaml(Ppxlib_runner_as_ppx__Ppx_driver_runner_as_ppx) ocaml(Ppxlib_traverse) ocaml(Ppxlib_traverse_builtins) ocaml-ppxlib ocaml-ppxlib(x86-64) ocamlx(Ppxlib) ocamlx(Ppxlib__) ocamlx(Ppxlib__Ast_builder) ocamlx(Ppxlib__Ast_builder_generated) ocamlx(Ppxlib__Ast_builder_intf) ocamlx(Ppxlib__Ast_pattern) ocamlx(Ppxlib__Ast_pattern0) ocamlx(Ppxlib__Ast_pattern_generated) ocamlx(Ppxlib__Ast_traverse) ocamlx(Ppxlib__Attribute) ocamlx(Ppxlib__Caller_id) ocamlx(Ppxlib__Code_matcher) ocamlx(Ppxlib__Code_path) ocamlx(Ppxlib__Common) ocamlx(Ppxlib__Compiler_specifics) ocamlx(Ppxlib__Context_free) ocamlx(Ppxlib__Deriving) ocamlx(Ppxlib__Driver) ocamlx(Ppxlib__Expansion_context) ocamlx(Ppxlib__Extension) ocamlx(Ppxlib__File_path) ocamlx(Ppxlib__Ignore_unused_warning) ocamlx(Ppxlib__Import) ocamlx(Ppxlib__Loc) ocamlx(Ppxlib__Location) ocamlx(Ppxlib__Location_check) ocamlx(Ppxlib__Longident) ocamlx(Ppxlib__Merlin_helpers) ocamlx(Ppxlib__Name) ocamlx(Ppxlib__Options) ocamlx(Ppxlib__Quoter) ocamlx(Ppxlib__Reconcile) ocamlx(Ppxlib__Spellcheck) ocamlx(Ppxlib__Utils) ocamlx(Ppxlib_ast) ocamlx(Ppxlib_ast__) ocamlx(Ppxlib_ast__Ast) ocamlx(Ppxlib_ast__Import) ocamlx(Ppxlib_ast__Lexer_helper) ocamlx(Ppxlib_ast__Location_helper) ocamlx(Ppxlib_ast__Misc_helper) ocamlx(Ppxlib_ast__Pprintast) ocamlx(Ppxlib_ast__Warn) ocamlx(Ppxlib_metaquot) ocamlx(Ppxlib_metaquot_lifters) ocamlx(Ppxlib_print_diff) ocamlx(Ppxlib_runner) ocamlx(Ppxlib_runner__Ppx_driver_runner) ocamlx(Ppxlib_runner_as_ppx) ocamlx(Ppxlib_runner_as_ppx__Ppx_driver_runner_as_ppx) ocamlx(Ppxlib_traverse) ocamlx(Ppxlib_traverse_builtins) ocaml-ppxlib-devel: ocaml(Ppxlib) ocaml(Ppxlib__) ocaml(Ppxlib__Ast_builder) ocaml(Ppxlib__Ast_builder_generated) ocaml(Ppxlib__Ast_builder_intf) ocaml(Ppxlib__Ast_pattern) ocaml(Ppxlib__Ast_pattern0) ocaml(Ppxlib__Ast_pattern_generated) ocaml(Ppxlib__Ast_traverse) ocaml(Ppxlib__Attribute) ocaml(Ppxlib__Caller_id) ocaml(Ppxlib__Code_matcher) ocaml(Ppxlib__Code_path) ocaml(Ppxlib__Common) ocaml(Ppxlib__Compiler_specifics) ocaml(Ppxlib__Context_free) ocaml(Ppxlib__Deriving) ocaml(Ppxlib__Driver) ocaml(Ppxlib__Expansion_context) ocaml(Ppxlib__Extension) ocaml(Ppxlib__File_path) ocaml(Ppxlib__Ignore_unused_warning) ocaml(Ppxlib__Import) ocaml(Ppxlib__Loc) ocaml(Ppxlib__Location) ocaml(Ppxlib__Location_check) ocaml(Ppxlib__Longident) ocaml(Ppxlib__Merlin_helpers) ocaml(Ppxlib__Name) ocaml(Ppxlib__Options) ocaml(Ppxlib__Quoter) ocaml(Ppxlib__Reconcile) ocaml(Ppxlib__Spellcheck) ocaml(Ppxlib__Utils) ocaml(Ppxlib_ast) ocaml(Ppxlib_ast__) ocaml(Ppxlib_ast__Ast) ocaml(Ppxlib_ast__Import) ocaml(Ppxlib_ast__Lexer_helper) ocaml(Ppxlib_ast__Location_helper) ocaml(Ppxlib_ast__Misc_helper) ocaml(Ppxlib_ast__Pprintast) ocaml(Ppxlib_ast__Warn) ocaml(Ppxlib_metaquot) ocaml(Ppxlib_metaquot_lifters) ocaml(Ppxlib_print_diff) ocaml(Ppxlib_runner) ocaml(Ppxlib_runner__Ppx_driver_runner) ocaml(Ppxlib_runner_as_ppx) ocaml(Ppxlib_runner_as_ppx__Ppx_driver_runner_as_ppx) ocaml(Ppxlib_traverse) ocaml(Ppxlib_traverse_builtins) ocaml-ppxlib-devel ocaml-ppxlib-devel(x86-64) ocamlx(Ppxlib) ocamlx(Ppxlib__) ocamlx(Ppxlib__Ast_builder) ocamlx(Ppxlib__Ast_builder_generated) ocamlx(Ppxlib__Ast_builder_intf) ocamlx(Ppxlib__Ast_pattern) ocamlx(Ppxlib__Ast_pattern0) ocamlx(Ppxlib__Ast_pattern_generated) ocamlx(Ppxlib__Ast_traverse) ocamlx(Ppxlib__Attribute) ocamlx(Ppxlib__Caller_id) ocamlx(Ppxlib__Code_matcher) ocamlx(Ppxlib__Code_path) ocamlx(Ppxlib__Common) ocamlx(Ppxlib__Compiler_specifics) ocamlx(Ppxlib__Context_free) ocamlx(Ppxlib__Deriving) ocamlx(Ppxlib__Driver) ocamlx(Ppxlib__Expansion_context) ocamlx(Ppxlib__Extension) ocamlx(Ppxlib__File_path) ocamlx(Ppxlib__Ignore_unused_warning) ocamlx(Ppxlib__Import) ocamlx(Ppxlib__Loc) ocamlx(Ppxlib__Location) ocamlx(Ppxlib__Location_check) ocamlx(Ppxlib__Longident) ocamlx(Ppxlib__Merlin_helpers) ocamlx(Ppxlib__Name) ocamlx(Ppxlib__Options) ocamlx(Ppxlib__Quoter) ocamlx(Ppxlib__Reconcile) ocamlx(Ppxlib__Spellcheck) ocamlx(Ppxlib__Utils) ocamlx(Ppxlib_ast) ocamlx(Ppxlib_ast__) ocamlx(Ppxlib_ast__Ast) ocamlx(Ppxlib_ast__Import) ocamlx(Ppxlib_ast__Lexer_helper) ocamlx(Ppxlib_ast__Location_helper) ocamlx(Ppxlib_ast__Misc_helper) ocamlx(Ppxlib_ast__Pprintast) ocamlx(Ppxlib_ast__Warn) ocamlx(Ppxlib_metaquot) ocamlx(Ppxlib_metaquot_lifters) ocamlx(Ppxlib_print_diff) ocamlx(Ppxlib_runner) ocamlx(Ppxlib_runner__Ppx_driver_runner) ocamlx(Ppxlib_runner_as_ppx) ocamlx(Ppxlib_runner_as_ppx__Ppx_driver_runner_as_ppx) ocamlx(Ppxlib_traverse) ocamlx(Ppxlib_traverse_builtins) ocaml-ppxlib-doc: ocaml-ppxlib-doc ocaml-ppxlib-debuginfo: debuginfo(build-id) ocaml-ppxlib-debuginfo ocaml-ppxlib-debuginfo(x86-64) ocaml-ppxlib-debugsource: ocaml-ppxlib-debugsource ocaml-ppxlib-debugsource(x86-64) Generated by fedora-review 0.7.5 (5fa5b7e) last change: 2020-02-16 Command line :/usr/bin/fedora-review -n ocaml-ppxlib --prebuilt Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, C/C++, Generic, Ocaml Disabled plugins: R, PHP, Python, Haskell, fonts, SugarActivity, Java, Perl Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
This package is *APPROVED* by rjones.
Thank you for the review! (In reply to Richard W.M. Jones from comment #3) > Manual inspection of the spec file shows that it looks sensible. Literally > the only thing I could nitpick is that it would be nice to know if the two > patches are upstream/going upstream/never upstream. I would like to know that myself. Well, upstream is aware of both issues and will hopefully take action at some point. (In reply to Richard W.M. Jones from comment #5) > rjones: f-r says the package doesn't install, but I was able > to install it just fine locally so I think we can ignore this. Hmmm, the same thing happened when I did the review for you. I just installed manually and fixed up the report. Apparently fedora-review is having issues with installing. I'll try to squeeze out some time to look into that. > rjones: licensecheck is all over the place here, but most files lack > any license information in the file. It seems as if upstream intend > this to be some kind of MIT license. It would be good to encourage > upstream to add a license to every file. Okay, I'll talk to upstream about it. > rjones: licensecheck is wrong here. I manually checked the license > and it is correct. licensecheck always calls MIT-licensed files "Expat". They're basically the same license, so I guess that's okay, but it can be confusing. > Ocaml: > [x]: This should never happen > > rjones: ? That seems to come from /usr/share/fedora-review/plugins/ocaml.py, which says: class OcamlCheckStaticLibs(OcamlCheckBase): """ Disable static lib checking, ocaml has an exception. """ def __init__(self, checks): OcamlCheckBase.__init__(self, checks) self.automatic = True self.text = "This should never happen" self.deprecates.append("CheckStaticLibs") def run_on_applicable(self): self.set_passed(self.PASS) I don't know "This should never happen" winds up in the report, though. > rjones: I built it using rpmbuild. It doesn't build in _my_ mock but > it seems to be because my local mock is broken in some way. FWIW, it builds fine in mock on my system.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/ocaml-ppxlib
FEDORA-2020-a60e08c9f4 has been submitted as an update to Fedora 32. https://bodhi.fedoraproject.org/updates/FEDORA-2020-a60e08c9f4
FEDORA-2020-a60e08c9f4 has been pushed to the Fedora 32 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-a60e08c9f4 \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-a60e08c9f4 See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-a60e08c9f4 has been pushed to the Fedora 32 stable repository. If problem still persists, please make note of it in this bug report.