Red Hat Bugzilla – Bug 183888
Review Request: perl-Crypt-RSA
Last modified: 2009-03-12 23:11:08 EDT
Spec Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-RSA/perl-Crypt-RSA.spec
SRPM Name or Url: http://www.city-fan.org/~paul/extras/perl-Crypt-RSA/perl-Crypt-RSA-1.57-1.src.rpm
Crypt::RSA is a pure-perl, cleanroom implementation of the RSA public-key
cryptosystem. It uses Math::Pari(3), a perl interface to the blazingly fast
PARI library, for big integer arithmetic and number theoretic computations.
Crypt::RSA provides arbitrary size key-pair generation, plaintext-aware
encryption (OAEP) and digital signatures with appendix (PSS). For compatibility
with SSLv3, RSAREF2, PGP and other applications that follow the PKCS #1 v1.5
standard, it also provides PKCS #1 v1.5 encryption and signatures.
I'm keeping a local repo with the dependency chain in it so that I can do
reviews of these; I can't see anything that would keep Math::Pari from being
approved so I'm just working on the assumption that it will eventually make its
way into Extras.
W: perl-Crypt-RSA file-not-utf8 /usr/share/man/man3/Crypt::RSA.3pm.gz
This is due to a single accented 'e' in the POD. "iconv -f iso-8859-1 -t utf-8"
should fix it up.
Artistic license is included, but not GPL. Not a blocker, but upstream should
probably be whacked.
I'm not sure what to do with the two files in extradocs. One of them is
referenced from the main manpage, but it also references an interoperability
table which doesn't seem to be included.
Otherwise it looks clean.
* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible. It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
* BuildRequires are proper.
* package builds in mock.
X rpmlint complains of non-utf8 documentation; see above.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directories it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present and all tests pass.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
(In reply to comment #1)
> W: perl-Crypt-RSA file-not-utf8 /usr/share/man/man3/Crypt::RSA.3pm.gz
> This is due to a single accented 'e' in the POD. "iconv -f iso-8859-1 -t utf-8"
> should fix it up.
Done in -2
> Artistic license is included, but not GPL. Not a blocker, but upstream should
> probably be whacked.
> I'm not sure what to do with the two files in extradocs. One of them is
> referenced from the main manpage, but it also references an interoperability
> table which doesn't seem to be included.
One of the files *is* the aforementioned table. Not a lot in it really.
I've converted both files to manpages using pod2man and installed them in the
places you'd look for them if following the link from the main manpage.
Builds cleanly and rpmlint is placated. Everything else looks good.
Thanks for the review.
7877 (perl-Crypt-RSA): Build on target fedora-development-extras succeeded.
Build logs may be found at
FC-4 and FC-5 branches requested.
Package Change Request
Package Name: perl-Crypt-RSA
New Branches: EL-4 EL-5