Spec URL: https://rmattes.fedorapeople.org/RPMS/bloaty/bloaty.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/bloaty/bloaty-1.1-1.fc32.src.rpm Description: Ever wondered what's making your binary big? Bloaty McBloatface will show you a size profile of the binary so you can understand what's taking up space inside. Bloaty works on binaries, shared objects, object files, and static libraries. Bloaty supports the ELF and Mach-O formats, and has experimental support for WebAssembly. Fedora Account System Username: rmattes rpmlint: $ rpmlint bloaty.spec ../RPMS/x86_64/bloaty-* ../SRPMS/bloaty-1.1-1.fc32.src.rpm bloaty.x86_64: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled bloaty.x86_64: W: no-manual-page-for-binary bloaty bloaty.src: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled 4 packages and 1 specfiles checked; 0 errors, 3 warnings. Spelling errors aren't errors, upstream does not provide a manpage.
>%install >rm -rf %{buildroot} Don't remove the buildroot at start of %install. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_tags_and_sections Also - since you're not using the Google-provided .bz2 archive, but rather the GitHub generated tarball as Source0, the test suite is included in the download. How about running those in %check?
Thanks for the feedback. I removed the line removing the buildroot (it was in the spec generated by rpmdev-newspec - I should file a bug) and patched the buildsystem to use the system versions of gtest and gmock so that tests can be enabled. Updates here: Spec URL: https://rmattes.fedorapeople.org/RPMS/bloaty/bloaty.spec SRPM URL: https://rmattes.fedorapeople.org/RPMS/bloaty/bloaty-1.1-2.fc32.src.rpm $ rpmlint bloaty.spec ../RPMS/x86_64/bloaty*1.1-2* ../SRPMS/bloaty-1.1-2.fc32.src.rpm bloaty.x86_64: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled bloaty.x86_64: W: no-manual-page-for-binary bloaty bloaty.src: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled 4 packages and 1 specfiles checked; 0 errors, 3 warnings.
Package approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Apache License 2.0", "BSD 4-clause "Original" or "Old" License BSD 2-clause "Simplified" License", "BSD 2-clause "Simplified" License", "BSD 4-clause "Original" or "Old" License", "BSD 3-clause "New" or "Revised" License". 134 files have unknown license. Detailed output of licensecheck in /home/bob/packaging/review/bloaty/review-bloaty/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 51200 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: bloaty-1.1-2.fc33.x86_64.rpm bloaty-debuginfo-1.1-2.fc33.x86_64.rpm bloaty-debugsource-1.1-2.fc33.x86_64.rpm bloaty-1.1-2.fc33.src.rpm bloaty.x86_64: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled bloaty.x86_64: W: no-manual-page-for-binary bloaty bloaty.src: W: spelling-error Summary(en_US) profiler -> profile, profiles, profiled 4 packages and 0 specfiles checked; 0 errors, 3 warnings.
Thanks for the review!
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/bloaty
FEDORA-2020-e2dd9c64bb has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2020-e2dd9c64bb
FEDORA-2020-e2dd9c64bb has been pushed to the Fedora 33 testing repository. In short time you'll be able to install the update with the following command: `sudo dnf install --enablerepo=updates-testing --advisory=FEDORA-2020-e2dd9c64bb \*` You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2020-e2dd9c64bb See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.
FEDORA-2020-e2dd9c64bb has been pushed to the Fedora 33 stable repository. If problem still persists, please make note of it in this bug report.