Spec Name or Url: http://www.df.lth.se/~triad/krad/fc/gnokii.spec SRPM Name or Url: http://www.df.lth.se/~triad/krad/fc/gnokii-0.6.11-1.src.rpm Description: Gnokii is a mobile phone swiss army knife with a library and several command-line utilities for managing mobile phones of different kinds. It can make data calls and retrieve/send SMS on several phone models. It also aims to provide e.g. fax service. This RPM is based off Ville Skyttä's RPM from livna, which has been cleared to move into the Extras since the offending artwork once contained in it is now in a separate package.
As I'm intimately familiar with the package, it might be useful if someone else would review this. However, if nobody picks it up by Friday, I will do it. Some initial comments anyway: If the smsd-sql patch is the same as in my old package, the comment is misleading. It does not create the database because everything in the patch is commented out; it's just for documentation purposes. I think it's safe to drop the Obsoletes: in xgnokii. Including xgnokii.pc in xgnokii doesn't seem right. It should probably be moved to gnokii-devel. Or if not, xgnokii should have a dependency on pkgconfig.
OK fixed these things, also made a patch for the xgnokii.pc.in file in line with the gnokii.pc.in patch. Spec: http://www.df.lth.se/~triad/krad/fc/gnokii.spec SRPM: http://www.df.lth.se/~triad/krad/fc/gnokii-0.6.11-2.src.rpm
0.6.12 is out, could you update to it before a real review? BTW a considerably smaller .bz2 tarball is available upstream.
OK thanks Ville: Spec: http://www.df.lth.se/~triad/krad/fc/gnokii.spec SRPM: http://www.df.lth.se/~triad/krad/fc/gnokii-0.6.12-1.src.rpm
- FC5+: BR openssl-devel can be dropped - FC5+: BR libXt-devel libXpm-devel needed - standard /usr/lib64 rpath on x86_64 could be avoided eg. like (in %prep): sed -i -e 's|/lib /usr/lib\b|/%{_lib} %{_libdir}|' configure - I don't see why -devel would need Requires: xgnokii, my guess is that xgnokii.pc exists only so that the upstream artwork package can query xgnokii's prefix or something using pkgconfig, so leaving the dependency out should be ok - please convert to UTF-8: ChangeLog CREDITS README COPYRIGHT smsd/ChangeLog xgnokii/ChangeLog Other than those, looks good to me.
Sorry for late answer... Ville do you know a package example that convert a few files on-the-fly to UTF-8? I could reinvent the wheel but better not if someone else has already...
$ iconv --help Usage: iconv [OPTION...] [FILE...] Convert encoding of given files from one encoding to another. Input/Output format specification: -f, --from-code=NAME encoding of original text -t, --to-code=NAME encoding for output Information: -l, --list list all known coded character sets ...
This package should fix the remaining issues: Spec: http://www.df.lth.se/~triad/krad/fc/gnokii.spec SRPM: http://www.df.lth.se/~triad/krad/fc/gnokii-0.6.12-2.src.rpm
Looks good, but a couple of little things: Please move the iconv invocations to %prep like other source modifications. In %install they're possibly done multiple times with rpmbuild -bi --short-circuit. xgnokii.pc refers to %{prefix}/share/xgnokii for xgnokii's data files, maybe it would be a good idea to have the xgnokii package create/own that dir. These can be changed after the import and before the first build, approved.
(In reply to comment #9) > xgnokii.pc refers to %{prefix}/share/xgnokii Er, that's ${prefix}/share/xgnokii in pkgconfig terms and %{_prefix}/share/xgnokii in specfile terms.
OK built and released for FC-4, FC-5 and devel. Thanks for your time, Ville, but I hope you will keep an eye on the package in the future too!