Bug 1854563

+++ This bug was initially created as a clone of Bug #1846375 +++

Description of problem:

We now support setting up grafana against DWH's database.

In bug 1845049 we make a link to this grafana instance available to the engine in its conf, as item "ENGINE_GRAFANA_BASE_URL".

It would be nice for the engine to show on the front page a link there, if the item exists and is not empty.

"Workaround": This is also shown by engine-setup when it finishes, if grafana is configured, e.g.:

          Web access for grafana is enabled at:
              https://some.domain/ovirt-engine-grafana/

--- Additional comment from Sharon Gratch on 2020-07-01 19:55:01 CEST ---

The new "Monitoring Portal" entry is added to the landing page with a link to the Grafana URL.
both u/s and d/s branding are supported.

In case the engine conf file 10-setup-grafana-access.conf or properties are
invalid/missing, this new link will not be displayed on the landing page.

In case the user wants to overwrite the Grafana link, he can manually
set a value for the "portal_monitoring_url" message in external_resources.properties branding file.

If 10-setup-grafana-access.conf is created after engine is
running, refreshing the browser will read the file and add the new link to the landing page,
 so no restart is needed on engine side.

--- Additional comment from Sharon Gratch on 2020-07-02 14:26:48 CEST ---

(In reply to Sharon Gratch from comment #1)
> 
> If 10-setup-grafana-access.conf is created after engine is
> running, refreshing the browser will read the file and add the new link to
> the landing page,
>  so no restart is needed on engine side.
This is no longer true. The branding won't read new conf file till engine restart. Added a comment on the relevant bug: https://bugzilla.redhat.com/show_bug.cgi?id=1846294#c3

--- Additional comment from Pavel Novotny on 2020-07-07 18:53:08 CEST ---

VERIFIED in
ovirt-engine-4.4.1.7-0.3.el8ev

New link "Monitoring Portal" is present only on the welcome page" (oVirt upstream only*):

The link URL is defined either as value of ENGINE_GRAFANA_BASE_URL variable in config file /etc/ovirt-engine/engine.conf.d/10-setup-grafana-access.conf (engine restart needed)
or
can be overridden as "obrand.common.portal_monitoring_url" variable in /etc/ovirt-engine/branding/00-ovirt.brand/external_resources.properties branding file (only page reload needed).


(*) The portal link is not present on the downstream RHV welcome page (rhvm-branding-rhv-4.4.3-1.el8ev), the HTML part is missing in the welcome_page.template file.
    Cloning to downstream.