Spec URL: https://ppisar.fedorapeople.org/perl-GeoIP2/perl-GeoIP2.spec SRPM URL: https://ppisar.fedorapeople.org/perl-GeoIP2/perl-GeoIP2-2.006002-1.fc33.src.rpm Description: This package provides an API for the GeoIP2 web services and databases. The API also works with the GeoLite2 databases. Fedora Account System Username: ppisar
Source file is ok Summary is ok License is ok Description is ok URL and Source0 are ok All tests passed BuildRequires are almost ok FIX: Please add perl(lib) - GeoIP2-2.006002/t/GeoIP2/Model/City.t:4 $ rpm -qp --requires perl-GeoIP2-2.006002-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib 1 perl(B) 1 perl(Data::Dumper) 1 perl(Data::Validate::IP) >= 0.25 1 perl(Exporter) 1 perl(GeoIP2::Error::Generic) 1 perl(GeoIP2::Error::HTTP) 1 perl(GeoIP2::Error::IPAddressNotFound) 1 perl(GeoIP2::Error::Type) 1 perl(GeoIP2::Error::WebService) 1 perl(GeoIP2::Model::AnonymousIP) 1 perl(GeoIP2::Model::ASN) 1 perl(GeoIP2::Model::City) 1 perl(GeoIP2::Model::ConnectionType) 1 perl(GeoIP2::Model::Country) 1 perl(GeoIP2::Model::Domain) 1 perl(GeoIP2::Model::Enterprise) 1 perl(GeoIP2::Model::Insights) 1 perl(GeoIP2::Model::ISP) 1 perl(GeoIP2::Record::City) 1 perl(GeoIP2::Record::Continent) 1 perl(GeoIP2::Record::Country) 1 perl(GeoIP2::Record::Location) 1 perl(GeoIP2::Record::MaxMind) 1 perl(GeoIP2::Record::Postal) 1 perl(GeoIP2::Record::RepresentedCountry) 1 perl(GeoIP2::Record::Subdivision) 1 perl(GeoIP2::Record::Traits) 1 perl(GeoIP2::Types) 1 perl(GeoIP2::WebService::Client) 1 perl(Getopt::Long) 1 perl(HTTP::Headers) 1 perl(HTTP::Request) 1 perl(JSON::MaybeXS) 1 perl(List::SomeUtils) 1 perl(List::Util) 1 perl(LWP::Protocol::https) 1 perl(LWP::UserAgent) 1 perl(MaxMind::DB::Reader) >= 1.000000 1 perl(MIME::Base64) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(Moo) 1 perl(Moo::Role) 1 perl(namespace::clean) 1 perl(Params::Validate) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Sub::Quote) 1 perl(Throwable::Error) 1 perl(Try::Tiny) 1 perl(URI) 1 perl(:VERSION) >= 5.8.0 1 perl(warnings) 1 /usr/bin/env Binary requires are Ok. $ rpm -qp --provides perl-GeoIP2-2.006002-1.fc34.noarch.rpm | sort | uniq -c 1 perl(GeoIP2) = 2.006002 1 perl-GeoIP2 = 2.006002-1.fc34 1 perl(GeoIP2::Database::Reader) = 2.006002 1 perl(GeoIP2::Error::Generic) = 2.006002 1 perl(GeoIP2::Error::HTTP) = 2.006002 1 perl(GeoIP2::Error::IPAddressNotFound) = 2.006002 1 perl(GeoIP2::Error::Type) = 2.006002 1 perl(GeoIP2::Error::WebService) = 2.006002 1 perl(GeoIP2::Model::AnonymousIP) = 2.006002 1 perl(GeoIP2::Model::ASN) = 2.006002 1 perl(GeoIP2::Model::City) = 2.006002 1 perl(GeoIP2::Model::ConnectionType) = 2.006002 1 perl(GeoIP2::Model::Country) = 2.006002 1 perl(GeoIP2::Model::Domain) = 2.006002 1 perl(GeoIP2::Model::Enterprise) = 2.006002 1 perl(GeoIP2::Model::Insights) = 2.006002 1 perl(GeoIP2::Model::ISP) = 2.006002 1 perl(GeoIP2::Record::City) = 2.006002 1 perl(GeoIP2::Record::Continent) = 2.006002 1 perl(GeoIP2::Record::Country) = 2.006002 1 perl(GeoIP2::Record::Location) = 2.006002 1 perl(GeoIP2::Record::MaxMind) = 2.006002 1 perl(GeoIP2::Record::Postal) = 2.006002 1 perl(GeoIP2::Record::RepresentedCountry) = 2.006002 1 perl(GeoIP2::Record::Subdivision) = 2.006002 1 perl(GeoIP2::Record::Traits) = 2.006002 1 perl(GeoIP2::Role::Error::HTTP) = 2.006002 1 perl(GeoIP2::Role::HasIPAddress) = 2.006002 1 perl(GeoIP2::Role::HasLocales) = 2.006002 1 perl(GeoIP2::Role::Model) = 2.006002 1 perl(GeoIP2::Role::Model::Flat) = 2.006002 1 perl(GeoIP2::Role::Model::HasSubdivisions) = 2.006002 1 perl(GeoIP2::Role::Model::Location) = 2.006002 1 perl(GeoIP2::Role::Record::Country) = 2.006002 1 perl(GeoIP2::Role::Record::HasNames) = 2.006002 1 perl(GeoIP2::Types) = 2.006002 Binary provides are Ok. $ rpmlint ./perl-GeoIP2* perl-GeoIP2.noarch: E: env-script-interpreter /usr/bin/geoip2-web-service-request /usr/bin/env perl perl-GeoIP2.noarch: W: no-manual-page-for-binary geoip2-web-service-request 2 packages and 1 specfiles checked; 1 errors, 1 warnings. FIX: Please update the script interpreter Please correct all 'FIX' issues. Otherwise the package looks good. Resolution: Approved
https://pagure.io/releng/fedora-scm-requests/issue/27854
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-GeoIP2
Thank you for the review and the repository. I fixed both the issues. Although I'm curious how your build end up with /usr/bin/env shebang if rpmbuild rewrites on build for some time.