Bug 1868853 - Review Request: fcitx5-configtool - Configuration tools used by fcitx5
Summary: Review Request: fcitx5-configtool - Configuration tools used by fcitx5
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Andy Mender
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1868846 1868848
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-08-14 03:33 UTC by Qiyu Yan
Modified: 2020-08-26 13:54 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-08-26 13:54:31 UTC
Type: ---
Embargoed:
andymenderunix: fedora-review+


Attachments (Terms of Use)

Comment 1 Andy Mender 2020-08-23 16:05:35 UTC
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49972115
COPR build: https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1627144/

> BuildRequires:  fcitx5-qt-devel
> BuildRequires:  gettext-devel
> BuildRequires:  kf5-kwidgetsaddons-devel
> BuildRequires:  kf5-kirigami2-devel
> BuildRequires:  kf5-kdeclarative-devel
> BuildRequires:  kf5-kpackage-devel
> BuildRequires:  kf5-ki18n-devel
> BuildRequires:  kf5-kcoreaddons-devel
> BuildRequires:  kf5-kitemviews-devel

Can any of these be converted to the pkgconfig(foo) format as well?

> %files -f %{name}.lang -f %{translation_domain}.lang 
> %license LICENSES/GPL-2.0-or-later.txt
> %doc README

I checked the README and it's empty. Upstream never added anything to it: https://github.com/fcitx/fcitx5-configtool/blob/master/README
Not sure whether it's worth adding an empty README file to the package itself...

Package Review
==============

Legend:
[x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
[ ] = Manual review needed


Issues:
=======
- Package installs properly.
  Note: Installation errors (see attachment)
  See: https://docs.fedoraproject.org/en-US/packaging-guidelines/


===== MUST items =====

C/C++:
[x]: Package does not contain kernel modules.
[x]: Package contains no static executables.
[x]: Development (unversioned) .so files in -devel subpackage, if present.
     Note: Unversioned so-files in private %_libdir subdirectory (see
     attachment). Verify they are not in ld path.
     Review: Internal use only. Should be okay.
[x]: If your application is a C or C++ application you must list a
     BuildRequires against gcc, gcc-c++ or clang.
[x]: Header files in -devel subpackage, if present.
[x]: Package does not contain any libtool archives (.la)
[x]: Rpath absent or only used for internal libs.

Generic:
[x]: Package successfully compiles and builds into binary rpms on at least
     one supported primary architecture.
     Note: Using prebuilt packages
     Review: Works in COPR and Koji.
[x]: Package is licensed with an open-source compatible license and meets
     other legal requirements as defined in the legal section of Packaging
     Guidelines.
[x]: License field in the package spec file matches the actual license.
     Note: Checking patched sources after %prep for licenses. Licenses
     found: "Unknown or generated", "GNU Lesser General Public License".
     124 files have unknown license. Detailed output of licensecheck in
     /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool/licensecheck.txt
[x]: License file installed when any subpackage combination is installed.
[!]: Package must own all directories that it creates.
     Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms
     Review: Missing Requires? A quick repo check shows that the dir is used by:
     kwin-common
     kf5-kcmutils
[x]: %build honors applicable compiler flags or justifies otherwise.
[x]: Package contains no bundled libraries without FPC exception.
[x]: Changelog in prescribed format.
[x]: Sources contain only permissible code or content.
[-]: Development files must be in a -devel package
[?]: Package uses nothing in %doc for runtime.
[x]: The spec file handles locales properly.
[x]: Package consistently uses macros (instead of hard-coded directory
     names).
[x]: Package is named according to the Package Naming Guidelines.
[x]: Package does not generate any conflict.
[x]: Package obeys FHS, except libexecdir and /usr/target.
[-]: If the package is a rename of another package, proper Obsoletes and
     Provides are present.
[x]: Requires correct, justified where necessary.
[x]: Spec file is legible and written in American English.
[-]: Package contains systemd file(s) if in need.
[x]: Useful -debuginfo package or justification otherwise.
[x]: Package is not known to require an ExcludeArch tag.
[-]: Large documentation must go in a -doc subpackage. Large could be size
     (~1MB) or number of files.
     Note: Documentation size is 10240 bytes in 1 files.
[x]: Package complies to the Packaging Guidelines
[x]: Rpmlint is run on all rpms the build produces.
     Note: There are rpmlint messages (see attachment).
[x]: If (and only if) the source package includes the text of the
     license(s) in its own file, then that file, containing the text of the
     license(s) for the package is included in %license.
[x]: Package requires other packages for directories it uses.
[x]: Package does not own files or directories owned by other packages.
[x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
     beginning of %install.
[x]: Macros in Summary, %description expandable at SRPM build time.
[x]: Package contains desktop file if it is a GUI application.
[x]: Package installs a %{name}.desktop using desktop-file-install or
     desktop-file-validate if there is such a file.
[x]: Dist tag is present.
[x]: Package does not contain duplicates in %files.
[x]: Permissions on files are set properly.
[x]: Package must not depend on deprecated() packages.
[x]: Package use %makeinstall only when make install DESTDIR=... doesn't
     work.
[x]: Package is named using only allowed ASCII characters.
[x]: Package does not use a name that already exists.
[x]: Package is not relocatable.
[x]: Sources used to build the package match the upstream source, as
     provided in the spec URL.
[x]: Spec file name must match the spec package %{name}, in the format
     %{name}.spec.
[x]: File names are valid UTF-8.
[x]: Packages must not store files under /srv, /opt or /usr/local

===== SHOULD items =====

Generic:
[x]: Reviewer should test that the package builds in mock.
     Review: builds in COPR and Koji.
[-]: If the source package does not include license text(s) as a separate
     file from upstream, the packager SHOULD query upstream to include it.
[x]: Final provides and requires are sane (see attachments).
[x]: Package functions as described.
[x]: Latest version is packaged.
[x]: Package does not include license text files separate from upstream.
[x]: Patches link to upstream bugs/comments/lists or are otherwise
     justified.
[-]: Sources are verified with gpgverify first in %prep if upstream
     publishes signatures.
     Note: gpgverify is not used.
[-]: Description and summary sections in the package spec file contains
     translations for supported Non-English languages, if available.
[x]: Package should compile and build into binary rpms on all supported
     architectures.
     Review: Tested in COPR and Koji.
[-]: %check is present and all tests pass.
[x]: Packages should try to preserve timestamps of original installed
     files.
[x]: Buildroot is not present
[x]: Package has no %clean section with rm -rf %{buildroot} (or
     $RPM_BUILD_ROOT)
[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
[x]: Fully versioned dependency in subpackages if applicable.
[x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
[x]: Sources can be downloaded from URI in Source: tag
[x]: SourceX is a working URL.
[x]: Spec use %global instead of %define unless justified.

===== EXTRA items =====

Generic:
[!]: Rpmlint is run on all installed packages.
     Note: Mock build failed
     See: https://docs.fedoraproject.org/en-US/packaging-
     guidelines/#_use_rpmlint
[x]: Large data in /usr/share should live in a noarch subpackage if package
     is arched.


Installation errors
-------------------
INFO: mock.py version 2.4 starting (python version = 3.8.5)...
Start: init plugins
INFO: selinux enabled
Finish: init plugins
INFO: Signal handler active
Start: run
Start: chroot init
INFO: calling preinit hooks
INFO: enabled root cache
INFO: enabled package manager cache
Start: cleaning package manager metadata
Finish: cleaning package manager metadata
INFO: enabled HW Info plugin
Mock Version: 2.4
INFO: Mock Version: 2.4
Finish: chroot init
INFO: installing package(s): /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debugsource-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debuginfo-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
ERROR: Command failed: 
 # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debugsource-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debuginfo-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm --setopt=tsflags=nocontexts



Rpmlint
-------
Checking: fcitx5-configtool-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
          fcitx5-configtool-debuginfo-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
          fcitx5-configtool-debugsource-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
          fcitx5-configtool-0-0.2.gitecd16e5.fc34.src.rpm
fcitx5-configtool.x86_64: W: incoherent-version-in-changelog 0-0.2.20200811gitecd16e5 ['0-0.2.20200812gitecd16e5.fc34', '0-0.2.20200812gitecd16e5']
fcitx5-configtool.x86_64: E: zero-length /usr/share/doc/fcitx5-configtool/README
fcitx5-configtool.x86_64: W: no-manual-page-for-binary fcitx5-config-qt
fcitx5-configtool.x86_64: W: no-manual-page-for-binary kbd-layout-viewer5
fcitx5-configtool.src: W: patch-not-applied Patch0: 0001-use-usr-libexec-instead.patch
4 packages and 0 specfiles checked; 1 errors, 4 warnings.




Unversioned so-files
--------------------
fcitx5-configtool: /usr/lib64/qt5/plugins/kcms/kcm_fcitx5.so

Source checksums
----------------
https://github.com/fcitx/fcitx5-configtool/archive/ecd16e5f5bfeaded9bb59b88f484871d14e016e5/fcitx5-configtool-ecd16e5f5bfeaded9bb59b88f484871d14e016e5.tar.gz :
  CHECKSUM(SHA256) this package     : 94134ec446853f82f6dcf480a8240f51f4ffb9b603af79e3610c41770eda6603
  CHECKSUM(SHA256) upstream package : 94134ec446853f82f6dcf480a8240f51f4ffb9b603af79e3610c41770eda6603


Requires
--------
fcitx5-configtool (rpmlib, GLIBC filtered):
    kf5-filesystem
    libFcitx5Qt5DBusAddons.so.1()(64bit)
    libFcitx5Qt5WidgetsAddons.so.2()(64bit)
    libFcitx5Utils.so.2()(64bit)
    libKF5CoreAddons.so.5()(64bit)
    libKF5I18n.so.5()(64bit)
    libKF5ItemViews.so.5()(64bit)
    libKF5QuickAddons.so.5()(64bit)
    libKF5WidgetsAddons.so.5()(64bit)
    libQt5Core.so.5()(64bit)
    libQt5Core.so.5(Qt_5)(64bit)
    libQt5Core.so.5(Qt_5.14)(64bit)
    libQt5DBus.so.5()(64bit)
    libQt5DBus.so.5(Qt_5)(64bit)
    libQt5Gui.so.5()(64bit)
    libQt5Gui.so.5(Qt_5)(64bit)
    libQt5Qml.so.5()(64bit)
    libQt5Qml.so.5(Qt_5)(64bit)
    libQt5Quick.so.5()(64bit)
    libQt5Quick.so.5(Qt_5)(64bit)
    libQt5Widgets.so.5()(64bit)
    libQt5Widgets.so.5(Qt_5)(64bit)
    libQt5X11Extras.so.5()(64bit)
    libQt5X11Extras.so.5(Qt_5)(64bit)
    libX11.so.6()(64bit)
    libc.so.6()(64bit)
    libm.so.6()(64bit)
    libstdc++.so.6()(64bit)
    libstdc++.so.6(CXXABI_1.3)(64bit)
    libstdc++.so.6(CXXABI_1.3.9)(64bit)
    libxkbcommon.so.0()(64bit)
    libxkbcommon.so.0(V_0.5.0)(64bit)
    libxkbfile.so.1()(64bit)
    rtld(GNU_HASH)

fcitx5-configtool-debuginfo (rpmlib, GLIBC filtered):

fcitx5-configtool-debugsource (rpmlib, GLIBC filtered):



Provides
--------
fcitx5-configtool:
    application()
    application(kbd-layout-viewer5.desktop)
    fcitx5-configtool
    fcitx5-configtool(x86-64)
    metainfo()
    metainfo(org.fcitx.fcitx5.kcm.appdata.xml)

fcitx5-configtool-debuginfo:
    debuginfo(build-id)
    fcitx5-configtool-debuginfo
    fcitx5-configtool-debuginfo(x86-64)

fcitx5-configtool-debugsource:
    fcitx5-configtool-debugsource
    fcitx5-configtool-debugsource(x86-64)

Comment 2 Qiyu Yan 2020-08-23 16:14:52 UTC
(In reply to Andy Mender from comment #1)
> Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49972115
> COPR build:
> https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1627144/
> 
> > BuildRequires:  fcitx5-qt-devel
> > BuildRequires:  gettext-devel
> > BuildRequires:  kf5-kwidgetsaddons-devel
> > BuildRequires:  kf5-kirigami2-devel
> > BuildRequires:  kf5-kdeclarative-devel
> > BuildRequires:  kf5-kpackage-devel
> > BuildRequires:  kf5-ki18n-devel
> > BuildRequires:  kf5-kcoreaddons-devel
> > BuildRequires:  kf5-kitemviews-devel
> 
> Can any of these be converted to the pkgconfig(foo) format as well?

they doesn't provide pkgconfig(foo) but have 
cmake(foo), while cmake(foo) was introduced recently, some package didn't build with that. On f33+, mostly yes, on f32 some don't have tags like this.

> 
> > %files -f %{name}.lang -f %{translation_domain}.lang 
> > %license LICENSES/GPL-2.0-or-later.txt
> > %doc README
> 
> I checked the README and it's empty. Upstream never added anything to it:
> https://github.com/fcitx/fcitx5-configtool/blob/master/README
> Not sure whether it's worth adding an empty README file to the package
> itself...

Just in case upstream add content to readme, I won't forget to include that.

> 
> Package Review
> ==============
> 
> Legend:
> [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated
> [ ] = Manual review needed
> 
> 
> Issues:
> =======
> - Package installs properly.
>   Note: Installation errors (see attachment)
>   See: https://docs.fedoraproject.org/en-US/packaging-guidelines/
> 
> 
> ===== MUST items =====
> 
> C/C++:
> [x]: Package does not contain kernel modules.
> [x]: Package contains no static executables.
> [x]: Development (unversioned) .so files in -devel subpackage, if present.
>      Note: Unversioned so-files in private %_libdir subdirectory (see
>      attachment). Verify they are not in ld path.
>      Review: Internal use only. Should be okay.
> [x]: If your application is a C or C++ application you must list a
>      BuildRequires against gcc, gcc-c++ or clang.
> [x]: Header files in -devel subpackage, if present.
> [x]: Package does not contain any libtool archives (.la)
> [x]: Rpath absent or only used for internal libs.
> 
> Generic:
> [x]: Package successfully compiles and builds into binary rpms on at least
>      one supported primary architecture.
>      Note: Using prebuilt packages
>      Review: Works in COPR and Koji.
> [x]: Package is licensed with an open-source compatible license and meets
>      other legal requirements as defined in the legal section of Packaging
>      Guidelines.
> [x]: License field in the package spec file matches the actual license.
>      Note: Checking patched sources after %prep for licenses. Licenses
>      found: "Unknown or generated", "GNU Lesser General Public License".
>      124 files have unknown license. Detailed output of licensecheck in
>     
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool/
> licensecheck.txt
> [x]: License file installed when any subpackage combination is installed.
> [!]: Package must own all directories that it creates.
>      Note: Directories without known owners: /usr/lib64/qt5/plugins/kcms
>      Review: Missing Requires? A quick repo check shows that the dir is used
> by:
>      kwin-common
>      kf5-kcmutils
> [x]: %build honors applicable compiler flags or justifies otherwise.
> [x]: Package contains no bundled libraries without FPC exception.
> [x]: Changelog in prescribed format.
> [x]: Sources contain only permissible code or content.
> [-]: Development files must be in a -devel package
> [?]: Package uses nothing in %doc for runtime.
> [x]: The spec file handles locales properly.
> [x]: Package consistently uses macros (instead of hard-coded directory
>      names).
> [x]: Package is named according to the Package Naming Guidelines.
> [x]: Package does not generate any conflict.
> [x]: Package obeys FHS, except libexecdir and /usr/target.
> [-]: If the package is a rename of another package, proper Obsoletes and
>      Provides are present.
> [x]: Requires correct, justified where necessary.
> [x]: Spec file is legible and written in American English.
> [-]: Package contains systemd file(s) if in need.
> [x]: Useful -debuginfo package or justification otherwise.
> [x]: Package is not known to require an ExcludeArch tag.
> [-]: Large documentation must go in a -doc subpackage. Large could be size
>      (~1MB) or number of files.
>      Note: Documentation size is 10240 bytes in 1 files.
> [x]: Package complies to the Packaging Guidelines
> [x]: Rpmlint is run on all rpms the build produces.
>      Note: There are rpmlint messages (see attachment).
> [x]: If (and only if) the source package includes the text of the
>      license(s) in its own file, then that file, containing the text of the
>      license(s) for the package is included in %license.
> [x]: Package requires other packages for directories it uses.
> [x]: Package does not own files or directories owned by other packages.
> [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT
> [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>      beginning of %install.
> [x]: Macros in Summary, %description expandable at SRPM build time.
> [x]: Package contains desktop file if it is a GUI application.
> [x]: Package installs a %{name}.desktop using desktop-file-install or
>      desktop-file-validate if there is such a file.
> [x]: Dist tag is present.
> [x]: Package does not contain duplicates in %files.
> [x]: Permissions on files are set properly.
> [x]: Package must not depend on deprecated() packages.
> [x]: Package use %makeinstall only when make install DESTDIR=... doesn't
>      work.
> [x]: Package is named using only allowed ASCII characters.
> [x]: Package does not use a name that already exists.
> [x]: Package is not relocatable.
> [x]: Sources used to build the package match the upstream source, as
>      provided in the spec URL.
> [x]: Spec file name must match the spec package %{name}, in the format
>      %{name}.spec.
> [x]: File names are valid UTF-8.
> [x]: Packages must not store files under /srv, /opt or /usr/local
> 
> ===== SHOULD items =====
> 
> Generic:
> [x]: Reviewer should test that the package builds in mock.
>      Review: builds in COPR and Koji.
> [-]: If the source package does not include license text(s) as a separate
>      file from upstream, the packager SHOULD query upstream to include it.
> [x]: Final provides and requires are sane (see attachments).
> [x]: Package functions as described.
> [x]: Latest version is packaged.
> [x]: Package does not include license text files separate from upstream.
> [x]: Patches link to upstream bugs/comments/lists or are otherwise
>      justified.
> [-]: Sources are verified with gpgverify first in %prep if upstream
>      publishes signatures.
>      Note: gpgverify is not used.
> [-]: Description and summary sections in the package spec file contains
>      translations for supported Non-English languages, if available.
> [x]: Package should compile and build into binary rpms on all supported
>      architectures.
>      Review: Tested in COPR and Koji.
> [-]: %check is present and all tests pass.
> [x]: Packages should try to preserve timestamps of original installed
>      files.
> [x]: Buildroot is not present
> [x]: Package has no %clean section with rm -rf %{buildroot} (or
>      $RPM_BUILD_ROOT)
> [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
> [x]: Fully versioned dependency in subpackages if applicable.
> [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file
> [x]: Sources can be downloaded from URI in Source: tag
> [x]: SourceX is a working URL.
> [x]: Spec use %global instead of %define unless justified.
> 
> ===== EXTRA items =====
> 
> Generic:
> [!]: Rpmlint is run on all installed packages.
>      Note: Mock build failed
>      See: https://docs.fedoraproject.org/en-US/packaging-
>      guidelines/#_use_rpmlint
> [x]: Large data in /usr/share should live in a noarch subpackage if package
>      is arched.
> 
> 
> Installation errors
> -------------------
> INFO: mock.py version 2.4 starting (python version = 3.8.5)...
> Start: init plugins
> INFO: selinux enabled
> Finish: init plugins
> INFO: Signal handler active
> Start: run
> Start: chroot init
> INFO: calling preinit hooks
> INFO: enabled root cache
> INFO: enabled package manager cache
> Start: cleaning package manager metadata
> Finish: cleaning package manager metadata
> INFO: enabled HW Info plugin
> Mock Version: 2.4
> INFO: Mock Version: 2.4
> Finish: chroot init
> INFO: installing package(s):
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debugsource-
> 0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-0-0.2.
> 20200812gitecd16e5.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debuginfo-0-
> 0.2.20200812gitecd16e5.fc34.x86_64.rpm
> ERROR: Command failed: 
>  # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/
> --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local
> --disableplugin=spacewalk install
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debugsource-
> 0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-0-0.2.
> 20200812gitecd16e5.fc34.x86_64.rpm
> /home/amender/rpmbuild/SPECS/fcitx5-configtool/fcitx5-configtool-debuginfo-0-
> 0.2.20200812gitecd16e5.fc34.x86_64.rpm --setopt=tsflags=nocontexts
> 
> 
> 
> Rpmlint
> -------
> Checking: fcitx5-configtool-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
>          
> fcitx5-configtool-debuginfo-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
>          
> fcitx5-configtool-debugsource-0-0.2.20200812gitecd16e5.fc34.x86_64.rpm
>           fcitx5-configtool-0-0.2.gitecd16e5.fc34.src.rpm
> fcitx5-configtool.x86_64: W: incoherent-version-in-changelog
> 0-0.2.20200811gitecd16e5 ['0-0.2.20200812gitecd16e5.fc34',
> '0-0.2.20200812gitecd16e5']
> fcitx5-configtool.x86_64: E: zero-length
> /usr/share/doc/fcitx5-configtool/README
> fcitx5-configtool.x86_64: W: no-manual-page-for-binary fcitx5-config-qt
> fcitx5-configtool.x86_64: W: no-manual-page-for-binary kbd-layout-viewer5
> fcitx5-configtool.src: W: patch-not-applied Patch0:
> 0001-use-usr-libexec-instead.patch
> 4 packages and 0 specfiles checked; 1 errors, 4 warnings.
> 
> 
> 
> 
> Unversioned so-files
> --------------------
> fcitx5-configtool: /usr/lib64/qt5/plugins/kcms/kcm_fcitx5.so
> 
> Source checksums
> ----------------
> https://github.com/fcitx/fcitx5-configtool/archive/
> ecd16e5f5bfeaded9bb59b88f484871d14e016e5/fcitx5-configtool-
> ecd16e5f5bfeaded9bb59b88f484871d14e016e5.tar.gz :
>   CHECKSUM(SHA256) this package     :
> 94134ec446853f82f6dcf480a8240f51f4ffb9b603af79e3610c41770eda6603
>   CHECKSUM(SHA256) upstream package :
> 94134ec446853f82f6dcf480a8240f51f4ffb9b603af79e3610c41770eda6603
> 
> 
> Requires
> --------
> fcitx5-configtool (rpmlib, GLIBC filtered):
>     kf5-filesystem
>     libFcitx5Qt5DBusAddons.so.1()(64bit)
>     libFcitx5Qt5WidgetsAddons.so.2()(64bit)
>     libFcitx5Utils.so.2()(64bit)
>     libKF5CoreAddons.so.5()(64bit)
>     libKF5I18n.so.5()(64bit)
>     libKF5ItemViews.so.5()(64bit)
>     libKF5QuickAddons.so.5()(64bit)
>     libKF5WidgetsAddons.so.5()(64bit)
>     libQt5Core.so.5()(64bit)
>     libQt5Core.so.5(Qt_5)(64bit)
>     libQt5Core.so.5(Qt_5.14)(64bit)
>     libQt5DBus.so.5()(64bit)
>     libQt5DBus.so.5(Qt_5)(64bit)
>     libQt5Gui.so.5()(64bit)
>     libQt5Gui.so.5(Qt_5)(64bit)
>     libQt5Qml.so.5()(64bit)
>     libQt5Qml.so.5(Qt_5)(64bit)
>     libQt5Quick.so.5()(64bit)
>     libQt5Quick.so.5(Qt_5)(64bit)
>     libQt5Widgets.so.5()(64bit)
>     libQt5Widgets.so.5(Qt_5)(64bit)
>     libQt5X11Extras.so.5()(64bit)
>     libQt5X11Extras.so.5(Qt_5)(64bit)
>     libX11.so.6()(64bit)
>     libc.so.6()(64bit)
>     libm.so.6()(64bit)
>     libstdc++.so.6()(64bit)
>     libstdc++.so.6(CXXABI_1.3)(64bit)
>     libstdc++.so.6(CXXABI_1.3.9)(64bit)
>     libxkbcommon.so.0()(64bit)
>     libxkbcommon.so.0(V_0.5.0)(64bit)
>     libxkbfile.so.1()(64bit)
>     rtld(GNU_HASH)
> 
> fcitx5-configtool-debuginfo (rpmlib, GLIBC filtered):
> 
> fcitx5-configtool-debugsource (rpmlib, GLIBC filtered):
> 
> 
> 
> Provides
> --------
> fcitx5-configtool:
>     application()
>     application(kbd-layout-viewer5.desktop)
>     fcitx5-configtool
>     fcitx5-configtool(x86-64)
>     metainfo()
>     metainfo(org.fcitx.fcitx5.kcm.appdata.xml)
> 
> fcitx5-configtool-debuginfo:
>     debuginfo(build-id)
>     fcitx5-configtool-debuginfo
>     fcitx5-configtool-debuginfo(x86-64)
> 
> fcitx5-configtool-debugsource:
>     fcitx5-configtool-debugsource
>     fcitx5-configtool-debugsource(x86-64)

Comment 3 Qiyu Yan 2020-08-23 16:21:17 UTC
And for the /usr/lib64/qt5/plugins/kcms, it might here (UTC+8), I will fix tommorow.

Comment 4 Qiyu Yan 2020-08-24 00:36:33 UTC
added 
- Requires:       kf5-kcmutils

Comment 5 Andy Mender 2020-08-24 18:35:43 UTC
Koji build based on latest changes: https://koji.fedoraproject.org/koji/taskinfo?taskID=50082338

> they doesn't provide pkgconfig(foo) but have 
> cmake(foo), while cmake(foo) was introduced recently, some package didn't build with that. On f33+, mostly yes, on f32 some don't have tags like this.

We can do without it in this case.

> Just in case upstream add content to readme, I won't forget to include that.

Fair point. Let's keep it then.

> added 
> - Requires:       kf5-kcmutils

Verified:
[x]: Package requires other packages for directories it uses.
[x]: Package must own all directories that it creates.

Package approved!

Comment 6 Gwyn Ciesla 2020-08-25 13:22:35 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/fcitx5-configtool

Comment 7 Qiyu Yan 2020-08-26 13:54:31 UTC
Built in rawhide, only fcitx5-chinese-addons left


Note You need to log in before you can comment on or make changes to this bug.