Spec URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626689-fcitx5-skk/fcitx5-skk.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/yanqiyu/fcitx5/fedora-33-x86_64/01626689-fcitx5-skk/fcitx5-skk-0-0.2.20200813git02fb41d.fc33.src.rpm Description: Fcitx5-skk is an SKK (Simple Kana Kanji) engine for Fcitx. It provides Japanese input method using libskk. Fedora Account System Username: yanqiyu
Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49963649 COPR build: https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1626665/ > %files -f %{name}.lang > %license COPYING > %doc README.md > %{_libdir}/fcitx5/qt5/libfcitx5-skk-config.so > %{_libdir}/fcitx5/skk.so > %{_datadir}/fcitx5/addon/skk.conf > %{_datadir}/fcitx5/inputmethod/skk.conf > %{_datadir}/fcitx5/skk/dictionary_list fedora-review reports that nothing owns %{_datadir}/fcitx5/skk/ (in addition to the bogus reports about the remaining dirs). I think it's okay for this package to own the entire %{_datadir}/fcitx5/skk/ dir. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package installs properly. Note: Installation errors (see attachment) See: https://docs.fedoraproject.org/en-US/packaging-guidelines/ ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Review: Ignore warning. Unversioned SO files are for internal use only. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. Note: Using prebuilt packages Review: Tested in COPR and Koji. [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "GPL (v3 or later)". 37 files have unknown license. Detailed output of licensecheck in /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package requires other packages for directories it uses. Note: No known owner of /usr/lib64/fcitx5, /usr/share/fcitx5/skk, /usr/lib64/fcitx5/qt5, /usr/share/fcitx5, /usr/share/fcitx5/inputmethod, /usr/share/fcitx5/addon Review: Only /usr/share/fcitx5/skk is unowned. The rest belongs to fcitx5 subpackages and fcitx5-qt. [!]: Package must own all directories that it creates. Note: Directories without known owners: /usr/lib64/fcitx5/qt5, /usr/share/fcitx5, /usr/share/fcitx5/inputmethod, /usr/lib64/fcitx5, /usr/share/fcitx5/skk, /usr/share/fcitx5/addon Review: as above. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [?]: Package uses nothing in %doc for runtime. [x]: The spec file handles locales properly. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [-]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 10240 bytes in 1 files. [x]: Package complies to the Packaging Guidelines Review: Yes, but see comments about owned dirs. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [x]: Reviewer should test that the package builds in mock. Review: builds in COPR and Koji. [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. Review: Tested in COPR and Koji. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [!]: Rpmlint is run on all installed packages. Note: Mock build failed See: https://docs.fedoraproject.org/en-US/packaging- guidelines/#_use_rpmlint [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Installation errors ------------------- INFO: mock.py version 2.4 starting (python version = 3.8.5)... Start: init plugins INFO: selinux enabled Finish: init plugins INFO: Signal handler active Start: run Start: chroot init INFO: calling preinit hooks INFO: enabled root cache INFO: enabled package manager cache Start: cleaning package manager metadata Finish: cleaning package manager metadata INFO: enabled HW Info plugin Mock Version: 2.4 INFO: Mock Version: 2.4 Finish: chroot init INFO: installing package(s): /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk-debugsource-0-0.2.20200813git02fb41d.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk-0-0.2.20200813git02fb41d.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk-debuginfo-0-0.2.20200813git02fb41d.fc34.x86_64.rpm ERROR: Command failed: # /usr/bin/dnf --installroot /var/lib/mock/fedora-rawhide-x86_64/root/ --releasever 34 --setopt=deltarpm=False --allowerasing --disableplugin=local --disableplugin=spacewalk install /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk-debugsource-0-0.2.20200813git02fb41d.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk-0-0.2.20200813git02fb41d.fc34.x86_64.rpm /home/amender/rpmbuild/SPECS/fcitx5-skk/fcitx5-skk-debuginfo-0-0.2.20200813git02fb41d.fc34.x86_64.rpm --setopt=tsflags=nocontexts Rpmlint ------- Checking: fcitx5-skk-0-0.2.20200813git02fb41d.fc34.x86_64.rpm fcitx5-skk-debuginfo-0-0.2.20200813git02fb41d.fc34.x86_64.rpm fcitx5-skk-debugsource-0-0.2.20200813git02fb41d.fc34.x86_64.rpm fcitx5-skk-0-0.2.20200813git02fb41d.fc33.src.rpm fcitx5-skk.x86_64: W: spelling-error %description -l en_US libskk -> basilisk fcitx5-skk.src: W: spelling-error %description -l en_US libskk -> basilisk 4 packages and 0 specfiles checked; 0 errors, 2 warnings. Unversioned so-files -------------------- fcitx5-skk: /usr/lib64/fcitx5/qt5/libfcitx5-skk-config.so fcitx5-skk: /usr/lib64/fcitx5/skk.so Source checksums ---------------- https://github.com/fcitx/fcitx5-skk/archive/02fb41d84d27969116ca878428978df2275c597a/fcitx5-skk-02fb41d84d27969116ca878428978df2275c597a.tar.gz : CHECKSUM(SHA256) this package : 8f23952780887b8306d5bde7a4298dd3d2c26e15090e9302a5b3dbcc500684a0 CHECKSUM(SHA256) upstream package : 8f23952780887b8306d5bde7a4298dd3d2c26e15090e9302a5b3dbcc500684a0 Requires -------- fcitx5-skk (rpmlib, GLIBC filtered): fcitx5-data hicolor-icon-theme libFcitx5Config.so.6()(64bit) libFcitx5Core.so.6()(64bit) libFcitx5Qt5WidgetsAddons.so.2()(64bit) libFcitx5Utils.so.2()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6()(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libskk.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) rtld(GNU_HASH) skkdic fcitx5-skk-debuginfo (rpmlib, GLIBC filtered): fcitx5-skk-debugsource (rpmlib, GLIBC filtered): Provides -------- fcitx5-skk: fcitx5-skk fcitx5-skk(x86-64) fcitx5-skk-debuginfo: debuginfo(build-id) fcitx5-skk-debuginfo fcitx5-skk-debuginfo(x86-64) fcitx5-skk-debugsource: fcitx5-skk-debugsource fcitx5-skk-debugsource(x86-64)
(In reply to Andy Mender from comment #1) > Koji build: https://koji.fedoraproject.org/koji/taskinfo?taskID=49963649 > COPR build: > https://copr.fedorainfracloud.org/coprs/andymenderunix/fcitx5/build/1626665/ > > > %files -f %{name}.lang > > %license COPYING > > %doc README.md > > %{_libdir}/fcitx5/qt5/libfcitx5-skk-config.so > > %{_libdir}/fcitx5/skk.so > > %{_datadir}/fcitx5/addon/skk.conf > > %{_datadir}/fcitx5/inputmethod/skk.conf > > %{_datadir}/fcitx5/skk/dictionary_list > > fedora-review reports that nothing owns %{_datadir}/fcitx5/skk/ (in addition > to the bogus reports about the remaining dirs). I think it's okay for this > package to own the entire %{_datadir}/fcitx5/skk/ dir. > fixed by adding %dir %{_datadir}/fcitx5/skk
> fixed by adding > %dir %{_datadir}/fcitx5/skk This one's clear, but I now noticed that fcitx5-skk places a file in %{_libdir}/fcitx5/qt5/, but doesn't call for any of the fcitx5-qt SO libs. It needs a Requires line for fcitx5-qt, therefore: Requires: fcitx5-qt
(In reply to Andy Mender from comment #3) > > fixed by adding > > %dir %{_datadir}/fcitx5/skk > > This one's clear, but I now noticed that fcitx5-skk places a file in > %{_libdir}/fcitx5/qt5/, but doesn't call for any of the fcitx5-qt SO libs. > It needs a Requires line for fcitx5-qt, therefore: > Requires: fcitx5-qt [yan@BOOK-KARUBONIRU yanqi]$ sudo dnf repoquery --requires fcitx5-skk-0:0-0.2.git02fb41d.fc34.x86_64 上次元数据过期检查：4:36:45 前，执行于 2020年08月23日 星期日 17时54分35秒。 fcitx5 hicolor-icon-theme libFcitx5Config.so.6()(64bit) libFcitx5Core.so.6()(64bit) libFcitx5Qt5WidgetsAddons.so.2()(64bit) libFcitx5Utils.so.2()(64bit) libQt5Core.so.5()(64bit) libQt5Core.so.5(Qt_5)(64bit) libQt5Core.so.5(Qt_5.14)(64bit) libQt5Gui.so.5()(64bit) libQt5Gui.so.5(Qt_5)(64bit) libQt5Widgets.so.5()(64bit) libQt5Widgets.so.5(Qt_5)(64bit) libc.so.6(GLIBC_2.14)(64bit) libgcc_s.so.1()(64bit) libgcc_s.so.1(GCC_3.0)(64bit) libgcc_s.so.1(GCC_3.3.1)(64bit) libglib-2.0.so.0()(64bit) libgobject-2.0.so.0()(64bit) libskk.so.0()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(CXXABI_1.3.9)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) libstdc++.so.6(GLIBCXX_3.4.14)(64bit) libstdc++.so.6(GLIBCXX_3.4.20)(64bit) libstdc++.so.6(GLIBCXX_3.4.21)(64bit) libstdc++.so.6(GLIBCXX_3.4.9)(64bit) rtld(GNU_HASH) skkdic ---------------- We have libFcitx5Qt5WidgetsAddons.so.2()(64bit) here.
Good catch! Approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fcitx5-skk
Built in rawhide