+++ This bug was initially created as a clone of Bug #1875180 +++ +++ This bug was initially created as a clone of Bug #1875179 +++ Description of problem: when a ctrcfg is applied, the resulting configuration has unintended changes. The most notable is the value of `default_env` becomes empty. The others (all containers/storage parameters) can be empty, because of the way crio mixes crio.conf and storage.conf. However, the default_env being empty can cause regressions in nss db. Version-Release number of selected component (if applicable): 4.4 and 4.3 How reproducible: Steps to Reproduce: 1. run `crio config` on a node 2. apply any ctrcfg 3. run `crio config` on a node, and observe the difference Actual results: the field ``` default_env = [ "NSS_SDB_USE_CACHE=no", ] ``` is now ``` default_env = [ ] ``` Expected results: default_env should not have been emptied Additional info: --- Additional comment from Peter Hunt on 2020-09-02 23:57:15 UTC --- This comes from the vendored version of cri-o becoming out of sync with the version of cri-o in openshift. When we make a change in the configuration values, we need to update the vendor. From my testing, this is no longer the case in 4.6, as it has a vendored version of cri-o that contains default_env --- Additional comment from Peter Hunt on 2020-09-02 23:58:42 UTC --- this is also fixed in 4.5 for the same reason as above
this will be fixed in the attached PR
PR is awaiting approval
the pr is awaiting approval still
Pr is still awaiting approval
After talking with Mrunal and Urvashi, we have decided the priority should be higher for this. If we lose the NSS_SDB_USE_CACHE value, it can cause node instability.
hit some test issues, need to investigate if it's the result of the PR or just in general