Note: This bug is displayed in read-only format because the product is no longer active in Red Hat Bugzilla.

Bug 1878191

Summary: [RFE] Add PluginInstanceFormat to puppet-collectd
Product: Red Hat OpenStack Reporter: Leif Madsen <lmadsen>
Component: puppet-collectdAssignee: Leif Madsen <lmadsen>
Status: CLOSED ERRATA QA Contact: Leonid Natapov <lnatapov>
Severity: high Docs Contact:
Priority: medium    
Version: 16.1 (Train)CC: dcadzow, igallagh, jbadiapa, jjoyce, joflynn, jschluet, lars, mmagr, mrunge, pkilambi, pleimer, rmccabe, slinaber, spower, sputhenp, tvignaud, yocha
Target Milestone: z4Keywords: FutureFeature, Triaged
Target Release: 16.1 (Train on RHEL 8.2)   
Hardware: Unspecified   
OS: Unspecified   
Whiteboard:
Fixed In Version: puppet-collectd-12.0.1-2.20201113222723.el8ost Doc Type: Enhancement
Doc Text:
With this enhancement, you can configure the format of the plugin instance for the collectd virt plugin by using the `ExtraConfig` parameter `collectd::plugin::virt::plugin_instance_format`. This allows more granular metadata to be exposed in the metrics label for virtual machine instances, such as on which host the instance is running.
Story Points: ---
Clone Of: Environment:
Last Closed: 2021-03-17 15:31:57 UTC Type: Bug
Regression: --- Mount Type: ---
Documentation: --- CRM:
Verified Versions: Category: ---
oVirt Team: --- RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: --- Target Upstream Version:
Embargoed:
Bug Depends On:    
Bug Blocks: 1916149    

Description Leif Madsen 2020-09-11 14:47:32 UTC
Currently it is not possible to specify the PluginInstanceFormat parameter to the collectd virt plugin, which would allow knowing the available instance (virtual machines) UUID, name, metadata, etc.

Comment 3 Leif Madsen 2020-09-18 18:59:49 UTC
This is merged upstream, and ready for import. PR is linked.

Comment 4 Leif Madsen 2020-09-19 17:08:51 UTC
Released upstream in puppet-collectd 12.1.0.

Comment 5 Leif Madsen 2020-09-19 17:09:35 UTC
Oops, released upstream puppet-collectd 12.2.0.

Comment 14 Matthias Runge 2020-12-14 08:46:58 UTC
*** Bug 1907285 has been marked as a duplicate of this bug. ***

Comment 15 spower 2021-01-06 15:01:18 UTC
Exception + flag given

Comment 16 Leif Madsen 2021-01-11 20:19:03 UTC
Testing should be as simple as adding the collectd::plugin::virt::plugin_instance_format configuration to the ExtraConfig of the stf-connections.yaml file.

```
ExtraConfig:
    collectd::plugin::virt::plugin_instance_format: name
```

Values that are valid:

- name
- uuid
- metadata

Once enabled and deployed look at the collectd_virt module in Prometheus and note that the `plugin_instance` label for returned values is no longer `base` but should be name of the virtual machine or similar.

A virtual machine must be created on the OpenStack project for any statistics to be returned. (Run InfraRed workload plugin or otherwise.)

Comment 22 Leonid Natapov 2021-01-27 21:12:53 UTC
collectd_virt_if_packets_rx_total{endpoint="prom-http",host="instance-00000005:StfInstance:a48dcb79-deb5-4844-8bd7-89d5b0b7ed2a",plugin_instance="instance-00000005",service="default-cloud1-coll-meter-smartgateway",type_instance="tap10491ab2-2b"}

Comment 28 errata-xmlrpc 2021-03-17 15:31:57 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Red Hat OpenStack Platform 16.1.4 director bug fix advisory), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:0817