Bug 1907285

Description of problem:

- Want to set "PluginInstanceFormat" parameter for collectd virt plugin through puppet.



Version-Release number of selected component (if applicable):
 -RHOSP16.1

[root@controller-0 plugin]# rpm -qa |grep puppet-collectd
puppet-collectd-12.0.1-1.20200821073807.4686e16.el8ost.noarch


Actual results:

# cat /etc/puppet/modules/collectd/manifests/plugin/virt.pp 
# https://collectd.org/wiki/index.php/Plugin:virt
class collectd::plugin::virt (
  String $connection,
  $ensure                                      = 'present',
  $manage_package                              = undef,
  Optional[Pattern[/^\d+$/]] $refresh_interval = undef,
  Optional[String] $domain                     = undef,
  Optional[String] $block_device               = undef,
  Optional[String]$interface_device            = undef,
  Optional[Boolean] $ignore_selected           = undef,
  Optional[String] $hostname_format            = undef,
  Optional[String] $interface_format           = undef,
  Optional[String] $extra_stats                = undef,
  $interval                                    = undef,
) {

  include collectd

  $_manage_package = pick($manage_package, $collectd::manage_package)

  if $facts['os']['family'] == 'RedHat' {
    if $_manage_package {
      package { 'collectd-virt':
        ensure => $ensure,
      }
    }
  }

  if versioncmp("${collectd::collectd_version_real}", '5.5') >= 0 { # lint:ignore:only_variable_string
    $plugin_name = 'virt'
  } else {
    $plugin_name = 'libvirt'
  }

  collectd::plugin { 'virt':
    ensure   => $ensure,
    name     => $plugin_name,
    content  => template('collectd/plugin/virt.conf.erb'),
    interval => $interval,
  }
}


Expected results:
 Adding "Plugin Instance Format" parameter to set it through puppet.

Additional info:


collected data was seen like below when set only 
~~~
HostnameFormat "hostname", "uuid "
~~~~

collectd_virt_virt_cpu_total_total{host="<Compute Node Name>:<UUID>"}


It changed when When set "PluginInstanceFormat" 
~~~
HostnameFormat "hostname"
 PluginInstanceFormat "uuid"
~~~

collectd_virt_virt_cpu_total_total{host="<Compute Node Name>", instance="<UUID>"}

It made to easy see instances in each compute nodes when integrate with Granada and Prometheus.
so The Customer is using added it manually.
But they wanted to set it through puppet to make easier in operating perspective.