Bug 188496 - Review Request: PyQt-qscintilla
Review Request: PyQt-qscintilla
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
Depends On:
Blocks: FE-ACCEPT 186919
  Show dependency treegraph
Reported: 2006-04-10 13:16 EDT by Rex Dieter
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-06-15 16:56:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---

Attachments (Terms of Use)

  None (edit)
Description Rex Dieter 2006-04-10 13:16:26 EDT
Spec Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/SPECS/PyQt-qscintilla-3.15-1.spec
SRPM Name or Url: http://kde-redhat.unl.edu/apt/kde-redhat/all/SRPMS.stable/PyQt-qscintilla-3.15-1.src.rpm
PyQt qscintilla extentions.
Comment 1 Jason Tibbitts 2006-04-29 00:26:32 EDT
Just took a quick look but I can't fetch the upstream source.  It looks like
they don't distribute 3.15 any longer.

Now, if I understand things, this is just building some extra files that aren't
included in the Core PyQt package.  (They couldn't be; qscintilla is in Extras.)
 So the version of PyQt used here has to be exactly the same as the version that
Core used for their packages.  If so then we'll have to make an exception for
the need for upstream sources.

Just for grins I tried to build in rawhide; the build fails in configure.py.  It
builds fine on FC5 x86_64 (in mock).
Comment 2 Rex Dieter 2006-04-30 14:26:21 EDT
We can/will just use the same source redhat/fedora(core) does when building

Re: rawhide breakage
That's ok, rawhide was upgraded to PyQt-3.16 recently anyway.  

Whoever wants to review this can do so against the FC-5 package here, or I can
make a rawhide one for PyQt-3.16 too.  (I'll have to do that eventually anyway).
Comment 3 Jason Tibbitts 2006-06-03 22:44:21 EDT
I'l go ahead and review the FC5 version.  I can't compare against the upstream
source since it doesn't exist any longer, but I can compare against what's in
Red Hat's lookaside store from the FC5 PyQt package which seems good enough.

This package places various files in /usr/share/sip/qtext, which seems odd as
that name looks to be unrelated to the package.  Plus, nothing seems to own
/usr/share/sip.  I guess those files are the SIP-generated bindings, but the
directory ownership is still an issue.

The -debuginfo package is empty.  It looks like the makefile strips the library,
which it shouldn't be doing:

make: Entering directory `/builddir/build/BUILD/PyQt-x11-gpl-3.15/qtext'
cp -f qtext.so

The Makefile is generated, and I don't really know enough about what's generated
to know how to convince it not to strip the library. 

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written and uses macros consistently.
* dist tag is present.
* build root is correct.
* license field matches the actual license.
* license is open source-compatible.  License text included in package.
* source files match upstream (or at least Core's cache):
   8e70fac4f403fb759b537008170ff446  PyQt-x11-gpl-3.15.tar.gz
   8e70fac4f403fb759b537008170ff446  PyQt-x11-gpl-3.15.tar.gz-srpm
O 3.15 is not the latest version, but it must match what's in each particular FC
* BuildRequires are proper.
* package builds in mock (FC5, x86_64).
* rpmlint is silent.
* final provides and requires are sane:
   PyQt-qscintilla = 3.15-1.fc5
   PyQt = 3.15
   python(abi) = 2.4
   python-abi = 2.4
* shared libraries are present, internal to Python.
* package is not relocatable.
X owns the directories it creates (/usr/share/sip)
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is not present; no test suite upstream.
* no scriptlets present.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.
Comment 4 Rex Dieter 2006-06-05 08:07:03 EDT
I'll if I can convince 'make install' to not strip the library...

Re: /usr/share/sip/qtext
IMO, sip should own /usr/share/sip, but I suppose we'll mark that as owned 
here until/if that happens.
Comment 5 Jason Tibbitts 2006-06-14 19:48:11 EDT
Any progress with this?  I haven't had any luck figuring out where the strip
comes from.  It might be in /usr/lib64/qt-3.3/mkspecs/linux-g++-64/qmake.conf. 
Oddly, it seems that linux-g++/qmake.conf has the strip call patched out, but
linux-g++-64/qmake.conf doesn't.  Indeed, running a build on i386 results in a
proper debuginfo package.

A bug in the core qt package, perhaps?
Comment 6 Paul F. Johnson 2006-06-14 19:59:17 EDT
Certainly looks like it.
Comment 7 Rex Dieter 2006-06-14 22:22:21 EDT
It's almost certainly a qt(qmake) bug, but I'm at a loss as to how to workaround
it here.  As Jason pointed out, it appears to be limited to 64 bit platform(s).

I'll go file a bug against qt.  There's a chance we can't do anything about it here.
Comment 8 Jason Tibbitts 2006-06-14 22:42:48 EDT
At this point since it's obviously not a problem with this package and since
this really doesn't affect the operation of the package, I'm content to approve
things as is (assuming you fix the /usr/share/sip ownership issue).  Hopefully
Core will fix the qt issue in time, but until then we don't lose anything except
a meaningful debuginfo package.

You might want to add a comment about it, and if you really feel daring you can
conditionalize the building of the -debuginfo package to disable it on x86_64. 
I'll leave that up to you.

APPROVED; just own /usr/share/sip when you check in (and probably file a bug
against the sip package as well.)
Comment 9 Rex Dieter 2006-06-14 22:55:07 EDT
FYI, Submitted bug #195410, "qt: 64bit platforms make useless -debuginfo rpms".

Thanks, I'll make sure to own /usr/share/sip.
Comment 10 Rex Dieter 2006-06-15 16:56:34 EDT
imported, built.

* Thu Jun 15 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.16-3
- devel/fc6 branch uses PyQt-3.16

* Thu Jun 15 2006 Rex Dieter <rexdieter[AT]users.sf.net> 3.15-2
- own %%_datadir/sip

Note You need to log in before you can comment on or make changes to this bug.