SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent-0-0.1.20201009git5dd505f.fc32.src.rpm Description: Libtraceevent is a library to parse raw trace event formats. Fedora Account System Username: zsun Notes: [ ]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/traceevent(trace-cmd-devel), /usr/lib64/traceevent(perf, trace-cmd-libs), /usr/lib64/traceevent/plugins(perf, trace-cmd-libs) This is intended. The aim of the upstream traceevent is to make this a shared library to be consumed by perf, trace-cmd and others. I'm also the trace-cmd packager and working on solving the dependency after this library is in Fedora. The perf part will be ready when it's done in upstream kernel repo. [ ]: SourceX tarball generation or download is documented. Note: Package contains tarball without URL, check comments Upstream do not provide tag or tarballs yet. I do have a comment on how to generate the tarball. Once upstream have a tag I'll switch to use the tag. RPMlint: libtraceevent.x86_64: E: no-ldconfig-symlink /usr/lib64/libtraceevent.so.1.1.0 libtraceevent-devel.x86_64: W: no-documentation libtraceevent-devel.x86_64: W: dangling-relative-symlink /usr/lib64/libtraceevent.so.1 libtraceevent.so.1.1.0 I'm trying to follow the way glibc separates package, so the real file stays in libtraceevent while symlink goes to -devel. If this is not the suggested way, I'd like to know the proper way for it. Various "shared-lib-without-dependency-information" I did not find any information for this in the wiki. So if this need to be fixed, I'd like to learn about the suggested fix.
Updated because upstream tagged with version. SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent-1.1.0-1.fc32.src.rpm
> [ ]: Package does not own files or directories owned by other packages. > Note: Dirs in package are owned also by: > /usr/include/traceevent(trace-cmd-devel), /usr/lib64/traceevent(perf, > trace-cmd-libs), /usr/lib64/traceevent/plugins(perf, trace-cmd-libs) > > This is intended. The aim of the upstream traceevent is to make this a > shared library to be consumed by perf, trace-cmd and others. I'm also the > trace-cmd packager and working on solving the dependency after this library > is in Fedora. The perf part will be ready when it's done in upstream kernel > repo. so what's the plan in here? start with libtracevent and perf as conflict packages and then remove those plugins from perf rpm? if that's the plan maybe we could ake this conflict explicit, I think there's 'Conflicts:' for that other note: - package version and the library version do not match, %{_libdir}/libtraceevent.so.1.1.0 vs Version: 0 Release: 0.1.%{commitdate}git%{shortcommit}%{?dist} might be good to put version values to variables, so you'll update only one place during the rpm update jirka
(In reply to Jiri Olsa from comment #2) > > [ ]: Package does not own files or directories owned by other packages. > > Note: Dirs in package are owned also by: > > /usr/include/traceevent(trace-cmd-devel), /usr/lib64/traceevent(perf, > > trace-cmd-libs), /usr/lib64/traceevent/plugins(perf, trace-cmd-libs) > > > > This is intended. The aim of the upstream traceevent is to make this a > > shared library to be consumed by perf, trace-cmd and others. I'm also the > > trace-cmd packager and working on solving the dependency after this library > > is in Fedora. The perf part will be ready when it's done in upstream kernel > > repo. > > so what's the plan in here? > start with libtracevent and perf as conflict packages > and then remove those plugins from perf rpm? > > if that's the plan maybe we could ake this conflict > explicit, I think there's 'Conflicts:' for that > Hi Jiri, Do you happen to know the plan of perf consuming libtraceevent upstream? If there is a clear plan I think it worth mark a conflict with version requirement. Otherwise I can add a general "Conflicts: perf" in the spec file. > > other note: > > - package version and the library version do not match, > %{_libdir}/libtraceevent.so.1.1.0 > vs > Version: 0 > Release: 0.1.%{commitdate}git%{shortcommit}%{?dist} > > might be good to put version values to variables, > so you'll update only one place during the rpm update > Ok, sure. While I think this is from the SRPM in comment 0. The version should be in-sync in the version in comment 1 already. I've updated both in-place without bump the release. SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent-1.1.0-1.fc34.src.rpm
(In reply to Zamir SUN from comment #3) > (In reply to Jiri Olsa from comment #2) > > > [ ]: Package does not own files or directories owned by other packages. > > > Note: Dirs in package are owned also by: > > > /usr/include/traceevent(trace-cmd-devel), /usr/lib64/traceevent(perf, > > > trace-cmd-libs), /usr/lib64/traceevent/plugins(perf, trace-cmd-libs) > > > > > > This is intended. The aim of the upstream traceevent is to make this a > > > shared library to be consumed by perf, trace-cmd and others. I'm also the > > > trace-cmd packager and working on solving the dependency after this library > > > is in Fedora. The perf part will be ready when it's done in upstream kernel > > > repo. > > > > so what's the plan in here? > > start with libtracevent and perf as conflict packages > > and then remove those plugins from perf rpm? > > > > if that's the plan maybe we could ake this conflict > > explicit, I think there's 'Conflicts:' for that > > > > Hi Jiri, > > Do you happen to know the plan of perf consuming libtraceevent upstream? If > there is a clear plan I think it worth mark a conflict with version > requirement. Otherwise I can add a general "Conflicts: perf" in the spec > file. I think general conflict is ok for now, once there's rpm we can add perf's support to dynamically link libtraceevent and use libtraceevent's plugins and remove the Conflict then > > > > > other note: > > > > - package version and the library version do not match, > > %{_libdir}/libtraceevent.so.1.1.0 > > vs > > Version: 0 > > Release: 0.1.%{commitdate}git%{shortcommit}%{?dist} > > > > might be good to put version values to variables, > > so you'll update only one place during the rpm update > > > > Ok, sure. While I think this is from the SRPM in comment 0. The version > should be in-sync in the version in comment 1 already. > > I've updated both in-place without bump the release. > > SPEC URL: > https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent.spec > SRPM URL: > https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent-1.1.0-1. > fc34.src.rpm ok, looks good jirka
(In reply to Zamir SUN from comment #0) > RPMlint: > > libtraceevent.x86_64: E: no-ldconfig-symlink > /usr/lib64/libtraceevent.so.1.1.0 > libtraceevent-devel.x86_64: W: no-documentation > libtraceevent-devel.x86_64: W: dangling-relative-symlink > /usr/lib64/libtraceevent.so.1 libtraceevent.so.1.1.0 > > I'm trying to follow the way glibc separates package, so the real file stays > in libtraceevent while symlink goes to -devel. If this is not the suggested > way, I'd like to know the proper way for it. It's not a matter of real file vs symlink, it's a matter of versioned / unversioned shared libraries. The versioned libraries, against which programs are linked, belong to the main package. The unversioned libraries (as well as static libraries) belong to the devel package, because they are only needed when compiling. There is more info in the packaging guidelines: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_devel_packages So your %files section should contain %{_libdir}/libtraceevent.so.* and the "%files devel" section should contain %{_libdir}/libtraceevent.so Beside that, I didn't see anything wrong with the current spec file. I'm no packaging expert though.
- %{_libdir}/libtraceevent.so.1 Should be in main package - You should glob the extension as compression may change in the future: %{_mandir}/man3/tep_*.3.* %{_mandir}/man3/libtraceevent.3.* %{_mandir}/man3/trace_seq*.3.* - %dir %{_includedir}/traceevent %{_includedir}/traceevent/* → %{_includedir}/traceevent/
Thanks all for your reviews. Updated in-place SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent-1.1.0-1.fc34.src.rpm
- Consider filtering out /usr/lib64/traceevent/plugins/*.so from autoprov? see: https://docs.fedoraproject.org/en-US/packaging-guidelines/AutoProvidesAndRequiresFiltering/ - install license file via %license LICENSES/LGPL-2.1 - upstream provides multiple licenses, should we include both here? - seems that upstream is doing some weird dynamic linking things, while as a plugin for other programs, I think the caller should handle this? shared-lib-without-dependency-information and undefined-non-weak-symbol is strange, but will be fine as long as it will work. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. Should filter out those plugins from autoprovides. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* [generated file]", "*No copyright* GNU Lesser General Public License, Version 2.1". 44 files have unknown license. Detailed output of licensecheck in /home/yan/review/1887470-libtraceevent/licensecheck.txt [!]: License file installed when any subpackage combination is installed. Please include license files. [-]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/traceevent(trace-cmd-devel), /usr/lib64/traceevent(trace- cmd-libs, perf), /usr/lib64/traceevent/plugins(perf) Packager will solve this in other package. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [-]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [ ]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [?]: Final provides and requires are sane (see attachments). It would be better to filter out those plugins [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [ ]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libtraceevent-1.1.0-1.fc34.x86_64.rpm libtraceevent-devel-1.1.0-1.fc34.x86_64.rpm libtraceevent-debuginfo-1.1.0-1.fc34.x86_64.rpm libtraceevent-debugsource-1.1.0-1.fc34.x86_64.rpm libtraceevent-1.1.0-1.fc34.src.rpm libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_cfg80211.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_futex.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_hrtimer.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_jbd2.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_kmem.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_sched_switch.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_scsi.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_tlb.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_xen.so libtraceevent-devel.x86_64: W: no-documentation 5 packages and 0 specfiles checked; 9 errors, 1 warnings. Rpmlint (debuginfo) ------------------- Checking: libtraceevent-debuginfo-1.1.0-1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- libtraceevent.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtraceevent.so.1.1.0 dlopen libtraceevent.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtraceevent.so.1.1.0 dlclose libtraceevent.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtraceevent.so.1.1.0 dlerror libtraceevent.x86_64: W: undefined-non-weak-symbol /usr/lib64/libtraceevent.so.1.1.0 dlsym libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_cfg80211.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_futex.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_hrtimer.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_jbd2.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_kmem.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_sched_switch.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_scsi.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_tlb.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_xen.so libtraceevent-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 9 errors, 5 warnings. Unversioned so-files -------------------- libtraceevent: /usr/lib64/traceevent/plugins/plugin_cfg80211.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_function.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_futex.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_hrtimer.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_jbd2.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_kmem.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_kvm.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_mac80211.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_sched_switch.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_scsi.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_tlb.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_xen.so Source checksums ---------------- https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/snapshot/libtraceevent-1.1.0.tar.gz : CHECKSUM(SHA256) this package : 6b353a46e5fabb7159e7e7f2680b0e8f50feca84f57629e94bf56ff4d3f939d1 CHECKSUM(SHA256) upstream package : 6b353a46e5fabb7159e7e7f2680b0e8f50feca84f57629e94bf56ff4d3f939d1 Requires -------- libtraceevent (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) libtraceevent-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libtraceevent(x86-64) libtraceevent.so.1()(64bit) libtraceevent-debuginfo (rpmlib, GLIBC filtered): libtraceevent-debugsource (rpmlib, GLIBC filtered): Provides -------- libtraceevent: libtraceevent libtraceevent(x86-64) libtraceevent.so.1()(64bit) libtraceevent-devel: libtraceevent-devel libtraceevent-devel(x86-64) pkgconfig(libtraceevent) libtraceevent-debuginfo: debuginfo(build-id) libtraceevent-debuginfo libtraceevent-debuginfo(x86-64) libtraceevent-debugsource: libtraceevent-debugsource libtraceevent-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1887470 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Java, R, Perl, PHP, Python, SugarActivity, Haskell, fonts, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
And forget to mention another thing, upstream are using LGPLv2+ or GPLv2+ see https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/tree/LICENSES/LGPL-2.1 https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/tree/LICENSES/GPL-2.0
Thanks for the review. I've been really busy recently and only be able to update it today. SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/libtraceevent/libtraceevent-1.1.1-1.fc33.src.rpm
Package Approved. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: Development (unversioned) .so files in -devel subpackage, if present. Note: Unversioned so-files in private %_libdir subdirectory (see attachment). Verify they are not in ld path. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* GNU Lesser General Public License, Version 2.1", "GNU General Public License, Version 2", "GNU Lesser General Public License, Version 2.1". 48 files have unknown license. Detailed output of licensecheck in /home/yan/review/1887470-libtraceevent/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/traceevent(trace-cmd-devel), /usr/lib64/traceevent(trace- cmd-libs, perf), /usr/lib64/traceevent/plugins(perf) submitter will fix those in other packages [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. explict conflict will be removed [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 860160 bytes in 32 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. Note: Arch-ed rpms have a total of 1064960 bytes in /usr/share [x]: Rpmlint is run on debuginfo package(s). Note: There are rpmlint messages (see attachment). [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libtraceevent-1.1.1-1.fc33.x86_64.rpm libtraceevent-devel-1.1.1-1.fc33.x86_64.rpm libtraceevent-debuginfo-1.1.1-1.fc33.x86_64.rpm libtraceevent-debugsource-1.1.1-1.fc33.x86_64.rpm libtraceevent-1.1.1-1.fc33.src.rpm libtraceevent.x86_64: W: invalid-license LGPLv2.1 libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_cfg80211.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_futex.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_hrtimer.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_jbd2.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_kmem.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_sched_switch.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_scsi.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_tlb.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_xen.so libtraceevent-devel.x86_64: W: invalid-license LGPLv2.1 libtraceevent-devel.x86_64: W: no-documentation libtraceevent-debuginfo.x86_64: W: invalid-license LGPLv2.1 libtraceevent-debugsource.x86_64: W: invalid-license LGPLv2.1 libtraceevent.src: W: invalid-license LGPLv2.1 5 packages and 0 specfiles checked; 9 errors, 6 warnings. Rpmlint (debuginfo) ------------------- Checking: libtraceevent-debuginfo-1.1.1-1.fc33.x86_64.rpm libtraceevent-debuginfo.x86_64: W: invalid-license LGPLv2.1 1 packages and 0 specfiles checked; 0 errors, 1 warnings. Rpmlint (installed packages) ---------------------------- libtraceevent-debugsource.x86_64: W: invalid-license LGPLv2.1 libtraceevent-debuginfo.x86_64: W: invalid-license LGPLv2.1 libtraceevent-devel.x86_64: W: invalid-license LGPLv2.1 libtraceevent-devel.x86_64: W: no-documentation libtraceevent.x86_64: W: invalid-license LGPLv2.1 libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_cfg80211.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_futex.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_hrtimer.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_jbd2.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_kmem.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_sched_switch.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_scsi.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_tlb.so libtraceevent.x86_64: E: shared-lib-without-dependency-information /usr/lib64/traceevent/plugins/plugin_xen.so 4 packages and 0 specfiles checked; 9 errors, 5 warnings. Unversioned so-files -------------------- libtraceevent: /usr/lib64/traceevent/plugins/plugin_cfg80211.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_function.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_futex.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_hrtimer.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_jbd2.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_kmem.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_kvm.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_mac80211.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_sched_switch.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_scsi.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_tlb.so libtraceevent: /usr/lib64/traceevent/plugins/plugin_xen.so Source checksums ---------------- https://git.kernel.org/pub/scm/libs/libtrace/libtraceevent.git/snapshot/libtraceevent-1.1.1.tar.gz : CHECKSUM(SHA256) this package : 78db6a3391d2973483ba18d49373b274391eb577259d53fbbb1cde0c235db333 CHECKSUM(SHA256) upstream package : 78db6a3391d2973483ba18d49373b274391eb577259d53fbbb1cde0c235db333 Requires -------- libtraceevent (rpmlib, GLIBC filtered): libc.so.6()(64bit) libdl.so.2()(64bit) rtld(GNU_HASH) libtraceevent-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config libtraceevent(x86-64) libtraceevent.so.1()(64bit) libtraceevent-debuginfo (rpmlib, GLIBC filtered): libtraceevent-debugsource (rpmlib, GLIBC filtered): Provides -------- libtraceevent: libtraceevent libtraceevent(x86-64) libtraceevent.so.1()(64bit) libtraceevent-devel: libtraceevent-devel libtraceevent-devel(x86-64) pkgconfig(libtraceevent) libtraceevent-debuginfo: debuginfo(build-id) libtraceevent-debuginfo libtraceevent-debuginfo(x86-64) libtraceevent-debugsource: libtraceevent-debugsource libtraceevent-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1887470 --mock-config fedora-33-x86_64 Buildroot used: fedora-33-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: R, Python, PHP, Perl, SugarActivity, fonts, Java, Ocaml, Haskell Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
And for the license entry, please use LGPLv2+ and GPLv2+
Thanks for the review! Fixing the assignee.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libtraceevent