SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/libtracefs/libtracefs.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/libtracefs/libtracefs-0-0.1.20201120git4f24f98.fc34.src.rpm Description: Libtracefs is a library for accessing kernel tracefs Fedora Account System Username: zsun Note: This has a build time dependency on libtraceevent, which is still under review in bug 1887470.
- Include an upstream license file via %license - Upstream git repo contains newer commit - /usr/lib64/tracefs/libtracefs.so.* is not in standard ldpath consider filtering out the library from autoprovides or adding /usr/lib64/tracefs to /etc/ld.so.conf.d/libtracefs.conf, this depends how libtracefs.so.* is going to be used (private or global) Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [!]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "*No copyright* [generated file]". 7 files have unknown license. Detailed output of licensecheck in /home/yan/review/1900720-libtracefs/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: Package does not own files or directories owned by other packages. Note: Dirs in package are owned also by: /usr/include/tracefs(trace- cmd-devel), /usr/lib64/tracefs(trace-cmd-libs) Packager will fix this later on. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [-]: Package does not generate any conflict. An intended conflictm, which will be fixed later by packager. [x]: Package obeys FHS, except libexecdir and /usr/target. [x]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [!]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 0 bytes in 0 files. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [?]: Package functions as described. [!]: Latest version is packaged. Upstream git contains newer commit [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [?]: Package should compile and build into binary rpms on all supported architectures. [-]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: libtracefs-0-0.1.20201120git4f24f98.fc34.x86_64.rpm libtracefs-devel-0-0.1.20201120git4f24f98.fc34.x86_64.rpm libtracefs-debuginfo-0-0.1.20201120git4f24f98.fc34.x86_64.rpm libtracefs-debugsource-0-0.1.20201120git4f24f98.fc34.x86_64.rpm libtracefs-0-0.1.20201120git4f24f98.fc34.src.rpm libtracefs.x86_64: W: no-documentation libtracefs-devel.x86_64: W: only-non-binary-in-usr-lib libtracefs-devel.x86_64: W: no-documentation libtracefs.src: W: spelling-error Summary(en_US) tracefs -> traces, tracers, trace's libtracefs.src: W: spelling-error %description -l en_US tracefs -> traces, tracers, trace's 5 packages and 0 specfiles checked; 0 errors, 5 warnings. Rpmlint (debuginfo) ------------------- Checking: libtracefs-debuginfo-0-0.1.20201120git4f24f98.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- libtracefs.x86_64: W: no-documentation libtracefs-devel.x86_64: W: only-non-binary-in-usr-lib libtracefs-devel.x86_64: W: no-documentation 4 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://git.kernel.org/pub/scm/libs/libtrace/libtracefs.git/snapshot/libtracefs-4f24f98960c223e56329519bb90a90f0b2ad813f.tar.gz : CHECKSUM(SHA256) this package : 373c2861b3d83d44fcc28540c3d25ab9f1eaeaf5e2c99c3312f4f48d95aefa4f CHECKSUM(SHA256) upstream package : 373c2861b3d83d44fcc28540c3d25ab9f1eaeaf5e2c99c3312f4f48d95aefa4f Requires -------- libtracefs (rpmlib, GLIBC filtered): libc.so.6()(64bit) rtld(GNU_HASH) libtracefs-devel (rpmlib, GLIBC filtered): libtracefs(x86-64) libtracefs.so.0.1.0()(64bit) libtracefs-debuginfo (rpmlib, GLIBC filtered): libtracefs-debugsource (rpmlib, GLIBC filtered): Provides -------- libtracefs: libtracefs libtracefs(x86-64) libtracefs.so.0.1.0()(64bit) libtracefs-devel: libtracefs-devel libtracefs-devel(x86-64) libtracefs-debuginfo: debuginfo(build-id) libtracefs-debuginfo libtracefs-debuginfo(x86-64) libtracefs-debugsource: libtracefs-debugsource libtracefs-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1900720 -L ./rpms Buildroot used: fedora-rawhide-x86_64 Active plugins: C/C++, Shell-api, Generic Disabled plugins: R, Perl, Python, PHP, SugarActivity, Haskell, fonts, Java, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH Built with local dependencies: /home/yan/review/./rpms/libtraceevent-1.1.0-1.fc34.x86_64.rpm /home/yan/review/./rpms/libtraceevent-devel-1.1.0-1.fc34.x86_64.rpm
And upstream license should LGPLv2+ or GPLv2+
Thanks for the review. Upstream did this in another way - they finally moved the library to %{_libdir} For the conflicts, they are intended. They will be fixed once perf and trace-cmd are both ready. But I believe with the current version, there shouldn't be any conflicting dir now. SPEC URL: https://download.copr.fedorainfracloud.org/results/zsun/test/fedora-rawhide-x86_64/01953952-libtracefs/libtracefs.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/zsun/test/fedora-rawhide-x86_64/01953952-libtracefs/libtracefs-1.0.2-1.fc34.src.rpm
- License should be: License: LGPLv2+ and GPLv2+ - There's an extra install here: %make_install prefix=%{_prefix} libdir=%{_libdir} install - Make has been removed from the default buildroot so you need to add it as a BR now: BuildRequires: make
Thanks for the review. Fixed the issues mentioned in comment 4. Also disabled LTO due to compiling issue. SPEC URL: https://zsun.fedorapeople.org/pub/pkgs/libtracefs/libtracefs.spec SRPM URL: https://zsun.fedorapeople.org/pub/pkgs/libtracefs/libtracefs-1.0.2-1.fc33.src.rpm
Scratch build https://koji.fedoraproject.org/koji/taskinfo?taskID=63553361
Package approved.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/libtracefs
https://koji.fedoraproject.org/koji/buildinfo?buildID=1728704