Bug 189081 - Review Request: perl-Test-Prereq
Review Request: perl-Test-Prereq
Status: CLOSED NEXTRELEASE
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
rawhide
All Linux
medium Severity medium
: ---
: ---
Assigned To: Jason Tibbitts
Fedora Package Reviews List
:
Depends On: 189080
Blocks: FE-ACCEPT 189084
  Show dependency treegraph
 
Reported: 2006-04-15 14:07 EDT by Steven Pritchard
Modified: 2007-11-30 17:11 EST (History)
0 users

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Environment:
Last Closed: 2006-05-07 16:47:34 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
CRM:
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---


Attachments (Terms of Use)

  None (edit)
Description Steven Pritchard 2006-04-15 14:07:45 EDT
Spec URL: http://ftp.kspei.com/pub/steve/rpms/perl-Test-Prereq/perl-Test-Prereq.spec
SRPM URL: http://ftp.kspei.com/pub/steve/rpms/perl-Test-Prereq-1.030-1.src.rpm
Description:
The prereq_ok() function examines the modules it finds in blib/lib/,
blib/script, and the test files it finds in t/ (and test.pl). It figures
out which modules they use, skips the modules that are in the Perl core,
and compares the remaining list of modules to those in the PREREQ_PM
section of Makefile.PL.
Comment 1 Jason Tibbitts 2006-04-22 23:35:10 EDT
I'm assuming perl-Module-Info will be approved, so I'll go ahead and review this.

* package meets naming and packaging guidelines.
* specfile is properly named, is cleanly written, uses macros consistently and
conforms to the Perl template.
* license field matches the actual license.
* license is open source-compatible.  It's not included separately in the
package, but this is not necessary as the upstream tarball does not include it.
* source files match upstream:
   9acb4eb0737bb041e9ece8ad08e127c3  Test-Prereq-1.030.tar.gz
   9acb4eb0737bb041e9ece8ad08e127c3  Test-Prereq-1.030.tar.gz-srpm
* BuildRequires are proper.
* package builds in mock (development, i386).
* rpmlint is silent.
* final provides and requires are sane.
* no shared libraries are present.
* package is not relocatable.
* owns the directory it creates.
* doesn't own any directories it shouldn't.
* no duplicates in %files.
* file permissions are appropriate.
* %clean is present.
* %check is present but necessarily disabled.
* code, not content.
* documentation is small, so no -docs subpackage is necessary.
* %docs are not necessary for the proper functioning of the package.
* no headers.
* no pkgconfig files.
* no libtool .la droppings.
* not a GUI app.

APPROVED.
Comment 2 Steven Pritchard 2006-05-07 16:47:34 EDT
Imported into CVS, branches created, and builds requested.

Note You need to log in before you can comment on or make changes to this bug.