Bug 1892724 - VFS added to the list of devices of the nodeptpdevice CRD
Summary: VFS added to the list of devices of the nodeptpdevice CRD
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: OpenShift Container Platform
Classification: Red Hat
Component: Networking
Version: 4.7
Hardware: Unspecified
OS: Unspecified
unspecified
medium
Target Milestone: ---
: 4.7.0
Assignee: Federico Paolinelli
QA Contact: huirwang
URL:
Whiteboard:
Depends On:
Blocks: 1933629
TreeView+ depends on / blocked
 
Reported: 2020-10-29 14:19 UTC by Federico Paolinelli
Modified: 2021-03-01 10:13 UTC (History)
1 user (show)

Fixed In Version:
Doc Type: No Doc Update
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-02-24 15:29:18 UTC
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github openshift linuxptp-daemon pull 24 0 None closed Bug 1892724: Always replace the list of devices instead of appending. 2021-01-08 09:38:35 UTC
Red Hat Product Errata RHSA-2020:5633 0 None None None 2021-02-24 15:29:47 UTC

Description Federico Paolinelli 2020-10-29 14:19:17 UTC
Description of problem:

It happened sporadically in our CI, but what I am seeing is a vf sneaking in the list of devices in the nodeptpdevice CRD.




How reproducible:
Flaky

Actual results:


Expected results:


Additional info:

Looking at the code, the ptp daemon loops and always fetches the list of devices and appends new ones, so I suspect there's a race if the daemon checks for the devices when the vfs are getting created (maybe the link is already created, but not the physfn link?).

Once this happens, the device is never removed from the list because of the append mechanism.

Comment 7 errata-xmlrpc 2021-02-24 15:29:18 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (Moderate: OpenShift Container Platform 4.7.0 security, bug fix, and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHSA-2020:5633


Note You need to log in before you can comment on or make changes to this bug.