Bug 1893729 - Review Request: perl-Gtk3-ImageView - Image viewer widget for GTK 3
Summary: Review Request: perl-Gtk3-ImageView - Image viewer widget for GTK 3
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1893477
TreeView+ depends on / blocked
 
Reported: 2020-11-02 13:22 UTC by Petr Pisar
Modified: 2021-09-03 00:30 UTC (History)
2 users (show)

Fixed In Version: perl-Gtk3-ImageView-4-1.fc34
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2020-11-03 14:30:04 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-11-02 13:22:56 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Gtk3-ImageView/perl-Gtk3-ImageView.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Gtk3-ImageView/perl-Gtk3-ImageView-4-1.fc34.src.rpm
Description:
The Gtk3::ImageView widget allows the user to zoom, pan and select the
specified image and provides hooks to allow additional tools, e.g. painter,
to be created and used.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-11-02 17:37:07 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Gtk3-ImageView-4-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(base)
      1 perl(Cairo)
      1 perl(Carp)
      1 perl(feature) 
      1 perl(Glib) >= 1.21
      1 perl(Glib::Object::Subclass)
      1 perl(Gtk3)
      1 perl(Gtk3::ImageView::Tool)
      1 perl(Gtk3::ImageView::Tool::Dragger)
      1 perl(Gtk3::ImageView::Tool::Selector)
      1 perl(if)
      1 perl(List::Util)
      1 perl(:MODULE_COMPAT_5.32.0)
      1 perl(POSIX)
      1 perl(Readonly)
      1 perl(Scalar::Util)
      1 perl(strict)
      1 perl(warnings)
Binary requires are Ok.

$ rpm -qp --provides perl-Gtk3-ImageView-4-1.fc34.noarch.rpm | sort | uniq -c
      1 perl(Gtk3::ImageView) = 4
      1 perl-Gtk3-ImageView = 4-1.fc34
      1 perl(Gtk3::ImageView::Tool) = 4
      1 perl(Gtk3::ImageView::Tool::Dragger) = 4
      1 perl(Gtk3::ImageView::Tool::Selector) = 4
      1 perl(Gtk3::ImageView::Tool::SelectorDragger) = 4
Binary provides are Ok.

$ rpmlint ./perl-Gtk3-ImageView*
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-11-03 14:15:02 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Gtk3-ImageView

Comment 4 Petr Pisar 2020-11-03 14:30:04 UTC
Thank you for the review and the repository.

Comment 5 Fedora Update System 2021-09-02 16:12:17 UTC
FEDORA-2021-ca032f0519 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ca032f0519

Comment 6 Fedora Update System 2021-09-02 16:12:20 UTC
FEDORA-2021-ca032f0519 has been submitted as an update to Fedora 33. https://bodhi.fedoraproject.org/updates/FEDORA-2021-ca032f0519

Comment 7 Fedora Update System 2021-09-03 00:30:52 UTC
FEDORA-2021-ca032f0519 has been pushed to the Fedora 33 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-ca032f0519`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-ca032f0519

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.


Note You need to log in before you can comment on or make changes to this bug.