Bug 1894633 - Review Request: perl-Image-PNG-Libpng - Perl interface to the libpng library
Summary: Review Request: perl-Image-PNG-Libpng - Perl interface to the libpng library
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: Jitka Plesnikova
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1894911
TreeView+ depends on / blocked
 
Reported: 2020-11-04 16:43 UTC by Petr Pisar
Modified: 2020-11-06 14:30 UTC (History)
2 users (show)

Fixed In Version: perl-Image-PNG-Libpng-0.47-1.fc34
Clone Of:
Environment:
Last Closed: 2020-11-06 14:30:43 UTC
Type: ---
Embargoed:
jplesnik: fedora-review+


Attachments (Terms of Use)

Description Petr Pisar 2020-11-04 16:43:05 UTC
Spec URL: https://ppisar.fedorapeople.org/perl-Image-PNG-Libpng/perl-Image-PNG-Libpng.spec
SRPM URL: https://ppisar.fedorapeople.org/perl-Image-PNG-Libpng/perl-Image-PNG-Libpng-0.47-1.fc34.src.rpm
Description:
Image::PNG::Libpng is a Perl library for accessing the contents of PNG
(Portable Network Graphics) images. It enables Perl to read and write files in
the PNG format.

Fedora Account System Username: ppisar

Comment 1 Jitka Plesnikova 2020-11-06 08:24:28 UTC
Source file is ok
Summary is ok
License is ok
Description is ok
URL and Source0 are ok
All tests passed
BuildRequires are ok

$ rpm -qp --requires perl-Image-PNG-Libpng-0.47-1.fc34.x86_64.rpm | sort | uniq -c | grep -v rpmlib
      1 libc.so.6()(64bit)
      1 libc.so.6(GLIBC_2.14)(64bit)
      1 libc.so.6(GLIBC_2.2.5)(64bit)
      1 libc.so.6(GLIBC_2.3.4)(64bit)
      1 libc.so.6(GLIBC_2.4)(64bit)
      1 libperl.so.5.32()(64bit)
      1 libpng16.so.16()(64bit)
      1 libpng16.so.16(PNG16_0)(64bit)
      1 libpthread.so.0()(64bit)
      1 libpthread.so.0(GLIBC_2.2.5)(64bit)
      1 perl(Carp)
      1 perl(constant)
      1 perl(Exporter)
      1 perl(Image::PNG::Const)
      1 perl(:MODULE_COMPAT_5.32.0) 
      1 perl(strict)
      1 perl(warnings) 
      1 perl(XSLoader)
      1 rtld(GNU_HASH)
$ rpm -qp --requires perl-Image-PNG-Libpng-tools-0.47-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib
      1 perl(Data::Dumper)
      1 perl(Image::PNG::Libpng) 
      1 perl-Image-PNG-Libpng = 0.47-1.fc34
      1 perl(strict)
      1 perl(warnings)
      1 /usr/bin/perl
Binary requires are Ok.

$ rpm -qp --provides perl-Image-PNG-Libpng-0.47-1.fc34.x86_64.rpm | sort | uniq -c
      1 perl(Image::PNG::Const) = 0.47
      1 perl(Image::PNG::Libpng) = 0.47
      1 perl-Image-PNG-Libpng = 0.47-1.fc34 
      1 perl-Image-PNG-Libpng(x86-64) = 0.47-1.fc34
$ rpm -qp --provides perl-Image-PNG-Libpng-tools-0.47-1.fc34.noarch.rpm | sort | uniq -c
      1 perl-Image-PNG-Libpng-tools = 0.47-1.fc34
Binary provides are Ok.

$ rpmlint ./perl-Image-PNG-Libpng*
3 packages and 1 specfiles checked; 0 errors, 0 warnings.
Rpmlint is ok

The package is in line with Fedora and Perl packaging guide lines.

Resolution:
Approved

Comment 3 Gwyn Ciesla 2020-11-06 14:18:22 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-Image-PNG-Libpng

Comment 4 Petr Pisar 2020-11-06 14:30:43 UTC
Thank you for the review and the repository.


Note You need to log in before you can comment on or make changes to this bug.