Spec URL: https://ppisar.fedorapeople.org/perl-PDF-Builder/perl-PDF-Builder.spec SRPM URL: https://ppisar.fedorapeople.org/perl-PDF-Builder/perl-PDF-Builder-3.019-1.fc34.src.rpm Description: This Perl library enables you to create, import and modify documents in Portagble Document Format (mostly compliant to PDF 1.4 version). Fedora Account System Username: ppisar
Source file is ok Summary is ok License FIX: Please check the license text in files * PDF-Builder-3.019/lib/PDF/Builder/Basic/PDF/*.pm They contains: # THIS IS A REUSED PERL MODULE, FOR PROPER LICENCING TERMS SEE BELOW: # # Copyright Martin Hosken <Martin_Hosken> # # No warranty or expression of effectiveness, least of all regarding # anyone's safety, is implied in this software or documentation. # # This specific module is licensed under the Perl Artistic License. * PDF-Builder-3.019/lib/PDF/Builder/Matrix.pm # This library is free software; you can redistribute it # and/or modify it under the same terms as Perl itself. Description is ok URL and Source0 are ok All tests passed BuildRequires are ok $ rpm -qp --requires perl-PDF-Builder-3.019-1.fc34.noarch.rpm | sort | uniq -c | grep -v rpmlib | grep -v PDF::Builder 1 perl(base) 1 perl(Carp) 1 perl(Compress::Zlib) >= 1 1 perl(constant) 1 perl(Encode) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(FileHandle) 1 perl(File::Temp) 1 perl(Font::TTF::Font) 1 perl(IO::File) 1 perl(List::Util) 1 perl(Math::Trig) 1 perl(:MODULE_COMPAT_5.32.0) 1 perl(POSIX) 1 perl(Scalar::Util) 1 perl(strict) 1 perl(Unicode::UCD) 1 perl(vars) 1 perl(warnings) Binary requires are Ok. $ rpm -qp --provides perl-PDF-Builder-3.019-1.fc34.noarch.rpm | sort | uniq -c I do not add long list of all provides. Binary provides are Ok. $ rpmlint ./perl-PDF-Builder* perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-PDF-Builder/examples/resources/pod2htmd.temp perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding /usr/share/doc/perl-PDF-Builder/examples/resources/sample.txt 2 packages and 1 specfiles checked; 0 errors, 2 warnings. FIX: Could it be fix? Or are the files valid examples? Otherwise the package is in line with Fedora and Perl packaging guide lines. Please correct 'FIX' items. Resolution: Approved
(In reply to Jitka Plesnikova from comment #1) > License > FIX: Please check the license text in files > * PDF-Builder-3.019/lib/PDF/Builder/Basic/PDF/*.pm > They contains: > # THIS IS A REUSED PERL MODULE, FOR PROPER LICENCING TERMS SEE BELOW: > # > # Copyright Martin Hosken <Martin_Hosken> > # > # No warranty or expression of effectiveness, least of all regarding > # anyone's safety, is implied in this software or documentation. > # > # This specific module is licensed under the Perl Artistic License. > This was forked from PDF-API2 and the same license notice is in your perl-PDF-API2-2.038 package. I will ask the original upstream. Hopefully he mentioned the same Perl. I will also notify the PDF-Builder forker because he's not aware about it. > * PDF-Builder-3.019/lib/PDF/Builder/Matrix.pm > # This library is free software; you can redistribute it > # and/or modify it under the same terms as Perl itself. > Good catch. I missed it. > $ rpmlint ./perl-PDF-Builder* > perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/perl-PDF-Builder/examples/resources/pod2htmd.temp > perl-PDF-Builder.noarch: W: wrong-file-end-of-line-encoding > /usr/share/doc/perl-PDF-Builder/examples/resources/sample.txt > 2 packages and 1 specfiles checked; 0 errors, 2 warnings. > FIX: Could it be fix? Or are the files valid examples? > I documented it in the spec file. Those are literal blobs to demonstrate that the code can deal with CR-LF end of lines. Thus I believe we should not patch them.
A request for clarifying the original PDF-API2 <https://rt.cpan.org/Ticket/Display.html?id=133691>.
I received a MIT license from the author of the Artistic-only code. This code can be now added to Fedora.
I need a new review because the review is older than 60 days: Spec URL: https://ppisar.fedorapeople.org/perl-PDF-Builder/perl-PDF-Builder.spec SRPM URL: https://ppisar.fedorapeople.org/perl-PDF-Builder/perl-PDF-Builder-3.019-2.fc34.src.rpm I kept the old sources and only clarified the license and corrected Image::PNG::Libpng usage to past the tests. This should make comparing against the original source package easy for you.
Updated package looks good to me. Approved
https://pagure.io/releng/fedora-scm-requests/issue/31971
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/perl-PDF-Builder
Thank you for the review and the repository.