Bug 1899466 - py-radix fails to build with Python 3.10: SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
Summary: py-radix fails to build with Python 3.10: SystemError: PY_SSIZE_T_CLEAN macro...
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: py-radix
Version: 35
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Kevin Fenzi
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard: AcceptedFreezeException
: 1968863 (view as bug list)
Depends On:
Blocks: PYTHON3.10 F35BetaFreezeException F35FTBFS F35FailsToInstall 1968840 F36FTBFS F36FailsToInstall
TreeView+ depends on / blocked
 
Reported: 2020-11-19 10:31 UTC by Tomáš Hrnčiar
Modified: 2021-09-07 19:07 UTC (History)
4 users (show)

Fixed In Version: py-radix-0.9.3-22.fc36 py-radix-0.9.3-22.fc35
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-09-07 19:07:11 UTC
Type: Bug
Embargoed:


Attachments (Terms of Use)


Links
System ID Private Priority Status Summary Last Updated
Github mjschultz py-radix issues 54 0 None None None 2021-08-23 11:22:08 UTC

Description Tomáš Hrnčiar 2020-11-19 10:31:38 UTC
py-radix fails to build with Python 3.10.0a2.

ERROR: test_14__packed_addresses4 (tests.test_regression.TestRadix)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/py-radix-0.9.3/tests/test_regression.py", line 201, in test_14__packed_addresses4
    node = tree.add(packed=p, masklen=26)
SystemError: more argument specifiers than keyword list entries (remaining format:'s#:add')

======================================================================
ERROR: test_15__packed_addresses6 (tests.test_regression.TestRadix)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/py-radix-0.9.3/tests/test_regression.py", line 212, in test_15__packed_addresses6
    node = tree.add(packed=p, masklen=108)
SystemError: more argument specifiers than keyword list entries (remaining format:'s#:add')

----------------------------------------------------------------------
Ran 39 tests in 0.340s

FAILED (errors=2)
Test failed: <unittest.runner.TextTestResult run=39 errors=2 failures=0>
error: Test failed: <unittest.runner.TextTestResult run=39 errors=2 failures=0>

For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01773017-py-radix/

For all our attempts to build py-radix with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/py-radix/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-02-09 15:26:04 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.

Comment 2 Miro Hrončok 2021-06-04 20:15:27 UTC
This is a mass-posted update. Sorry if it is not 100% accurate to this bugzilla.


The Python 3.10 rebuild is in progress in a Koji side tag. If you manage to fix the problem, please commit the fix in the rawhide branch, but don't build the package in regular rawhide.

You can either build the package in the side tag, with:

    $ fedpkg build --target=f35-python

Or you can the build and we will eventually build it for you.

Note that the rebuild is still in progress, so not all (build) dependencies of this package might be available right away.

Thanks.

See also https://fedoraproject.org/wiki/Changes/Python3.10

If you have general questions about the rebuild, please use this mailing list thread: https://lists.fedoraproject.org/archives/list/devel@lists.fedoraproject.org/thread/G47SGOYIQLRDTWGOSLSWERZSSHXDEDH5/

Comment 3 Miro Hrončok 2021-06-07 22:59:53 UTC
The f35-python side tag has been merged to Rawhide. From now on, build as you would normally build.

Comment 4 Miro Hrončok 2021-06-08 11:20:18 UTC
*** Bug 1968863 has been marked as a duplicate of this bug. ***

Comment 5 Miro Hrončok 2021-06-15 20:23:06 UTC
Hello,

This is the first reminder (step 3 from https://docs.fedoraproject.org/en-US/fesco/Fails_to_build_from_source_Fails_to_install/#_package_removal_for_long_standing_ftbfs_and_fti_bugs).

If you know about this problem and are planning on fixing it, please acknowledge so by setting the bug status to ASSIGNED. If you don't have time to maintain this package, consider orphaning it, so maintainers of dependent packages realize the problem.

Comment 6 Ben Cotton 2021-08-10 12:49:19 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 35 development cycle.
Changing version to 35.

Comment 7 Miro Hrončok 2021-08-23 11:22:09 UTC
The current failure is:

======================================================================
ERROR: test_14__packed_addresses4 (tests.test_regression.TestRadix)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/py-radix-0.9.3/tests/test_regression.py", line 201, in test_14__packed_addresses4
    node = tree.add(packed=p, masklen=26)
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
======================================================================
ERROR: test_15__packed_addresses6 (tests.test_regression.TestRadix)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/builddir/build/BUILD/py-radix-0.9.3/tests/test_regression.py", line 212, in test_15__packed_addresses6
    node = tree.add(packed=p, masklen=108)
SystemError: PY_SSIZE_T_CLEAN macro must be defined for '#' formats
----------------------------------------------------------------------
Ran 39 tests in 0.292s
FAILED (errors=2)


See https://docs.python.org/3.10/whatsnew/3.10.html#id2 https://bugs.python.org/issue40943

"""
The PY_SSIZE_T_CLEAN macro must now be defined to use PyArg_ParseTuple() and Py_BuildValue() formats which use #: es#, et#, s#, u#, y#, z#, U# and Z#. See Parsing arguments and building values and the PEP 353.
"""

Also: https://github.com/mjschultz/py-radix/issues/54

Comment 8 Miro Hrončok 2021-08-30 22:51:11 UTC
This blocks mirrormanager2.

Comment 9 Miro Hrončok 2021-08-30 23:05:06 UTC
https://src.fedoraproject.org/rpms/py-radix/pull-request/1
https://src.fedoraproject.org/rpms/py-radix/pull-request/2

Proposing a freeze exception as the package does not even install without it.

Comment 10 Fedora Update System 2021-09-01 22:51:33 UTC
FEDORA-2021-b5d8651eed has been pushed to the Fedora 36 stable repository.
If problem still persists, please make note of it in this bug report.

Comment 11 Fedora Update System 2021-09-01 22:51:47 UTC
FEDORA-2021-766121a38b has been submitted as an update to Fedora 35. https://bodhi.fedoraproject.org/updates/FEDORA-2021-766121a38b

Comment 12 Fedora Update System 2021-09-02 15:56:06 UTC
FEDORA-2021-766121a38b has been pushed to the Fedora 35 testing repository.
Soon you'll be able to install the update with the following command:
`sudo dnf upgrade --enablerepo=updates-testing --advisory=FEDORA-2021-766121a38b`
You can provide feedback for this update here: https://bodhi.fedoraproject.org/updates/FEDORA-2021-766121a38b

See also https://fedoraproject.org/wiki/QA:Updates_Testing for more information on how to test updates.

Comment 13 Adam Williamson 2021-09-06 15:08:12 UTC
+3 in https://pagure.io/fedora-qa/blocker-review/issue/421 , marking accepted.

Comment 14 Fedora Update System 2021-09-07 19:07:11 UTC
FEDORA-2021-766121a38b has been pushed to the Fedora 35 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.