Spec URL: http://www.usenix.org.uk/rpm/rust-pleaser.spec SRPM URL: http://www.usenix.org.uk/rpm/rust-pleaser-0.3.16-1.fc34.src.rpm Description: Please, a polite regex-first sudo alternative. Fedora Account System Username: eneville Requires sponsor.
- Not useful: [dependencies.chrono] -version = "0.4.11" +version = "0.4" - Why do you downgrade rpassword: [dependencies.rpassword] -version = "5.0.0" +version = "4.0" Add a comment above the patch explaining what you have changed. - You must include the license file with %license in %files devel
Hello, I believe the changes requested are now done in the following: Spec URL: http://www.usenix.org.uk/rpm/rust-pleaser.spec SRPM URL: http://www.usenix.org.uk/rpm/rust-pleaser-0.3.25-1.fc35.src.rpm Thanks for looking
- I believe the main binary package should include the license as well: %files -n %{crate} %doc README.md %license LICENSE %{_bindir}/please %{_bindir}/pleaseedit %{_mandir}/man1/please.1* %{_mandir}/man5/please.ini.5* %config(noreplace) /etc/pam.d/please %config(noreplace) /etc/pam.d/pleaseedit %endif - You didn't add a comment above the patch explaining what you have changed. # Patch for syslog dependency # - Bump syslog to 0.5 Patch0: pleaser-fix-metadata.diff You also need to link to the upstream PR you opened bumping the dependency.
Hello, thanks again for looking. I believe this is now amended and ready to review.
Package approved. You still need to find a sponsor as described here: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group
Sponsored.
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pleaser
Package is available in repositories, closing.