Bug 1901118 - Review Request: rust-pleaser - user execution with regex configuration
Summary: Review Request: rust-pleaser - user execution with regex configuration
Keywords:
Status: CLOSED CURRENTRELEASE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
unspecified
medium
Target Milestone: ---
Assignee: Robert-André Mauchin 🐧
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1901114 1901116
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-11-24 14:29 UTC by ed-fedora@s5h.net
Modified: 2022-05-24 12:34 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2022-05-24 12:34:55 UTC
Type: ---
Embargoed:
eclipseo: fedora-review+


Attachments (Terms of Use)

Description ed-fedora@s5h.net 2020-11-24 14:29:54 UTC
Spec URL: http://www.usenix.org.uk/rpm/rust-pleaser.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pleaser-0.3.16-1.fc34.src.rpm
Description: Please, a polite regex-first sudo alternative. 
Fedora Account System Username: eneville

Requires sponsor.

Comment 1 Robert-André Mauchin 🐧 2021-01-20 20:37:32 UTC
- Not useful:

 [dependencies.chrono]
-version = "0.4.11"
+version = "0.4"

 - Why do you downgrade rpassword:

 [dependencies.rpassword]
-version = "5.0.0"
+version = "4.0"

Add a comment above the patch explaining what you have changed.

 - You must include the license file with %license in %files devel

Comment 2 ed-fedora@s5h.net 2021-03-14 11:53:39 UTC
Hello, I believe the changes requested are now done in the following:

Spec URL: http://www.usenix.org.uk/rpm/rust-pleaser.spec
SRPM URL: http://www.usenix.org.uk/rpm/rust-pleaser-0.3.25-1.fc35.src.rpm

Thanks for looking

Comment 3 Robert-André Mauchin 🐧 2021-03-14 16:15:02 UTC
 - I believe the main binary package should include the license as well:


%files       -n %{crate}
%doc README.md
%license LICENSE
%{_bindir}/please
%{_bindir}/pleaseedit
%{_mandir}/man1/please.1*
%{_mandir}/man5/please.ini.5*
%config(noreplace) /etc/pam.d/please
%config(noreplace) /etc/pam.d/pleaseedit
%endif

 - You didn't add a comment above the patch explaining what you have changed.

# Patch for syslog dependency
# - Bump syslog to 0.5
Patch0:         pleaser-fix-metadata.diff

You also need to link to the upstream PR you opened bumping the dependency.

Comment 4 ed-fedora@s5h.net 2021-03-14 17:11:53 UTC
Hello, thanks again for looking. I believe this is now amended and ready to review.

Comment 5 Robert-André Mauchin 🐧 2021-03-15 08:47:51 UTC
Package approved. You still need to find a sponsor as described here: https://fedoraproject.org/wiki/How_to_get_sponsored_into_the_packager_group

Comment 6 Robert-André Mauchin 🐧 2021-05-08 09:53:15 UTC
Sponsored.

Comment 7 Gwyn Ciesla 2021-05-28 19:31:18 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/rust-pleaser

Comment 8 Package Review 2022-05-24 12:34:55 UTC
Package is available in repositories, closing.


Note You need to log in before you can comment on or make changes to this bug.