Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-HTTP.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-HTTP-1.4.0-2.fc5.src.rpm Description: The HTTP class is a class with static methods for doing miscellaneous HTTP related stuff like date formatting, language negotiation or HTTP redirection. Also see Bug #190066
Waiting for Bug #190252
New spec and SRPM using %{_datadir}/pear/.pkgxml Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-HTTP.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-HTTP-1.4.0-2.fc5.src.rpm Build succeed with mock.
Needs work: * don't remove the buildroot in %prep (it breaks rpmbuild -bi --short-circuit) * do the sanity check in %check * it would be nice to add "|| :" at the end of the pear lines in the scriptlets, to make sure they won't return a failure and block the whole rpm transaction Minor: * Use "BuildArch:" instead of the full BuildArchitectures * Include the LICENCE as you did with php-pear-Mail. This is not a requirement though (it would be if the tarball shipped the license, which is not the case here)
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-HTTP.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-HTTP-1.4.0-3.fc5.src.rpm Mock Build.log : http://remi.collet.free.fr/rpms/extras/php-pear-HTTP-build.log - Require pear >= 1.4.9 - bundle the v3.01 PHP LICENSE file - use --packagingroot (instead of -R) - move check from install to check
Review for release 3: * RPM name is OK * Source HTTP-1.4.0.tgz is the same as upstream * Builds fine in mock * rpmlint looks OK * File list looks OK * Works fine APPROVED Note : The line "%{__install} -m 644 -c %{SOURCE1} LICENSE" is more usually found in %prep, but that's not a blocker.
This package should have: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 The dist tags should be removed from the %changelog Use of ||: must be explained in spec file or removed
(In reply to comment #6) > Use of ||: must be explained in spec file or removed The "||:" in the scriptlets should stay. In an rpm transaction involving multiple packages (for example, an update of multiple php-pear-* packages), if one of the scriptlets "fails", the rpm transaction stops at that point. This can leave the system and its rpm database in a bad state. Supposing five packages were updated and the %postun of the first one failed. The transaction would stop at that point, leaving two copies of the other four packages installed. See also http://www.fedoraproject.org/wiki/ScriptletSnippets where you'll find many more examples of the use of this idiom.
Okay, my bad then. Remi: you can ignore my comments about ||: on all my reviews of your packages.
Approved version 1.4.0-3 push to CVS. Waiting for PHP guidelines before running the build and adding the last suggestion (Comment #5 and #6).
*** Bug 197561 has been marked as a duplicate of this bug. ***
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-HTTP.spec Release 1.4.0-4 pushed to CVS (use the new /etc/rpm/macros.pear) Waiting for PHP guidelines before running the build.
Looks like the guidelines got finalized and this package was built and pushed out. I am going to close this NEXTRELEASE. Feel free to re-open if I am doing so in error.
Package Change Request ====================== Package Name: php-pear-HTTP New Branches: EL-5
done