This service will be undergoing maintenance at 00:00 UTC, 2017-10-23 It is expected to last about 30 minutes
Bug 190156 - Review Request: php-pear-HTTP
Review Request: php-pear-HTTP
Product: Fedora
Classification: Fedora
Component: Package Review (Show other bugs)
All Linux
medium Severity medium
: ---
: ---
Assigned To: Aurelien Bompard
Fedora Package Reviews List
: 197561 (view as bug list)
Depends On: 190252
  Show dependency treegraph
Reported: 2006-04-28 04:40 EDT by Remi Collet
Modified: 2007-11-30 17:11 EST (History)
2 users (show)

See Also:
Fixed In Version:
Doc Type: Bug Fix
Doc Text:
Story Points: ---
Clone Of:
Last Closed: 2006-09-02 16:45:39 EDT
Type: ---
Regression: ---
Mount Type: ---
Documentation: ---
Verified Versions:
Category: ---
oVirt Team: ---
RHEL 7.3 requirements from Atomic Host:
Cloudforms Team: ---
petersen: fedora‑cvs+

Attachments (Terms of Use)

  None (edit)
Description Remi Collet 2006-04-28 04:40:13 EDT
Spec URL:
The HTTP class is a class with static methods for doing
miscellaneous HTTP related stuff like date formatting,
language negotiation or HTTP redirection.

Also see Bug #190066
Comment 1 Remi Collet 2006-04-30 03:21:12 EDT
Waiting for Bug #190252
Comment 2 Remi Collet 2006-05-06 14:02:19 EDT
New spec and SRPM using %{_datadir}/pear/.pkgxml

Spec URL:

Build succeed with mock.
Comment 3 Aurelien Bompard 2006-05-20 05:06:53 EDT
Needs work:
 * don't remove the buildroot in %prep (it breaks rpmbuild -bi --short-circuit)
 * do the sanity check in %check
 * it would be nice to add "|| :" at the end of the pear lines in the scriptlets,
   to make sure they won't return a failure and block the whole rpm transaction

 * Use "BuildArch:" instead of the full BuildArchitectures
 * Include the LICENCE as you did with php-pear-Mail. This is not a requirement 
   though (it would be if the tarball shipped the license, which is not the case
Comment 4 Remi Collet 2006-05-20 11:27:29 EDT
Spec URL:
Mock Build.log :

- Require pear >= 1.4.9
- bundle the v3.01 PHP LICENSE file
- use --packagingroot (instead of -R)
- move check from install to check

Comment 5 Aurelien Bompard 2006-05-20 11:53:25 EDT
Review for release 3:
* RPM name is OK
* Source HTTP-1.4.0.tgz is the same as upstream
* Builds fine in mock
* rpmlint looks OK
* File list looks OK
* Works fine


Note : The line "%{__install} -m 644 -c %{SOURCE1} LICENSE" is more usually
found in %prep, but that's not a blocker.
Comment 6 Christopher Stone 2006-06-27 19:47:11 EDT
This package should have:
Requires(post):   php-pear >= 1.4.9
Requires(postun): php-pear >= 1.4.9

The dist tags should be removed from the %changelog
Use of ||: must be explained in spec file or removed
Comment 7 Paul Howarth 2006-06-28 03:52:06 EDT
(In reply to comment #6)
> Use of ||: must be explained in spec file or removed

The "||:" in the scriptlets should stay. In an rpm transaction involving
multiple packages (for example, an update of multiple php-pear-* packages), if
one of the scriptlets "fails", the rpm transaction stops at that point. This can
leave the system and its rpm database in a bad state. Supposing five packages
were updated and the %postun of the first one failed. The transaction would stop
at that point, leaving two copies of the other four packages installed.

See also where you'll find
many more examples of the use of this idiom.

Comment 8 Christopher Stone 2006-06-28 04:02:25 EDT
Okay, my bad then.  Remi: you can ignore my comments about ||: on all my reviews
of your packages.
Comment 9 Remi Collet 2006-07-03 16:45:57 EDT
Approved version 1.4.0-3 push to CVS.
Waiting for PHP guidelines before running the build and adding the last
suggestion (Comment #5 and #6).
Comment 10 Remi Collet 2006-07-15 04:56:28 EDT
*** Bug 197561 has been marked as a duplicate of this bug. ***
Comment 11 Remi Collet 2006-07-16 10:27:15 EDT
Spec URL:

Release 1.4.0-4 pushed to CVS (use the new /etc/rpm/macros.pear)
Waiting for PHP guidelines before running the build.
Comment 12 Kevin Fenzi 2006-09-02 16:45:39 EDT
Looks like the guidelines got finalized and this package was built and pushed 
out. I am going to close this NEXTRELEASE. Feel free to re-open if I am doing 
so in error. 
Comment 13 Remi Collet 2007-03-31 04:24:12 EDT
Package Change Request
Package Name: php-pear-HTTP
New Branches: EL-5
Comment 14 Jens Petersen 2007-04-02 08:48:27 EDT

Note You need to log in before you can comment on or make changes to this bug.