Version:

$ ./openshift-install-4.7 version
./openshift-install-4.7 4.7.0-0.nightly-2020-11-29-133728
built from commit 64ec239bc596635b50dd82485c9932cdf10c861e
release image registry.svc.ci.openshift.org/ocp/release@sha256:d851f13cc12933e303a932ba100ea6737e62d619049e16e9ba830d46f90fd3e3

Platform: OSP

Please specify:
Both IPI and UPI

What happened?

when no flavor or type given in install-config, validation passed:
# install-config.yaml 
...
compute:
- architecture: amd64
  hyperthreading: Enabled
  name: worker
  platform: {}
  replicas: 2
controlPlane:
  architecture: amd64
  hyperthreading: Enabled
  name: master
  platform: {}
  replicas: 3
...
platform:
  openstack:
    cloud: upshift
    externalNetwork: provider_net_cci_8
    octaviaSupport: '0'
    region: regionOne
    trunkSupport: '1'

$ ./openshift-install-4.7 create manifests --dir .                                                                                                                                                                                       INFO Credentials loaded from file "/home/wjiang/osp_remover/46123/clouds.yaml"                                                                                                                                                                                                  INFO Consuming Install Config from target directory                                                                                                                                                                                                                             INFO Manifests created in: manifests and openshift      

What did you expect to happen?
Validation should prompt user to give a flavor or type for the cluster

How to reproduce it (as minimally and precisely as possible)?

1. create manifests with install-config.yaml which have no flavor and type fields

Anything else we need to know?
1 when checked the manifests it generated, there are no flavor applied to machine
$ cat openshift/99_openshift-cluster-api_master-machines-0.yaml 
apiVersion: machine.openshift.io/v1beta1
kind: Machine
metadata:
  creationTimestamp: null
  labels:
    machine.openshift.io/cluster-api-cluster: wj45ios1019a-b8zsm
    machine.openshift.io/cluster-api-machine-role: master
    machine.openshift.io/cluster-api-machine-type: master
  name: wj45ios1019a-b8zsm-master-0
  namespace: openshift-machine-api
spec:
  metadata:
    creationTimestamp: null
  providerSpec:
    value:
      apiVersion: openstackproviderconfig.openshift.io/v1alpha1
      cloudName: openstack
      cloudsSecret:
        name: openstack-cloud-credentials
        namespace: openshift-machine-api
      flavor: ""
      image: wj45ios1019a-b8zsm-rhcos
      kind: OpenstackProviderSpec
      metadata:
        creationTimestamp: null
      networks:
      - filter: {}
        subnets:
        - filter:
            name: wj45ios1019a-b8zsm-nodes
            tags: openshiftClusterID=wj45ios1019a-b8zsm
      securityGroups:
      - filter: {}
        name: wj45ios1019a-b8zsm-master
      serverGroupName: wj45ios1019a-b8zsm-master
      serverMetadata:
        Name: wj45ios1019a-b8zsm-master
        openshiftClusterID: wj45ios1019a-b8zsm
      tags:
      - openshiftClusterID=wj45ios1019a-b8zsm
      trunk: true
      userDataSecret:
        name: master-user-data
status: {}