Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-1.0.1-1.fc5.src.rpm Description: Provides code to generate responses to common SASL mechanisms, including: o Digest-MD5 o CramMD5 o Plain o Anonymous o Login (Pseudo mechanism)
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-1.0.1-2.fc5.src.rpm Mock build.log : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-build.log
Update to new version 1.0.2 Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL.spec SRPM URL:http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-1.0.2-1.fc5.src.rpm Mock build.log : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-build.log
I will do a formal review on this package but you will not be able to check it in until you are sponsered with bug #190007
Hello. I'm already sponsored by Aurelien Bompard (see Bug #190066). I'm going to mail him about the FE_NEEDSPONSOR on my other package review.
Yes, you are already sponsored and in the cvsextras group. I have removed FE-NEEDSPONSOR from your tickets which had it; if I missed some, go ahead and fix them as well.
MUST ITEM CHECKLIST: - rpmlint output: W: php-pear-Auth-SASL no-documentation W: php-pear-Auth-SASL dangerous-command-in-%post install Should obtain copy of license and include it in %doc The dangerous command can be ignored - package is named according to php packaging naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license field matches actual license - source does not contain license file - spec file is in American English (and french) - spec file is legible - sources match upstream e6a4f4e56dec992ac965678233437aa4 Auth_SASL-1.0.2.tgz - package successfully compiles and builds on FC-5 x86_64 O This package is missing: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - package does not use locales - package does not contain shared libraries in default paths (no need to run ldconfig) - package is not relocatable - package does not own all directories it creates It does not own the /usr/share/pear/Auth directory. - package does not contain any duplicate %files - permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not have large documentation - package does not include header files or static libraries - package does not use pkgconfig files - package does not contain library with suffix - package does not require a devel subpackage - package does not contain any .la files - package is not a gui and does not need a .desktop file - package does not own files or directories owned by other packages This may not be true once php-pear-Auth is packaged SHOULD - Include a copy of BSD license and add it to %doc MUST - Must own the /usr/share/pear/Auth directory add a %dir %{peardir}/Auth might need some discussion with php packages on how to handle shared directories as other packages in the future will need to own this directory as well. - Must Add: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - Explain why adding || : in %post and %postun sections was added, should we not fail if this step fails? - Change %defattr to (-,root,root,-)
Please also remove the dist tags from the spec file's changelog
regarding the directory ownership of /usr/share/pear/Auth 15:17:11 spot | XulChris: if there is no clear requires hierarchy, then yes, they should all own it So if future packages include this directory then they also should own it.
Also, please add php >= 4.0.0 to the Requires to meet PHP packaging guidelines
SPEC : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL.spec SRPM : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-1.0.2-2.fc5.src.rpm Mock : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-build.log Changes : - use new macros from /etc/rpm/macros.pear - own /usr/share/pear/Auth
SPEC : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL.spec SRPM : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-1.0.2-3.fc5.src.rpm Mock : http://remi.collet.free.fr/rpms/extras/php-pear-Auth-SASL-build.log %changelog * Sun Sep 03 2006 Remi Collet <Fedora> 1.0.2-3 - new and simpler %%prep and %%install
Looks good. Approved.
Package Change Request ====================== Package Name: php-pear-Auth-SASL New Branches: EL-5
done