Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-1.fc5.src.rpm Description: Provides an implementation of the SMTP protocol using PEAR's Net_Socket class.
Spec URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM URL: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-2.fc5.src.rpm Mock build.log : http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-build.log
I will do a formal review on this package but you will not be able to check it in until you are sponsered with bug #190007
MUST ITEM CHECKLIST: - rpmlint output: W: php-pear-Net-SMTP invalid-license PHP License W: php-pear-Net-SMTP dangerous-command-in-%post install W: php-pear-Net-SMTP invalid-license PHP License Warnings can be ignored - package is named according to php packaging naming guidelines - spec file name matches %{name} - package meets packaging guidelines - package is licensed with open source compatible license - license field matches actual license - source contains license file in %doc - spec file is in American English (and french) - spec file is legible - sources match upstream acd7c31aa6a083ff6bff86ffba02bcbb Net_SMTP-1.2.8.tgz - package successfully compiles and builds on FC-5 x86_64 O This package is missing: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 Requires(hint): php-pear(Auth_SASL) - package does not use locales - package does not contain shared libraries in default paths (no need to run ldconfig) - package is not relocatable - package does not own all directories it creates It does not own the /usr/share/pear/Net directory. - package does not contain any duplicate %files - permissions are set properly - package contains proper %clean section - macro usage is consistant - package contains permissible content - package does not have large documentation - package does not include header files or static libraries - package does not use pkgconfig files - package does not contain library with suffix - package does not require a devel subpackage - package does not contain any .la files - package is not a gui and does not need a .desktop file - package does not own files or directories owned by other packages This may change in future. MUST - Must own the /usr/share/pear/Net directory add a %dir %{peardir}/Net - Must Add: Requires(post): php-pear >= 1.4.9 Requires(postun): php-pear >= 1.4.9 - Uncomment Requires(hint): php-pear(Auth_SASL) - Explain why adding || : in %post and %postun sections was added, should we not fail if this step fails? - Change %defattr to (-,root,root,-) - Remove dist tages in changelog version numbers
It appears Auth_SASL is not optional, so this should be in Requires: not Requries(hint): Also you should add Requires: php >= 4.0.5 The version dependency on php-pear is not needed in the Requires, its only needed in building
Spec: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-3.fc5.src.rpm Mock: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-build.log Changes: - install Licence in prep - use new macros from /etc/rpm/macros.pear - own /usr/share/pear/Net - require php >= 4.0.5
Spec: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP.spec SRPM: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-1.2.8-4.fc5.src.rpm Mock: http://remi.collet.free.fr/rpms/extras/php-pear-Net-SMTP-build.log Changes: - new and simpler %%prep and %%install
Change: %defattr(-,root,root) To: %defattr(-,root,root,-) After checking into CVS. Approved.
Package Change Request ====================== Package Name: php-pear-Net-SMTP New Branches: EL-5
done