Bug 1911243 - Review Request: libnest2d - Library for the 2D bin packaging problem
Summary: Review Request: libnest2d - Library for the 2D bin packaging problem
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: 1911250
TreeView+ depends on / blocked
 
Reported: 2020-12-28 10:52 UTC by Miro Hrončok
Modified: 2020-12-28 17:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-12-28 17:36:32 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Miro Hrončok 2020-12-28 10:52:41 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/libnest2d.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/libnest2d-0.4%5e20200805gitda47825-1.fc33.src.rpm
Description:
A library and framework for the 2D bin packaging problem.

Fedora Account System Username: churchyard

Comment 1 José Matos 2020-12-28 15:38:54 UTC
Hi Miro,
  the license is correct and appropriated for Fedora.

The spec file is readable and well constructed and so the package is approved.


I have just one doubt, why the line that follows?
Provides:       %{name}-static = %{?epoch:%{epoch}:}%{version}-%{release}

As far as I see it there is no static library included only the headers, as the spec file correctly states.

This is a minor issue and you can fix on import based on your reply.

fedora-review has no complaints and neither do I have. :-)

Comment 2 Miro Hrončok 2020-12-28 15:45:56 UTC
Thanks. The static thing is: https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries

Comment 3 José Matos 2020-12-28 15:57:28 UTC
(In reply to Miro Hrončok from comment #2)
> Thanks. The static thing is:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/
> #_packaging_header_only_libraries

That makes sense, as suspected that something related could be the reason. :-)

Comment 4 Gwyn Ciesla 2020-12-28 16:15:32 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/libnest2d

Comment 5 Fedora Update System 2020-12-28 17:36:32 UTC
FEDORA-2020-0ad4dcf19d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.