Bug 1911250 - Review Request: python-pynest2d - Python bindings for libnest2d
Summary: Review Request: python-pynest2d - Python bindings for libnest2d
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: José Matos
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On: 1911243
Blocks:
TreeView+ depends on / blocked
 
Reported: 2020-12-28 11:06 UTC by Miro Hrončok
Modified: 2020-12-28 17:36 UTC (History)
2 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2020-12-28 17:36:34 UTC
Type: ---
Embargoed:
jamatos: fedora-review+


Attachments (Terms of Use)

Description Miro Hrončok 2020-12-28 11:06:32 UTC
Spec URL: https://churchyard.fedorapeople.org/SRPMS/python-pynest2d.spec
SRPM URL: https://churchyard.fedorapeople.org/SRPMS/python-pynest2d-4.8.0-1.fc33.src.rpm

Description:
Binding allowing libnest2d to be called from Python using NumPy.

Fedora Account System Username: churchyard

Comment 1 José Matos 2020-12-28 16:04:28 UTC
This package is even simpler than the package that it depends on.

The license is correct and appropriated for Fedora.
The spec file is simple and correct.

The only complaint that fedora-review issue is:
- Package contains BR: python2-devel or python3-devel

In this case it is clearly python3-devel. In this case the dependency is filled transitively by python3-sip-devel and it would be difficult for it to go away, unless you have other ideas. :-)

The package is approved.

Comment 2 Miro Hrončok 2020-12-28 16:09:57 UTC
I've added the missing dependency explicitly, it was an oversight.

Comment 3 Gwyn Ciesla 2020-12-28 16:15:47 UTC
(fedscm-admin):  The Pagure repository was created at https://src.fedoraproject.org/rpms/python-pynest2d

Comment 4 Fedora Update System 2020-12-28 17:36:34 UTC
FEDORA-2020-0ad4dcf19d has been pushed to the Fedora 34 stable repository.
If problem still persists, please make note of it in this bug report.


Note You need to log in before you can comment on or make changes to this bug.