Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01859248-tllist/tllist.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01859248-tllist/tllist-1.0.4-0.1.fc34.src.rpm Copr URL: https://copr.fedorainfracloud.org/coprs/alebastr/sway-extras/ Description: tllist is a C header-only implementation of a linked list that uses pre-processor macros to implement dynamic types, where the data carrier is typed to whatever you want; both primitive data types are supported as well as aggregated ones such as structs, enums and unions. Review notes: The noarch thing (both patch and sed command) can't be fixed upstream because meson. Either we do it this way or build arch-specific packages for header-only library. Fedora Account System Username: alebastr
Please check https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries. In particular: - You can drop the patch, because header-only libraries must not be noarch. One reason is so that the tests are compiled and executed on all supported architectures. - You will also need to add the appropriate virtual Provide: Provides: %{name}-static = %{version}-%{release}
Done, thanks for reminding me about this guidelines section! Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01867733-tllist/tllist.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01867733-tllist/tllist-1.0.4-0.2.fc34.src.rpm
Looks great now. A nice, clean package. Accepted. Once the dist-git repository is created, consider adding a file “tllist.rpmlintrc” to suppress the spurious messages about spelling errors produced by rpmlint. See https://src.fedoraproject.org/rpms/python-strictyaml/blob/master/f/python-strictyaml.rpmlintrc for an example. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License". 6 files have unknown license. Detailed output of licensecheck in /home/ben/src/fedora/reviews/1912853-tllist/licensecheck.txt [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 1 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: tllist-devel-1.0.4-0.2.fc34.x86_64.rpm tllist-1.0.4-0.2.fc34.src.rpm tllist-devel.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee tllist-devel.x86_64: W: spelling-error %description -l en_US structs -> struts, destructs, obstructs tllist-devel.x86_64: W: spelling-error %description -l en_US enums -> menus, plenums tllist.src: W: spelling-error %description -l en_US pre -> per, ore, pee tllist.src: W: spelling-error %description -l en_US structs -> struts, destructs, obstructs tllist.src: W: spelling-error %description -l en_US enums -> menus, plenums 2 packages and 0 specfiles checked; 0 errors, 6 warnings. Rpmlint (installed packages) ---------------------------- tllist-devel.x86_64: W: spelling-error %description -l en_US pre -> per, ore, pee tllist-devel.x86_64: W: spelling-error %description -l en_US structs -> struts, destructs, obstructs tllist-devel.x86_64: W: spelling-error %description -l en_US enums -> menus, plenums 1 packages and 0 specfiles checked; 0 errors, 3 warnings. Source checksums ---------------- https://codeberg.org/dnkl/tllist/archive/1.0.4.tar.gz#/tllist-1.0.4.tar.gz : CHECKSUM(SHA256) this package : a135934d4955902d67f75f3c542ace3bfb7be3be9c44796852e76ea9e1d82b33 CHECKSUM(SHA256) upstream package : a135934d4955902d67f75f3c542ace3bfb7be3be9c44796852e76ea9e1d82b33 Requires -------- tllist-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config Provides -------- tllist-devel: pkgconfig(tllist) tllist-devel tllist-devel(x86-64) tllist-static Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1912853 Buildroot used: fedora-rawhide-x86_64 Active plugins: Generic, Shell-api, C/C++ Disabled plugins: Python, fonts, Java, Haskell, SugarActivity, R, Perl, PHP, Ocaml Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/tllist
Thanks for the review! > Once the dist-git repository is created, consider adding a file “tllist.rpmlintrc” to suppress the spurious messages about spelling errors produced by rpmlint. Done.