Spec URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01859249-fcft/fcft.spec SRPM URL: https://download.copr.fedorainfracloud.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01859249-fcft/fcft-2.3.2-0.1.fc34.src.rpm Copr URL: https://copr.fedorainfracloud.org/coprs/alebastr/sway-extras/ Description: fcft is a small font loading and glyph rasterization library built on top of FontConfig, FreeType2 and pixman. It can load and cache fonts from a fontconfig-formatted name string, e.g. Monospace:size=12, optionally with user configured fallback fonts. Fedora Account System Username: alebastr
A wonderfully clean spec file. Just a few tiny issues before I can approve it. Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== Issues ===== - Need to document breakdown of multiple licenses in spec file. A comment above the License field like the following would suffice. # The entire source code is MIT except unicode/ which is Unicode https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios - A new change in Fedora 34 is that make is not included in the buildroot. While gcc currently pulls in make as a transitive dependency, this could change. You must add a BR on make. (I think this is still not in the Guidelines.) Or, do “%meson -GNinja” and add a BR on ninja-build instead. https://fedoraproject.org/wiki/Changes/Remove_make_from_BuildRoot - Since tllist is a header-only library, you must BR tllist-static, even though you already BR pkgconfig(tllist). A little silly, I think, but mandatory. https://docs.fedoraproject.org/en-US/packaging-guidelines/#_packaging_header_only_libraries ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 29 files have unknown license. Detailed output of licensecheck in /home/reviewer/1912855-fcft/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [!]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. A comment above the License field like the following would suffice. # The entire source code is MIT except unicode/ which is Unicode https://docs.fedoraproject.org/en-US/packaging-guidelines/LicensingGuidelines/#_multiple_licensing_scenarios [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [-]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fcft-2.3.2-0.1.fc34.x86_64.rpm fcft-devel-2.3.2-0.1.fc34.x86_64.rpm fcft-debuginfo-2.3.2-0.1.fc34.x86_64.rpm fcft-debugsource-2.3.2-0.1.fc34.x86_64.rpm fcft-2.3.2-0.1.fc34.src.rpm fcft.x86_64: W: spelling-error Summary(en_US) rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US pixman -> pix man, pix-man, pitchman fcft.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration fcft.x86_64: W: spelling-error %description -l en_US Monospace -> Mono space, Mono-space, Aerospace fcft.src: W: spelling-error Summary(en_US) rasterization -> sterilization, pasteurization, westernization fcft.src: W: spelling-error %description -l en_US rasterization -> sterilization, pasteurization, westernization fcft.src: W: spelling-error %description -l en_US pixman -> pix man, pix-man, pitchman fcft.src: W: spelling-error %description -l en_US fontconfig -> configuration fcft.src: W: spelling-error %description -l en_US Monospace -> Mono space, Mono-space, Aerospace 5 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (debuginfo) ------------------- Checking: fcft-debuginfo-2.3.2-0.1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- fcft.x86_64: W: spelling-error Summary(en_US) rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US pixman -> pix man, pix-man, pitchman fcft.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration fcft.x86_64: W: spelling-error %description -l en_US Monospace -> Mono space, Mono-space, Aerospace 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Source checksums ---------------- https://codeberg.org/dnkl/fcft/archive/2.3.2.tar.gz#/fcft-2.3.2.tar.gz : CHECKSUM(SHA256) this package : 726fdebb1d29bc40c665015666fd9037981c0b4d0ba3ecafa1994053091e7fa8 CHECKSUM(SHA256) upstream package : 726fdebb1d29bc40c665015666fd9037981c0b4d0ba3ecafa1994053091e7fa8 Requires -------- fcft (rpmlib, GLIBC filtered): libc.so.6()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libharfbuzz.so.0()(64bit) libm.so.6()(64bit) libpixman-1.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) fcft-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config fcft(x86-64) libfcft.so.3()(64bit) pkgconfig(fontconfig) pkgconfig(freetype2) pkgconfig(harfbuzz) pkgconfig(pixman-1) pkgconfig(tllist) fcft-debuginfo (rpmlib, GLIBC filtered): fcft-debugsource (rpmlib, GLIBC filtered): Provides -------- fcft: fcft fcft(x86-64) libfcft.so.3()(64bit) fcft-devel: fcft-devel fcft-devel(x86-64) pkgconfig(fcft) fcft-debuginfo: debuginfo(build-id) fcft-debuginfo fcft-debuginfo(x86-64) fcft-debugsource: fcft-debugsource fcft-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1912855 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: SugarActivity, Python, Haskell, fonts, PHP, Ocaml, Perl, Java, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(In reply to code from comment #1) Thanks for the review! > - Need to document breakdown of multiple licenses in spec file. > A comment above the License field like the following would suffice. Thanks for catching this, fixed in new revision. I thought I've already done that... > - A new change in Fedora 34 is that make is not included in the buildroot. > While gcc currently pulls in make as a transitive dependency, this could > change. You must add a BR on make. (I think this is still not in the > Guidelines.) Or, do “%meson -GNinja” and add a BR on ninja-build instead. 1. meson already uses ninja and doesn't support other generators on Linux. I think you're confusing it with cmake. 2. As per change discussion, BR: make is not needed for meson or cmake projects unless make is used in the spec file explicitly. It's the job of cmake and meson packages to depend on the appropriate generator. The common consent was that for %meson/%meson_build/... and %cmake/%cmake_build/... families of macros the packager is not aware of the default generator and should not care about it. > - Since tllist is a header-only library, you must BR tllist-static, even > though you already BR pkgconfig(tllist). A little silly, I think, but > mandatory. I feel that it defeats the whole purpose of pkgconfig(...) macros, but applied anyways. Spec URL: https://copr-be.cloud.fedoraproject.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01896898-fcft/fcft.spec SRPM URL: https://copr-be.cloud.fedoraproject.org/results/alebastr/sway-extras/fedora-rawhide-x86_64/01896898-fcft/fcft-2.3.2-0.1.fc34.src.rpm
> 1. meson already uses ninja […] This is a little embarrassing, speaking as a regular meson user who knows this perfectly well. I can only plead that I have, as you guessed, reviewed or maintained far too many cmake-based packages lately. Please ignore this finding. > 2. As per change discussion, BR: make is not needed for meson or cmake projects unless make is used in the spec file explicitly. I had missed this in the discussion, and it’s welcome knowledge. Thanks. > I feel that it defeats the whole purpose of pkgconfig(...) macros, but applied anyways. I tend to agree. I think that it’s supposed to help find packages that must be rebuilt in case of a security update, but I don’t see why a …-devel or pkgconfig(…) BR isn’t sufficient in most cases. Besides, libraries that have a compiled portion, but have significant functionality in inline functions, are functionally similar (rebuilding the shared object only may not be sufficient for a security update) but not subject to the same rule. Anyway, the guidelines are clear enough that there’s no wiggle room, I think. ==== Approved, with full re-review below. ===== Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated ===== MUST items ===== C/C++: [x]: Package does not contain kernel modules. [x]: Package contains no static executables. [x]: If your application is a C or C++ application you must list a BuildRequires against gcc, gcc-c++ or clang. [x]: Header files in -devel subpackage, if present. [x]: ldconfig not called in %post and %postun for Fedora 28 and later. [x]: Package does not contain any libtool archives (.la) [x]: Rpath absent or only used for internal libs. [x]: Development (unversioned) .so files in -devel subpackage, if present. Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 29 files have unknown license. Detailed output of licensecheck in /home/reviewer/1912855-fcft/re- review/1912855-fcft/licensecheck.txt [x]: License file installed when any subpackage combination is installed. [x]: If the package is under multiple licenses, the licensing breakdown must be documented in the spec. [x]: %build honors applicable compiler flags or justifies otherwise. [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [x]: Development files must be in a -devel package [x]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Useful -debuginfo package or justification otherwise. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 20480 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: There are rpmlint messages (see attachment). [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [x]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Fully versioned dependency in subpackages if applicable. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: The placement of pkgconfig(.pc) files are correct. [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. [x]: Spec use %global instead of %define unless justified. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on debuginfo package(s). Note: No rpmlint messages. [x]: Rpmlint is run on all installed packages. Note: There are rpmlint messages (see attachment). [x]: Large data in /usr/share should live in a noarch subpackage if package is arched. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: fcft-2.3.2-0.1.fc34.x86_64.rpm fcft-devel-2.3.2-0.1.fc34.x86_64.rpm fcft-debuginfo-2.3.2-0.1.fc34.x86_64.rpm fcft-debugsource-2.3.2-0.1.fc34.x86_64.rpm fcft-2.3.2-0.1.fc34.src.rpm fcft.x86_64: W: spelling-error Summary(en_US) rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US pixman -> pix man, pix-man, pitchman fcft.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration fcft.x86_64: W: spelling-error %description -l en_US Monospace -> Mono space, Mono-space, Aerospace fcft.src: W: spelling-error Summary(en_US) rasterization -> sterilization, pasteurization, westernization fcft.src: W: spelling-error %description -l en_US rasterization -> sterilization, pasteurization, westernization fcft.src: W: spelling-error %description -l en_US pixman -> pix man, pix-man, pitchman fcft.src: W: spelling-error %description -l en_US fontconfig -> configuration fcft.src: W: spelling-error %description -l en_US Monospace -> Mono space, Mono-space, Aerospace 5 packages and 0 specfiles checked; 0 errors, 10 warnings. Rpmlint (debuginfo) ------------------- Checking: fcft-debuginfo-2.3.2-0.1.fc34.x86_64.rpm 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- fcft.x86_64: W: spelling-error Summary(en_US) rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US rasterization -> sterilization, pasteurization, westernization fcft.x86_64: W: spelling-error %description -l en_US pixman -> pix man, pix-man, pitchman fcft.x86_64: W: spelling-error %description -l en_US fontconfig -> configuration fcft.x86_64: W: spelling-error %description -l en_US Monospace -> Mono space, Mono-space, Aerospace 4 packages and 0 specfiles checked; 0 errors, 5 warnings. Source checksums ---------------- https://codeberg.org/dnkl/fcft/archive/2.3.2.tar.gz#/fcft-2.3.2.tar.gz : CHECKSUM(SHA256) this package : 726fdebb1d29bc40c665015666fd9037981c0b4d0ba3ecafa1994053091e7fa8 CHECKSUM(SHA256) upstream package : 726fdebb1d29bc40c665015666fd9037981c0b4d0ba3ecafa1994053091e7fa8 Requires -------- fcft (rpmlib, GLIBC filtered): libc.so.6()(64bit) libfontconfig.so.1()(64bit) libfreetype.so.6()(64bit) libharfbuzz.so.0()(64bit) libm.so.6()(64bit) libpixman-1.so.0()(64bit) libpthread.so.0()(64bit) rtld(GNU_HASH) fcft-devel (rpmlib, GLIBC filtered): /usr/bin/pkg-config fcft(x86-64) libfcft.so.3()(64bit) pkgconfig(fontconfig) pkgconfig(freetype2) pkgconfig(harfbuzz) pkgconfig(pixman-1) pkgconfig(tllist) fcft-debuginfo (rpmlib, GLIBC filtered): fcft-debugsource (rpmlib, GLIBC filtered): Provides -------- fcft: fcft fcft(x86-64) libfcft.so.3()(64bit) fcft-devel: fcft-devel fcft-devel(x86-64) pkgconfig(fcft) fcft-debuginfo: debuginfo(build-id) fcft-debuginfo fcft-debuginfo(x86-64) fcft-debugsource: fcft-debugsource fcft-debugsource(x86-64) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1912855 Buildroot used: fedora-rawhide-x86_64 Active plugins: Shell-api, Generic, C/C++ Disabled plugins: Java, Perl, fonts, Haskell, PHP, Python, SugarActivity, Ocaml, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/fcft