Spec URL: https://raw.githubusercontent.com/firefly-cpp/niaaml-rpm/main/python-niaaml.spec SRPM URL: https://github.com/firefly-cpp/niaaml-rpm/raw/main/python-niaaml-1.1.0-1.fc33.src.rpm Description: NiaAML is a framework for Automated Machine Learning based on nature-inspired algorithms for optimization. This package uses algorithms implementation from NiaPy. Fedora Account System Username: iztokf
Hello Iztok * This line should not be used, and you should delete the installed files that you don't want to package. ``` %define _unpackaged_files_terminate_build 0 ``` I saw that the macros create some extra files in the `site-packages` directory which it shouldn't, hence you should delete those. ``` error: Installed (but unpackaged) file(s) found: /usr/lib/python3.9/site-packages/CHANGELOG.md /usr/lib/python3.9/site-packages/LICENSE ``` * Are you sure the tests are running? It doesn't log anything it running the tests. * Are you sure the BuildRequires are correct? I don't see python3-wheel as a dep anywhere. * Could you also include the documentation as a subpackage? Upstream uses sphinx to build the docs and it would fit nicely to include it as a subpackage. * Here is the automated review for the same. This is a review *template*. Besides handling the [ ]-marked tests you are also supposed to fix the template before pasting into bugzilla: - Add issues you find to the list of issues on top. If there isn't such a list, create one. - Add your own remarks to the template checks. - Add new lines marked [!] or [?] when you discover new things not listed by fedora-review. - Change or remove any text in the template which is plain wrong. In this case you could also file a bug against fedora-review - Remove the "[ ] Manual check required", you will not have any such lines in what you paste. - Remove attachments which you deem not really useful (the rpmlint ones are mandatory, though) - Remove this text Package Review ============== Legend: [x] = Pass, [!] = Fail, [-] = Not applicable, [?] = Not evaluated [ ] = Manual review needed Issues: ======= - Package contains BR: python2-devel or python3-devel ===== MUST items ===== Generic: [x]: Package is licensed with an open-source compatible license and meets other legal requirements as defined in the legal section of Packaging Guidelines. [x]: License field in the package spec file matches the actual license. Note: Checking patched sources after %prep for licenses. Licenses found: "Unknown or generated", "Expat License", "*No copyright* Expat License". 152 files have unknown license. Detailed output of licensecheck in /home/major/Documents/NeuroFedora/review/1913718-python- niaaml/licensecheck.txt [x]: Package contains no bundled libraries without FPC exception. [x]: Changelog in prescribed format. [x]: Sources contain only permissible code or content. [-]: Package contains desktop file if it is a GUI application. [-]: Development files must be in a -devel package [-]: Package uses nothing in %doc for runtime. [x]: Package consistently uses macros (instead of hard-coded directory names). [x]: Package is named according to the Package Naming Guidelines. [x]: Package does not generate any conflict. [x]: Package obeys FHS, except libexecdir and /usr/target. [-]: If the package is a rename of another package, proper Obsoletes and Provides are present. [x]: Requires correct, justified where necessary. [x]: Spec file is legible and written in American English. [-]: Package contains systemd file(s) if in need. [x]: Package is not known to require an ExcludeArch tag. [x]: Large documentation must go in a -doc subpackage. Large could be size (~1MB) or number of files. Note: Documentation size is 30720 bytes in 2 files. [x]: Package complies to the Packaging Guidelines [x]: Package successfully compiles and builds into binary rpms on at least one supported primary architecture. [x]: Package installs properly. [x]: Rpmlint is run on all rpms the build produces. Note: No rpmlint messages. [x]: If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %license. [x]: Package requires other packages for directories it uses. [x]: Package must own all directories that it creates. [x]: Package does not own files or directories owned by other packages. [x]: Package uses either %{buildroot} or $RPM_BUILD_ROOT [x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the beginning of %install. [x]: Macros in Summary, %description expandable at SRPM build time. [x]: Dist tag is present. [x]: Package does not contain duplicates in %files. [x]: Permissions on files are set properly. [x]: Package must not depend on deprecated() packages. [x]: Package use %makeinstall only when make install DESTDIR=... doesn't work. [x]: Package is named using only allowed ASCII characters. [x]: Package does not use a name that already exists. [x]: Package is not relocatable. [x]: Sources used to build the package match the upstream source, as provided in the spec URL. [x]: Spec file name must match the spec package %{name}, in the format %{name}.spec. [x]: File names are valid UTF-8. [x]: Packages must not store files under /srv, /opt or /usr/local Python: [x]: Python eggs must not download any dependencies during the build process. [x]: A package which is used by another package via an egg interface should provide egg info. [x]: Package meets the Packaging Guidelines::Python [x]: Packages MUST NOT have dependencies (either build-time or runtime) on packages named with the unversioned python- prefix unless no properly versioned package exists. Dependencies on Python packages instead MUST use names beginning with python2- or python3- as appropriate. [x]: Python packages must not contain %{pythonX_site(lib|arch)}/* in %files [x]: Binary eggs must be removed in %prep ===== SHOULD items ===== Generic: [-]: If the source package does not include license text(s) as a separate file from upstream, the packager SHOULD query upstream to include it. [x]: Final provides and requires are sane (see attachments). [x]: Package functions as described. [x]: Latest version is packaged. [x]: Package does not include license text files separate from upstream. [x]: Patches link to upstream bugs/comments/lists or are otherwise justified. [-]: Sources are verified with gpgverify first in %prep if upstream publishes signatures. Note: gpgverify is not used. [x]: Description and summary sections in the package spec file contains translations for supported Non-English languages, if available. [x]: Package should compile and build into binary rpms on all supported architectures. [?]: %check is present and all tests pass. [x]: Packages should try to preserve timestamps of original installed files. [!]: Spec use %global instead of %define unless justified. Note: %define requiring justification: %define _unpackaged_files_terminate_build 0 [x]: Reviewer should test that the package builds in mock. [x]: Buildroot is not present [x]: Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) [x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin. [x]: Packager, Vendor, PreReq, Copyright tags should not be in spec file [x]: Sources can be downloaded from URI in Source: tag [x]: SourceX is a working URL. ===== EXTRA items ===== Generic: [x]: Rpmlint is run on all installed packages. Note: No rpmlint messages. [x]: Spec file according to URL is the same as in SRPM. Rpmlint ------- Checking: python3-niaaml-1.1.0-1.fc34.noarch.rpm python-niaaml-1.1.0-1.fc34.src.rpm 2 packages and 0 specfiles checked; 0 errors, 0 warnings. Rpmlint (installed packages) ---------------------------- 1 packages and 0 specfiles checked; 0 errors, 0 warnings. Source checksums ---------------- https://github.com/lukapecnik/NiaAML/archive/1.1.0/NiaAML-1.1.0.tar.gz : CHECKSUM(SHA256) this package : 25706b4825d43d6727586abc876b866b714b9e86b678592f12fe1f7e40122bf9 CHECKSUM(SHA256) upstream package : 25706b4825d43d6727586abc876b866b714b9e86b678592f12fe1f7e40122bf9 Requires -------- python3-niaaml (rpmlib, GLIBC filtered): python(abi) python3.9dist(niapy) python3.9dist(numpy) python3.9dist(pandas) python3.9dist(scikit-learn) Provides -------- python3-niaaml: python-niaaml python3-niaaml python3.9-niaaml python3.9dist(niaaml) python3dist(niaaml) Generated by fedora-review 0.7.6 (b083f91) last change: 2020-11-10 Command line :/usr/bin/fedora-review -b 1913718 Buildroot used: fedora-rawhide-x86_64 Active plugins: Python, Generic, Shell-api Disabled plugins: SugarActivity, Haskell, Perl, fonts, Ocaml, PHP, C/C++, Java, R Disabled flags: EPEL6, EPEL7, DISTTAG, BATCH, EXARCH
Hi Aniket, Thank you very much for a quick response from your side. I have already pushed a new version to this GH repo. My changes in a nutshell: - line: "%define _unpackaged_files_terminate_build 0" was removed, - two files (CHANGELOG.md and LICENSE in site-packages) are now removed, - tests are still disabled by the upstream. Most of the tests are still in its infancy. Actually, package is very fresh. - BuildRequires were revised, - Good points about the documentation! A new subpackage was created.
Dear Iztok Thank you for the changes. The spec looks good. rpmlint reports some warnings for the doc subpackage: ``` python-niaaml-doc.noarch: W: description-shorter-than-summary python-niaaml-doc.noarch: W: hidden-file-or-dir /usr/share/doc/python-niaaml-doc/html/.buildinfo ``` The .buildinfo can be removed, as it would not be required further, but you can keep it if you want to. The description can also be updated if you want to. Approving the review. :D
(fedscm-admin): The Pagure repository was created at https://src.fedoraproject.org/rpms/python-niaaml