Bug 1914246 - python-uvicorn fails to build with Python 3.10 due to problem in python-websockets: the *loop* parameter was removed from Lock()
Summary: python-uvicorn fails to build with Python 3.10 due to problem in python-webso...
Keywords:
Status: NEW
Alias: None
Product: Fedora
Classification: Fedora
Component: python-websockets
Version: rawhide
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: ---
Assignee: Julien Enselme
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: PYTHON3.10
TreeView+ depends on / blocked
 
Reported: 2021-01-08 12:47 UTC by Miro Hrončok
Modified: 2021-02-09 16:24 UTC (History)
5 users (show)

Fixed In Version:
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed:
Type: Bug


Attachments (Terms of Use)

Description Miro Hrončok 2021-01-08 12:47:34 UTC
python-uvicorn fails to build with Python 3.10.0a4.

The tests hang, but when timeout is added, the error is:

Traceback (most recent call last):
  File "uvloop/handles/stream.pyx", line 829, in uvloop.loop.__uv_stream_on_read_impl
  File "/builddir/build/BUILD/uvicorn-0.12.2/uvicorn/protocols/http/h11_impl.py", line 162, in data_received
    self.handle_events()
  File "/builddir/build/BUILD/uvicorn-0.12.2/uvicorn/protocols/http/h11_impl.py", line 211, in handle_events
    self.handle_upgrade(event)
  File "/builddir/build/BUILD/uvicorn-0.12.2/uvicorn/protocols/http/h11_impl.py", line 288, in handle_upgrade
    protocol = self.ws_protocol_class(
  File "/builddir/build/BUILD/uvicorn-0.12.2/uvicorn/protocols/websockets/websockets_impl.py", line 57, in __init__
    super().__init__(ws_handler=self.ws_handler, ws_server=self.ws_server)
  File "/usr/lib64/python3.10/site-packages/websockets/server.py", line 103, in __init__
    super().__init__(**kwargs)
  File "/usr/lib64/python3.10/site-packages/websockets/protocol.py", line 235, in __init__
    self._drain_lock = asyncio.Lock(
  File "/usr/lib64/python3.10/asyncio/locks.py", line 77, in __init__
    super().__init__(loop=loop)
  File "/usr/lib64/python3.10/asyncio/mixins.py", line 17, in __init__
    raise TypeError(
TypeError: As of 3.10, the *loop* parameter was removed from Lock() since it is no longer necessary


This comes from /usr/lib64/python3.10/site-packages/websockets/protocol.py



For the build logs, see:
https://copr-be.cloud.fedoraproject.org/results/@python/python3.10/fedora-rawhide-x86_64/01868465-python-uvicorn/

For all our attempts to build python-uvicorn with Python 3.10, see:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/package/python-uvicorn/

Testing and mass rebuild of packages is happening in copr. You can follow these instructions to test locally in mock if your package builds with Python 3.10:
https://copr.fedorainfracloud.org/coprs/g/python/python3.10/

Let us know here if you have any questions.

Python 3.10 will be included in Fedora 35. To make that update smoother, we're building Fedora packages with early pre-releases of Python 3.10.
A build failure prevents us from testing all dependent packages (transitive [Build]Requires), so if this package is required a lot, it's important for us to get it fixed soon.
We'd appreciate help from the people who know this package best, but if you don't want to work on this now, let us know so we can try to work around it on our side.

Comment 1 Ben Cotton 2021-02-09 15:38:22 UTC
This bug appears to have been reported against 'rawhide' during the Fedora 34 development cycle.
Changing version to 34.


Note You need to log in before you can comment on or make changes to this bug.