Bug 1930757 - Allow control of block-dirty-bitmap persistence via 'block-bitmap-mapping'
Summary: Allow control of block-dirty-bitmap persistence via 'block-bitmap-mapping'
Keywords:
Status: CLOSED ERRATA
Alias: None
Product: Red Hat Enterprise Linux Advanced Virtualization
Classification: Red Hat
Component: qemu-kvm
Version: 8.4
Hardware: Unspecified
OS: Unspecified
unspecified
unspecified
Target Milestone: rc
: 8.4
Assignee: Peter Krempa
QA Contact: Gu Nini
URL:
Whiteboard:
Depends On:
Blocks: 1799015 1867085
TreeView+ depends on / blocked
 
Reported: 2021-02-19 14:08 UTC by Peter Krempa
Modified: 2021-06-02 01:41 UTC (History)
12 users (show)

Fixed In Version: qemu-kvm-5.2.0-10.module+el8.4.0+10217+cbdd2152
Doc Type: If docs needed, set a value
Doc Text:
Clone Of:
Environment:
Last Closed: 2021-05-25 06:47:27 UTC
Type: Bug
Target Upstream Version:
Embargoed:


Attachments (Terms of Use)

Description Peter Krempa 2021-02-19 14:08:50 UTC
Description of problem:
Following commits are needed by libvirt for the incremental backup feature:

commit ca4bfec41d56a1154da89b105048b3462361d0f0
Author: Peter Krempa <pkrempa>
Date:   Fri Feb 12 18:34:25 2021 +0100

    qemu-iotests: 300: Add test case for modifying persistence of bitmap
    
    Verify that the modification of the bitmap persistence over migration
    which is controlled via BitmapMigrationBitmapAliasTransform works
    properly.
    
    Based on TestCrossAliasMigration
    
    Signed-off-by: Peter Krempa <pkrempa>
    Message-Id: <d9c8e9827e9b6001b2dd1b92e64aab858e6d2a86.1613150869.git.pkrempa>
    Reviewed-by: Eric Blake <eblake>
    [eblake: Adjust test for explicit read_zeroes=False]
    Signed-off-by: Eric Blake <eblake>

commit 6e9f21a2aa8a78bc9a512a836a40c79fe50dd2b4
Author: Peter Krempa <pkrempa>
Date:   Fri Feb 12 18:34:24 2021 +0100

    migration: dirty-bitmap: Allow control of bitmap persistence
    
    Bitmap's source persistence is transported over the migration stream and
    the destination mirrors it. In some cases the destination might want to
    persist bitmaps which are not persistent on the source (e.g. the result
    of merging bitmaps from a number of layers on the source when migrating
    into a squashed image) but currently it would need to create another set
    of persistent bitmaps and merge them.
    
    This patch adds a 'transform' property to the alias map which allows
    overriding the persistence of migrated bitmaps both on the source and
    destination sides.
    
    Signed-off-by: Peter Krempa <pkrempa>
    Message-Id: <b20afb675917b86f6359ac3591166ac6d4233573.1613150869.git.pkrempa>
    Reviewed-by: Eric Blake <eblake>
    [eblake: grammar tweaks, drop dead conditional]
    Signed-off-by: Eric Blake <eblake>

commit 0d1e450c7b3117ee635a00c81d9a92666ebc7ffa
Author: Peter Krempa <pkrempa>
Date:   Fri Feb 12 18:34:23 2021 +0100

    migration: dirty-bitmap: Use struct for alias map inner members
    
    Currently the alias mapping hash stores just strings of the target
    objects internally. In further patches we'll be adding another member
    which will need to be stored in the map so pass a copy of the whole
    BitmapMigrationBitmapAlias QAPI struct into the map.
    
    Signed-off-by: Peter Krempa <pkrempa>
    Message-Id: <fc5f27e1fe16cb75e08a248c2d938de3997b9bfb.1613150869.git.pkrempa>
    Reviewed-by: Eric Blake <eblake>
    [eblake: adjust long lines]
    Signed-off-by: Eric Blake <eblake>

The commits add 'transform' to 'BitmapMigrationBitmapAlias' QAPI struct which allows modification of the persistence state of migrated bitmaps.

Version-Release number of selected component (if applicable):


How reproducible:


Steps to Reproduce:
1.
2.
3.

Actual results:


Expected results:


Additional info:

Comment 13 errata-xmlrpc 2021-05-25 06:47:27 UTC
Since the problem described in this bug report should be
resolved in a recent advisory, it has been closed with a
resolution of ERRATA.

For information on the advisory (virt:av bug fix and enhancement update), and where to find the updated
files, follow the link below.

If the solution does not work for you, open a new bug report.

https://access.redhat.com/errata/RHBA-2021:2098


Note You need to log in before you can comment on or make changes to this bug.