Bug 193191 - Review Request: rename of notify-daemon to notification-daemon
Summary: Review Request: rename of notify-daemon to notification-daemon
Keywords:
Status: CLOSED RAWHIDE
Alias: None
Product: Fedora
Classification: Fedora
Component: Package Review
Version: rawhide
Hardware: All
OS: Linux
medium
medium
Target Milestone: ---
Assignee: David Cantrell
QA Contact: Fedora Extras Quality Assurance
URL:
Whiteboard:
Depends On:
Blocks: FC-ACCEPT
TreeView+ depends on / blocked
 
Reported: 2006-05-25 22:14 UTC by John (J5) Palmieri
Modified: 2013-03-13 04:50 UTC (History)
3 users (show)

Fixed In Version:
Clone Of:
Environment:
Last Closed: 2006-06-14 20:33:23 UTC
Type: ---
Embargoed:


Attachments (Terms of Use)

Description John (J5) Palmieri 2006-05-25 22:14:30 UTC
Spec URL: http://people.redhat.com/johnp/files/notification-daemon/notification-daemon.spec
SRPM URL: http://people.redhat.com/johnp/files/notification-daemon/notification-daemon-0.3.5-1.src.rpm
Description: This is a rename to match upstream's rename of the notification-daemon package

Comment 1 Brian Pepple 2006-05-25 23:34:04 UTC
Couple of items:

1. Fails to build in Mock.  Looks like it is due to a missing BR on GConf2-devel.
2. The Requires on gtk2 & dbus are unnecessary, since the devel packages sonames
will pull these in.
3. SOURCE should be a full URL.
4. You can probably pass the --disable-static flag to the configure macro, and
not even build the static libs since your just removing them anyhow.
5. You should probably use the gconf scriptlets from the wiki.
http://fedoraproject.org/wiki/ScriptletSnippets#head-ff64cd482595764f672082d5a3b83e1fc22962e8

Comment 3 Jesse Keating 2006-05-26 20:45:43 UTC
NEEDSWORK:
 - Buildroot needs to follow guideline
 - BuildRequires: autconf automake 
 - Fails to build in mock:
checking for NOTIFICATION_DAEMON... configure: error: Package requirements (
        gtk+-2.0 >= 2.4.0,      glib-2.0 >= 2.4.0,      dbus-1 >= 0.36,        
dbus-glib-1 >= 0.36,    gconf-2.0,      libwnck-1.0 ) were not met:

No package 'libwnck-1.0' found.

Also, the manual Requires, is this because rpm require checking isn't getting it
right?

Comment 4 John (J5) Palmieri 2006-06-05 20:21:45 UTC
Fixed with suggestions.

Not sure why Buildroot isn't just handled by RPM.

Spec URL:
http://people.redhat.com/johnp/files/notification-daemon/notification-daemon.spec
SRPM URL:
http://people.redhat.com/johnp/files/notification-daemon/notification-daemon-0.3.5-3.src.rpm

Comment 5 Jesse Keating 2006-06-14 20:33:23 UTC
THis was built into rawhide.


Note You need to log in before you can comment on or make changes to this bug.